Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable flash checks in triplelift adapter to allow travis build to complete without error #2833

Merged
merged 1 commit into from
Jul 10, 2018

Conversation

jsnellbaker
Copy link
Collaborator

Type of change

  • Other

Description of change

After #2663 was merged into master, we began observing test failures in Travis.

Below is a copy of the error:

  triplelift adapter
    buildRequests
      ✗ exists and is an object
	timeout of 2000ms exceeded. Ensure the done() callback is being called in this test.

When investigating, we discovered it was tied to some logic in the adapter that detected if Flash was enabled or not.

This PR temporarily disables that logic and part of the one test that used it in order to allow Travis to build successfully again.

@jsnellbaker jsnellbaker changed the title disable flash checks to allow travis build to complete without error disable flash checks in triplelift adapter to allow travis build to complete without error Jul 10, 2018
@mkendall07 mkendall07 merged commit df3e346 into master Jul 10, 2018
@mkendall07 mkendall07 mentioned this pull request Jul 10, 2018
10 tasks
@mkendall07 mkendall07 deleted the triplelift_adapter_fix branch August 17, 2018 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants