-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add onBidWon handler to bid adapters spec #2786
Conversation
@Spark-NF Thanks for submitting this PR. Based on some internal discussion, would it be possible to convert this new field to only handle a pixel URL that would be fired if the bidder won rather than allow a free-form callback method? It's likely (unless there's some use-case I'm not aware of) that bidders would ultimately just want to fire off this pixel when they won. So having the field setup to handle this call directly rather than setup customized code (that would need to be reviewed each time) would be more conducive. Please me let me know your thoughts on this. Thanks |
@jsnellbaker I see where you're coming from with this. Indeed, firing pixels would be a very common use of this handler, and I see how having a way to simply provide URLs (or a method that returns them after building them) would be useful. However, I don't think bid adapters should be limited to this. In our case for example, we prefer not to generate an additional network call (to not flood the publisher nor the user), and keep the information that would possibly be passed in the pixel (in this case "our bid won") in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Spark-NF Thanks for the additional feedback/context, those were some valid points.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
This reverts commit 838ccee.
Type of change
Description of change
Some bid adapters might want to know when their bid won the auction. Given listening to events is off-limits for bid adapters, they can now add a
onBidWon
handler to their spec that will be called with their winning bid.Corresponding PR for documentation: prebid/prebid.github.io#864.