don't allow null or undefined bid properties #2865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaiminpanchal27
approved these changes
Jul 19, 2018
jaiminpanchal27
added
the
needs 2nd review
jsnellbaker
approved these changes
Jul 23, 2018
jsnellbaker
added
LGTM
and removed
in progress
needs 2nd review
mkendall07
added a commit
that referenced
this pull request
Jul 24, 2018
This reverts commit f5170d9.
snapwich
pushed a commit
that referenced
this pull request
Jul 24, 2018
|
@snapwich confirming we're good to go from the OpenX side |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Currently it's possible to return bid responses with
undefinedornullvalues and have them considered valid when they should be invalid. This fixes that.This fix should coincide with an update to the OpenX endpoint to have it always turn a valid currency property. Currently it will sometimes set the currency to
undefined.