Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "don't allow null or undefined bid properties" #2886

Merged
merged 2 commits into from
Jul 24, 2018
Merged

Revert "don't allow null or undefined bid properties" #2886

merged 2 commits into from
Jul 24, 2018

Conversation

mkendall07
Copy link
Member

Reverts #2865

@mkendall07
Copy link
Member Author

@bwoolcott asked me to revert this commit.

@snapwich
Copy link
Collaborator

I'm fine with the revert. Is the Zedo revert intentional as well?

@jaiminpanchal27 jaiminpanchal27 added LGTM needs 2nd review Core module updates require two approvals from the core team and removed needs review labels Jul 24, 2018
snapwich
snapwich approved these changes Jul 24, 2018
View reviewed changes
Copy link
Collaborator

@snapwich snapwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snapwich snapwich merged commit 50a9142 into master Jul 24, 2018
@mkendall07
Copy link
Member Author

I just used the github revert button.

@snapwich
Copy link
Collaborator

@mkendall07 it lists the ZEDO commit in the revert commits, but I didn't see the files removed or deleted in the "Files changed" section, so I think it's okay. Not sure why it has that commit though...

@mkendall07 mkendall07 deleted the revert-2865-no-undefined-bids branch August 17, 2018 15:11
florevallatmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request Sep 6, 2018
@mkendall07 @florevallatmrf
Revert "don't allow null or undefined bid properties" (prebid#2886)
2cd6e27 
* Revert "New Adapter ZEDO (prebid#2872)"

This reverts commit 8eedfc3.

* Revert "don't allow null or undefined bid properties (prebid#2865)"

This reverts commit f5170d9.
StefanWallin pushed a commit to mittmedia/Prebid.js that referenced this pull request Sep 28, 2018
@mkendall07 @StefanWallin
Revert "don't allow null or undefined bid properties" (prebid#2886)
729854f 
* Revert "New Adapter ZEDO (prebid#2872)"

This reverts commit 8eedfc3.

* Revert "don't allow null or undefined bid properties (prebid#2865)"

This reverts commit f5170d9.
ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request Jan 30, 2019
@mkendall07
Revert "don't allow null or undefined bid properties" (prebid#2886)
64f8c63 
* Revert "New Adapter ZEDO (prebid#2872)"

This reverts commit 8eedfc3.

* Revert "don't allow null or undefined bid properties (prebid#2865)"

This reverts commit f5170d9.
AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request Mar 26, 2019
@mkendall07 @AlessandroDG
Revert "don't allow null or undefined bid properties" (prebid#2886)
41fe26f 
* Revert "New Adapter ZEDO (prebid#2872)"

This reverts commit 8eedfc3.

* Revert "don't allow null or undefined bid properties (prebid#2865)"

This reverts commit f5170d9.
AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request Mar 26, 2019
@mkendall07 @AlessandroDG
Revert "don't allow null or undefined bid properties" (prebid#2886)
42ac7be 
* Revert "New Adapter ZEDO (prebid#2872)"

This reverts commit 8eedfc3.

* Revert "don't allow null or undefined bid properties (prebid#2865)"

This reverts commit f5170d9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaiminpanchal27 jaiminpanchal27 jaiminpanchal27 approved these changes

@snapwich snapwich snapwich approved these changes

Assignees

@snapwich snapwich

@jaiminpanchal27 jaiminpanchal27

Labels
LGTM needs 2nd review Core module updates require two approvals from the core team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mkendall07 @snapwich @jaiminpanchal27 @mjacobsonny @jsnellbaker