fix failing unit test within quantcastBidAdapter #2879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaiminpanchal27
requested changes
Jul 23, 2018
| @@ -71,8 +71,8 @@ describe('Quantcast adapter', () => { | |||
|
|
|||
| it('sends bid requests to Quantcast Canary Endpoint if `publisherId` is `test-publisher`', () => { | |||
| const requests = qcSpec.buildRequests([bidRequest]); | |||
| const url = new URL(requests[0]['url']); | |||
| expect(url.hostname).to.equal(QUANTCAST_TEST_DOMAIN); | |||
| const hostname = requests[0]['url'].split(/[:/]/)[3]; | |||
There was a problem hiding this comment.
I think we should use this https://github.com/prebid/Prebid.js/blob/master/src/url.js#L27 here.
|
@jaiminpanchal27 Thanks for the feedback; I switched to the |
jaiminpanchal27
approved these changes
Jul 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Since the inclusion of #2828 the Travis builds for master have been failing due to a failed unit test for IE 11 within the
quantcastBIdAdapter_spec.jsfile. See job link:https://travis-ci.org/prebid/Prebid.js/builds/406331258
This PR addresses the test failure by replacing the
new URL()code (which isn't supported in IE) with a different set of code that performs the same action needed for the test.CC @soarez