Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix failing unit test within quantcastBidAdapter #2879

Merged
merged 3 commits into from
Jul 23, 2018
Merged

fix failing unit test within quantcastBidAdapter #2879

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c224d39
fix failing unit test for quantcastBidAdapter
jsnellbaker Jul 23, 2018
37d01eb
rename variable to be clearer
jsnellbaker Jul 23, 2018
3f43c20
using alternate approach
jsnellbaker Jul 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/spec/modules/quantcastBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,8 @@ describe('Quantcast adapter', () => {

it('sends bid requests to Quantcast Canary Endpoint if `publisherId` is `test-publisher`', () => {
const requests = qcSpec.buildRequests([bidRequest]);
const url = new URL(requests[0]['url']);
expect(url.hostname).to.equal(QUANTCAST_TEST_DOMAIN);
const hostname = requests[0]['url'].split(/[:/]/)[3];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use this https://github.com/prebid/Prebid.js/blob/master/src/url.js#L27 here.

expect(hostname).to.equal(QUANTCAST_TEST_DOMAIN);
});

it('sends bid requests to default endpoint for non standard publisher IDs', () => {
Expand Down