-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Adikteev adapter (PR updated) #3391
Conversation
e7a1896
to
f963440
Compare
f963440
to
eca62a6
Compare
@mike-chowla it should be OK and respond with code 200 now. Thanks for your review 🙂 |
I tried it again I'm still not getting any bid back. Here's the POST body your adapter is sending: |
My bad @mike-chowla, sorry for the delay. I thought it was only needed to send response code 200 with an (empty) array of bid responses. Now it returns a real bid from our system. |
Something has changed, now tests must asynchronously set config.
1c83222
to
dcca2b6
Compare
Hi there,
@mike-chowla In order to ease our integration, would you like to review this PR again? It's been some time we haven't heard from you. I'll be more than happy to do whatever is needed to get this PR merged 🙂 Cheers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No add is rendering with the test parameters due to the bid getting dropped.
Also, please change the PR comments to reflect the correct test parameters (adSpaceId)
Apologies for the slow response. I've been traveling the last couple of weeks and have gotten behind on my PR reviews |
Hey! Thank you very much for your reply. Here is how I test it. I launch Chrome network dev tools show there is a call to [{"netRevenue":true,"width":300,"currency":"EUR","requestId":"2638a6b3ee42ba","creativeId":41601,"ttl":360,"ad":"<div><img height=\"1\" src=\"https://event-adserver.adikteev.com/api/ad_event.json?ad_space_id=5084&sdk_version=8452&what=on_ad_ready_by_sdk&campaign_id=41601&placement_id=46528&device=351d362a-b9ce-4759-af4e-420870263dae&ip=84.14.114.166\" style=\"display:none;visibility:hidden;\" width=\"1\" /><iframe src=\"https://serve-adserver.adikteev.com/api/prebid/serve?ad_space_id=5084&bid_id=2638a6b3ee42ba&sdk_version=9001&placement_id=46528&creative_id=41601\" style=\"background::transparent;border:0;height:100%;margin:0;overflow::hidden;padding:0;width:100%;\"></iframe></div>","cpm":3.325,"height":250}] Once formatted it becomes: [{
"netRevenue": true,
"width": 300,
"currency": "EUR",
"requestId": "2303a14333cf4f",
"creativeId": 41601,
"ttl": 360,
"ad": "<div><img height=\"1\" src=\"https://event-adserver.adikteev.com/api/ad_event.json?ad_space_id=5084&sdk_version=8452&what=on_ad_ready_by_sdk&campaign_id=41601&placement_id=46528&device=e61b94de-4714-4f57-ab3e-6b83f3669f9c&ip=84.14.114.166\" style=\"display:none;visibility:hidden;\" width=\"1\" /><iframe src=\"https://serve-adserver.adikteev.com/api/prebid/serve?ad_space_id=5084&bid_id=2303a14333cf4f&sdk_version=9001&placement_id=46528&creative_id=41601\" style=\"background::transparent;border:0;height:100%;margin:0;overflow::hidden;padding:0;width:100%;\"></iframe></div>",
"cpm": 3.325,
"height": 250
}] Am I missing something? |
It seems that |
Anything I can do to help review this PR? I know it's not enough for this PR to WorkOnMyMachine® 😉 but I'm unsure what I can do more. |
I tried this again but still getting no bids back. Request URL: https://prebid.adikteev.com/api/prebid/bid Request Body: |
OK, I believe I got it. The ad set up for Prebid was restricted in some countries. Please accept my apologies for that! At least it demonstrates we run our actual ad engine and give an actual response, not a canned one 🙂 |
Well, this error 500 was because of the update of some campaign. Should be alright now. |
Hey, anything new on here? I've compiled Prebid on commit 537698d with command I've put the integration code page of So far it's been working for the last 7 days. Any feedback on your side? Cheers. For the sake of completion, here are: POST request to https://prebid.adikteev.com/api/prebid/bidcurl 'https://prebid.adikteev.com/api/prebid/bid' -H 'Referer: https://fiddle.jshell.net/' -H 'Origin: https://fiddle.jshell.net' -H 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/74.0.3724.0 Safari/537.36' -H 'Content-Type: text/plain' --data-binary '{"akPbjsVersion":"1.35.0","bidRequests":[{"params":{"adSpaceId":5084},"sizes":[[300,250],[250,300],[300,600]],"bidId":"2c59999bf0ef6e","bidderRequestId":"1b34f78400deb2"}],"debug":false,"language":"en-GB","refererInfo":{"referer":"https://jsfiddle.net/","reachedTop":true,"numIframes":1,"stack":["https://jsfiddle.net/","https://fiddle.jshell.net/kx0s3eLa/9/show/"]},"deviceInfo":{"browserWidth":1175,"browserHeight":294,"deviceWidth":2560,"deviceHeight":1440,"documentWidth":1175,"documentHeight":294,"webGL":true},"userAgent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/74.0.3724.0 Safari/537.36"}' --compressed Beautified response[
{
"netRevenue": true,
"width": 300,
"currency": "EUR",
"requestId": "2c59999bf0ef6e",
"creativeId": 41601,
"ttl": 360,
"ad": "<div><img height=\"1\" src=\"https://event-adserver.adikteev.com/api/ad_event.json?ad_space_id=5084&sdk_version=8452&what=on_ad_ready_by_sdk&campaign_id=41601&placement_id=46528&device=1459c8fa-cc89-4a77-9a64-9d2992aee474&ip=84.14.114.166\" style=\"display:none;visibility:hidden;\" width=\"1\" /><iframe src=\"https://serve-adserver.adikteev.com/api/prebid/serve?ad_space_id=5084&bid_id=2c59999bf0ef6e&sdk_version=8452&placement_id=46528&creative_id=41601\" style=\"background::transparent;border:0;height:100%;margin:0;overflow::hidden;padding:0;width:100%;\"></iframe></div>",
"cpm": 3.325,
"height": 250
}
] |
Please let me know if you experience any hindrance whilst reviewing this PR, I'll be most glad to help you. |
up? |
This PR is tagged with not receiving bids, which prevents it to get merged. To the best of my knowledge it's been inaccurate for the last 12 days, except for short periods of time when we've deployed and rolled out some parts of our system. @mike-chowla would you mind check it again? As said in an earlier comment, the integration page code has been put in a jsfiddle and tested on Tor, Firefox (with preset default security settings), and Chrome. The integration page also has been test locally with In all these cases the serving endpoint has been able to receive bids and respond to them, which leads me to think the PR tagging has been inaccurate for some days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@piotr-yuxuan Verified bids getting back. Just one minor change in spec files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @mike-chowla, We need to address the change in this PR for it to be relevant. PS: @jaiminpanchal27 if the change you requested suits you, would you like to approve it? Thx |
For the sake of completion: POST request to https://prebid.emoteev.io/api/prebid/bid
Beautified response[
{
"width": 300,
"ad": "<div><img height=\"1px\" src=\"https://event-adserver.adikteev.com/api/ad_event.json?ad_space_id=5084&sdk_version=8481&what=on_ad_ready_by_sdk&campaign_id=41601&placement_id=58710&device=1733e013-61aa-4063-b153-10ebdb360654&ip=84.14.114.166\" style=\"display:none;visibility:hidden;\" width=\"1px\" /><iframe src=\"https://serve-adserver.adikteev.com/api/prebid/serve?ad_space_id=5084&uid=136a7411-11a9-441d-a0d8-5c3e120ef0fd&sdk_version=8481&placement_id=58710&creative_id=41601\" style=\"background:transparent;border:0;height:100%;margin:0;overflow:hidden;padding:0;width:100%;\"></iframe></div>",
"height": 250,
"currency": "EUR",
"netRevenue": true,
"requestId": "2988189446fab3",
"ttl": 360,
"cpm": 3.325,
"creativeId": 41601
}
] |
Update Adikteev adapter (PR updated)
Update Adikteev adapter (PR updated)
Type of change
Description of change
Test parameters for validating bids