Update adikteev adapter (main PR now merged) #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
piotr-yuxuan
force-pushed
the
update-adikteev-adapter
branch
from
c1e16eb
to
52db270
Compare
bretg
requested changes
Dec 20, 2018
piotr-yuxuan
force-pushed
the
update-adikteev-adapter
branch
from
52db270
to
febc683
Compare
|
@bretg should be better now. |
bretg
approved these changes
Jan 10, 2019
piotr-yuxuan
force-pushed
the
update-adikteev-adapter
branch
from
5e563e5
to
424f0c3
Compare
piotr-yuxuan
force-pushed
the
update-adikteev-adapter
branch
from
424f0c3
to
92ae7c7
Compare
|
Hello @bretg and @mike-chowla, It looks like the adapter PR on the main repo (link) has been burried deep down the last-in-first-out PR wall 🙂 It's quite understandable because a lot of activity has happened since this adapter PR has been open two months ago. I'm trying to get this PR back to your attention, sorry for pinging you here. Would you like to review it again ? Static analysis and CI tests have passed, and I've been checking Adikteev integration test page lately: it responds a correct bid from a test campaign. As a result, to the best of my knowledge, review may be easy. Have a nice week-end. |
piotr-yuxuan
changed the title
|
Now the linked PR has been merged. |
piotr-yuxuan
changed the title
piotr-yuxuan
changed the title
|
deployed with 2.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.