Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add validation to callbackWithBidder to ensure called with function #4734

Merged
merged 2 commits into from
Mar 6, 2020
Merged

add validation to callbackWithBidder to ensure called with function #4734

merged 2 commits into from
Mar 6, 2020

Conversation

snapwich
Copy link
Collaborator

Type of change

  • Bugfix

Description of change

Add check in config.callbackWithBidder to make sure callback is a function to prevent errors from Function.prototype.bind if it is not.

@stale
Copy link

stale bot commented Jan 30, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 30, 2020
@snapwich snapwich added pinned won't be closed by stalebot and removed stale labels Feb 4, 2020
@harpere harpere added needs 2nd review Core module updates require two approvals from the core team and removed needs review labels Mar 5, 2020
@jaiminpanchal27 jaiminpanchal27 merged commit 4f78849 into master Mar 6, 2020
bmwcmw pushed a commit to criteo-forks/Prebid.js that referenced this pull request Mar 31, 2020
@snapwich
add validation to callbackWithBidder to ensure called with function (p…
4690d7f 
…rebid#4734)

* add validation to callbackWithBidder to ensure called with function

* better error message in callbackWithBidder
rjvelicaria pushed a commit to openx/Prebid.js that referenced this pull request Apr 9, 2020
@snapwich @rjvelicaria
add validation to callbackWithBidder to ensure called with function (p…
76e51b0 
…rebid#4734)

* add validation to callbackWithBidder to ensure called with function

* better error message in callbackWithBidder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaiminpanchal27 jaiminpanchal27 jaiminpanchal27 approved these changes

@harpere harpere harpere approved these changes

@robertrmartinez robertrmartinez Awaiting requested review from robertrmartinez

Assignees

@jaiminpanchal27 jaiminpanchal27

Labels
needs 2nd review Core module updates require two approvals from the core team pinned won't be closed by stalebot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@snapwich @harpere @jaiminpanchal27 @bretg