Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add validation to callbackWithBidder to ensure called with function #4734

Merged
merged 2 commits into from
Mar 6, 2020
Merged

add validation to callbackWithBidder to ensure called with function #4734

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d5a497
add validation to callbackWithBidder to ensure called with function
snapwich Jan 14, 2020
e9df3fa
better error message in callbackWithBidder
snapwich Jan 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,11 @@ export function newConfig() {
function callbackWithBidder(bidder) {
return function(cb) {
return function(...args) {
return runWithBidder(bidder, utils.bind.call(cb, this, ...args))
if (typeof cb === 'function') {
return runWithBidder(bidder, utils.bind.call(cb, this, ...args))
} else {
utils.logWarn('config.callbackWithBidder callback is not a function');
}
}
}
}
Expand Down