OneVideo: Sync pixel redirect fix and Test cases #4741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove deprecated legacy url from pbs adapter * fix eslint errors * add and update tests for openRtb2 endpoint
This reverts commit 8c2b196.
bretg
requested changes
Jan 16, 2020
| @@ -408,7 +408,7 @@ describe('OneVideoBidAdapter', function () { | |||
| it('should get correct user sync when iframeEnabled', function () { | |||
| let pixel = spec.getUserSyncs({pixelEnabled: true}, {}, {gdprApplies: true, consentString: GDPR_CONSENT_STRING}) | |||
| expect(pixel[2].type).to.equal('image'); | |||
| expect(pixel[2].url).to.equal('https://sync-tm.everesttech.net/upi/pid/m7y5t93k?gdpr_qparam=1&gdpr_consent_qparam=' + GDPR_CONSENT_STRING + '&redir=https%3A%2F%2Fpixel.advertising.com%2Fups%2F55986%2Fsync%3Fuid%3D%24%7BUSER_ID%7D%26_origin%3D0%26gdpr%3D{gdpr}%26gdpr_consent%3D{gdpr_consent}'); | |||
| expect(pixel[2].url).to.equal('https://sync-tm.everesttech.net/upi/pid/m7y5t93k?gdpr=1&gdpr_consent=' + GDPR_CONSENT_STRING + '&redir=https%3A%2F%2Fpixel.advertising.com%2Fups%2F55986%2Fsync%3Fuid%3D%24%7BUSER_ID%7D%26_origin%3D0&gdpr=1&gdpr_consent=GDPR_CONSENT_STRING'); | |||
There was a problem hiding this comment.
Seems like the tail end of this ought to be
...&gdpr_consent=' + encodeURI(GDPR_CONSENT_STRING)
?
added 2 commits
January 16, 2020 21:21
…/DeepthiNeeladri/Prebid.js into SyncPixel_Change_OnevideoAdaptor
|
@bretg corrected the test case review pls |
bretg
approved these changes
Jan 16, 2020
bretg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
@bretg you are right #4718 I need to send gdpr%3D{gdpr}%26gdpr_consent%3D{gdpr_consent} only done the changes and test cases are written.
we need to fill both https://sync-tm.everesttech.net/upi/pid/m7y5t93k?gdpr=${gdprApplies ? 1 : 0}&gdpr_consent=${consentString} macros and redirect url macros also redir=https%3A%2F%2Fpixel.advertising.com%2Fups%2F55986%2Fsync%3Fuid%3D%24%7BUSER_ID%7D%26_origin%3D0
+ encodeURI(&gdpr=${gdprApplies ? 1 : 0}&gdpr_consent=${consentString}`) the advertising.com is not resolving the macros checked with publisher.Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information