Sync pixel change onevideo adaptor #4718

DeepthiNeeladri · 2020-01-12T14:10:13Z

Type of change

[X ] Bugfix

Description of change

updating the sync pixel the params will be filled by the redirect URL

test parameters for validating bids

{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

contact email of the adapter’s maintainer
official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

A link to a PR on the docs repo at https://github.com/prebid/prebid.github.io/

Other information

@bretg review pls, tests which are failing are not related to my code.

* remove deprecated legacy url from pbs adapter * fix eslint errors * add and update tests for openRtb2 endpoint

This reverts commit 8c2b196.

* deprecate domain/referer type functions * delete modules that are using deprecated methods from utils.js * remove reference to getTopWindowLocation * sync with prebid-3.0 branch * remove test suite for getTopWindowLocation * add back md files of all deleted adapters * add md files of deleted analytics adapters * add adapters that are 3.0 compliant * add back the rubicon skipped test

bretg

What are {gdpr_qparam} & {gdpr_consent_qparam} ? Be aware those aren't macros that will be resolved by Prebid.js and I don't see your module resolving them either.

DeepthiNeeladri · 2020-01-14T02:43:40Z

@bretg the redirect URL will be filling the params tested pls check the screenshot

@bretg it is a blocker issue at our end can you please review and can confirm when it will be released.

bretg · 2020-01-14T18:55:11Z

Your call to getUserSyncs: function(syncOptions) is probably not going to work the way want it to.

Specifically, I suspect you want ...%26gdpr%3D{gdpr}%26gdpr_consent%3D{gdpr_consent} to be resolved with the actual {gdpr} and {gdpr_consent} values. That won't happen unless you make it happen in your getUserSyncs function. You should be looking for the additional parameters like this:

getUserSyncs: function (syncOptions, responses, gdprConsent, uspConsent) {
    // resolve your macros with the gdprConsent object !
}

Bottom line: don't expect the Prebid.js core to resolve your {macros} -- you have to do it yourself with the parameters sent into getUserSyncs

If you're telling me that you want the {macros} to be sent unresolved to your endpoint, then I don't know why you're bothering to send GDPR macros at all.

To save you some time, gdprConsent is an object with a couple of attributes you'll want to use:

You should resolve {gdpr} to gdprConsent.gdprApplies
You should resolve {gdpr_consent} to gdprConsent.consentString

DeepthiNeeladri · 2020-01-15T14:31:43Z

@bretg you are right!! thanks for correcting me. made the changes at getUserSyncs. Review pls

bretg

Besides the comments here, you need to update your unit tests to check that the usersync URL is getting resolved properly.

bretg · 2020-01-15T15:39:54Z

modules/oneVideoBidAdapter.js

@@ -6,7 +6,7 @@ export const spec = {
  ENDPOINT: 'https://ads.adaptv.advertising.com/rtb/openrtb?ext_id=',
  SYNC_ENDPOINT1: 'https://cm.g.doubleclick.net/pixel?google_nid=adaptv_dbm&google_cm&google_sc',
  SYNC_ENDPOINT2: 'https://pr-bh.ybp.yahoo.com/sync/adaptv_ortb/{combo_uid}',
-  SYNC_ENDPOINT3: 'https://sync-tm.everesttech.net/upi/pid/m7y5t93k?redir=https%3A%2F%2Fsync.adap.tv%2Fsync%3Ftype%3Dgif%26key%3Dtubemogul%26uid%3D%24%7BUSER_ID%7D',
+  SYNC_ENDPOINT3: 'https://sync-tm.everesttech.net/upi/pid/m7y5t93k?{gdpr_qparam}&{gdpr_consent_qparam}&redir=https%3A%2F%2Fpixel.advertising.com%2Fups%2F55986%2Fsync%3Fuid%3D%24%7BUSER_ID%7D%26_origin%3D0%26gdpr%3D{gdpr}%26gdpr_consent%3D{gdpr_consent}',


You're no longer using SYNC_ENDPOINT3. Either remove it or start using it please.

bretg · 2020-01-15T15:41:51Z

modules/oneVideoBidAdapter.js

@@ -115,7 +116,7 @@ export const spec = {
      },
      {
        type: 'image',
-        url: spec.SYNC_ENDPOINT3
+        url: `https://sync-tm.everesttech.net/upi/pid/m7y5t93k?gdpr_qparam==${gdprApplies ? 1 : 0}&gdpr_consent_qparam=${consentString}&redir=https%3A%2F%2Fpixel.advertising.com%2Fups%2F55986%2Fsync%3Fuid%3D%24%7BUSER_ID%7D%26_origin%3D0%26gdpr%3D{gdpr}%26gdpr_consent%3D{gdpr_consent}`


I don't think this is what you want:

gdpr_qparam as two equal signs

The macros at the end gdpr%3D{gdpr}%26gdpr_consent%3D{gdpr_consent} are not going to get resolved. If you're using gdpr_qparam instead of gdpr, then you can just drop the ones at the end.

regarding the macros will check with the publisher once and will do the change this is the pixel which was given by 'everesttech' team.

…OnevideoAdaptor

bretg · 2020-01-15T19:00:46Z

Ok - I get the macros at the end now -- gdpr%3D{gdpr}%26gdpr_consent%3D{gdpr_consent} will be resolved by everesttech before going to advertising.com.

Merging.

* outstream changes * removing global filtet * reverting page * message * adapter change * remove space * testcases * testpage * spaces for test page * renderer exist case * reverting package-lock.json * adding schain object * adding tagid * syntaxx error fix * video.html * space trailing * space * tagid * inventoryId and placement * rewarded video * added unit test case * Remove pbs depracated legacy url (prebid#4226) * remove deprecated legacy url from pbs adapter * fix eslint errors * add and update tests for openRtb2 endpoint * sync with master * Revert "sync with master" This reverts commit 8c2b196. * removed targeting set filter and moved where render status is set to work with safeframe creatives (prebid#4236) * Depracate adloader loadscript fn (prebid#4228) * test commit * add callback support to loadExternalScript() * pass moduleCode for renderers * test cases for loadExternalScript() * store callbacks for cached url * fully remove adloader() * call callback() from stub * remove and update function name * getHighestCpmBids only returns non-rendered bids (prebid#4247) * Make all adapters https (prebid#4294) * update all adapters to https * convert all adapters to https * update unit tests * remove files confilicting with other PR * Removed pub common and unified id submodules as defaults in user id module (prebid#4445) * Deprecate user sync (prebid#4241) * deprecate some properties of userSync object * change bid adapter to Appnexus * fix 3 failing test cases * make all unit test cases pass * remove debugger * deprecate support for adUnit.sizes for pubs (prebid#4458) * deprecate support for adUnit.sizes for pubs * remove commented code * ccpa cahnges * ccpa change * test page * test page change * test page change 2 * change the variable * Deprecations utils.js (prebid#4249) * deprecate domain/referer type functions * delete modules that are using deprecated methods from utils.js * remove reference to getTopWindowLocation * sync with prebid-3.0 branch * remove test suite for getTopWindowLocation * add back md files of all deleted adapters * add md files of deleted analytics adapters * add adapters that are 3.0 compliant * add back the rubicon skipped test * remove min field from priceGranularity feature (prebid#4574) * ccpa support for v3.0 * Update oneVideoBidAdapter_spec.js * Update oneVideoBidAdapter.js * sync pixel chnge * fix * sync * fix * sync * sync * adding gdpr * test cases Co-authored-by: sumit sharma <sharmasumit116@gmail.com> Co-authored-by: Neelanjan Sen <14229985+Fawke@users.noreply.github.com> Co-authored-by: r-schweitzer <50628828+r-schweitzer@users.noreply.github.com> Co-authored-by: coryhammon1 <coryhammon1@gmail.com> Co-authored-by: jsnellbaker <31102355+jsnellbaker@users.noreply.github.com>

Deepthi Neeladri Sravana and others added 30 commits June 27, 2019 11:56

outstream changes

62516db

removing global filtet

05e333a

reverting page

054b515

message

94cbc2d

adapter change

d49e922

remove space

7a43143

testcases

bc859b3

testpage

0a8a86c

spaces for test page

22e4ec9

renderer exist case

9637b48

reverting package-lock.json

0e2d31b

Merge branch 'master' of https://github.com/prebid/Prebid.js

88ac283

Merge branch 'master' of https://github.com/prebid/Prebid.js

d81769b

Merge branch 'master' of https://github.com/prebid/Prebid.js

2d48e1e

adding schain object

63a37e3

Merge branch 'master' of https://github.com/prebid/Prebid.js

873a2c1

Merge branch 'master' of https://github.com/prebid/Prebid.js

7e68c35

adding tagid

e8c40c3

syntaxx error fix

af32e45

video.html

4bb7c45

space trailing

caf81ac

space

514f68d

tagid

5dc1086

inventoryId and placement

606eb96

rewarded video

4cfb6f4

added unit test case

e03ff33

Remove pbs depracated legacy url (prebid#4226)

7075182

* remove deprecated legacy url from pbs adapter * fix eslint errors * add and update tests for openRtb2 endpoint

sync with master

8c2b196

Revert "sync with master"

06c6fbd

This reverts commit 8c2b196.

Merge branch 'master' into prebid-3.0

8855c1e

Fawke and others added 15 commits December 11, 2019 18:45

sync with master

ca23f38

remove min field from priceGranularity feature (prebid#4574)

2762cb7

merge branch master and resolve conflicts

48cf003

ccpa support for v3.0

30fd314

Merge branch 'prebid-3.0' into CCPA_3.0-support

dbf3eda

Update oneVideoBidAdapter_spec.js

287b695

Update oneVideoBidAdapter.js

22f1a8e

sync pixel chnge

4221391

msater

1b9e421

fix

7bef75d

sync

28a341a

fix

90c96b9

sync

0660a71

sync

e8f733d

bretg reviewed Jan 13, 2020

View reviewed changes

bretg self-assigned this Jan 13, 2020

adding gdpr

a17205b

bretg requested changes Jan 15, 2020

View reviewed changes

Deepthi Neeladri Sravana added 2 commits January 15, 2020 22:48

test cases

fcfa5a8

Merge remote-tracking branch 'upstream/master' into SyncPixel_Change_…

958f638

…OnevideoAdaptor

bretg approved these changes Jan 15, 2020

View reviewed changes

bretg merged commit d40ca16 into prebid:master Jan 15, 2020

DeepthiNeeladri mentioned this pull request Jan 16, 2020

OneVideo: Sync pixel redirect fix and Test cases #4741

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sync pixel change onevideo adaptor #4718

Sync pixel change onevideo adaptor #4718

DeepthiNeeladri commented Jan 12, 2020 •

edited

Loading

bretg left a comment

DeepthiNeeladri commented Jan 14, 2020 •

edited

Loading

bretg commented Jan 14, 2020 •

edited

Loading

DeepthiNeeladri commented Jan 15, 2020 •

edited

Loading

bretg left a comment

bretg Jan 15, 2020

DeepthiNeeladri Jan 15, 2020

bretg Jan 15, 2020

DeepthiNeeladri Jan 15, 2020

bretg commented Jan 15, 2020

Sync pixel change onevideo adaptor #4718

Sync pixel change onevideo adaptor #4718

Conversation

DeepthiNeeladri commented Jan 12, 2020 • edited Loading

Type of change

Description of change

Other information

bretg left a comment

Choose a reason for hiding this comment

DeepthiNeeladri commented Jan 14, 2020 • edited Loading

bretg commented Jan 14, 2020 • edited Loading

DeepthiNeeladri commented Jan 15, 2020 • edited Loading

bretg left a comment

Choose a reason for hiding this comment

bretg Jan 15, 2020

Choose a reason for hiding this comment

DeepthiNeeladri Jan 15, 2020

Choose a reason for hiding this comment

bretg Jan 15, 2020

Choose a reason for hiding this comment

DeepthiNeeladri Jan 15, 2020

Choose a reason for hiding this comment

bretg commented Jan 15, 2020

DeepthiNeeladri commented Jan 12, 2020 •

edited

Loading

DeepthiNeeladri commented Jan 14, 2020 •

edited

Loading

bretg commented Jan 14, 2020 •

edited

Loading

DeepthiNeeladri commented Jan 15, 2020 •

edited

Loading