Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate user sync #4241

Merged
merged 6 commits into from
Dec 3, 2019
Merged

Deprecate user sync #4241

merged 6 commits into from
Dec 3, 2019

Conversation

Fawke
Copy link
Contributor

@Fawke Fawke commented Sep 27, 2019

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

enabledBidders, iframeEnabled & pixedEnabled properties have been deprecated. The unit test cases have been updated to reflect that.

@stale
Copy link

stale bot commented Oct 17, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 17, 2019
@jsnellbaker jsnellbaker added pinned won't be closed by stalebot and removed stale labels Oct 17, 2019
@Fawke Fawke requested review from mkendall07 and jaiminpanchal27 and removed request for mkendall07 November 4, 2019 14:53
@jsnellbaker jsnellbaker added the needs 2nd review Core module updates require two approvals from the core team label Nov 8, 2019
jaiminpanchal27
jaiminpanchal27 requested changes Nov 11, 2019
View reviewed changes
Copy link
Collaborator

@jaiminpanchal27 jaiminpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Please remove breakpoint

test/spec/userSync_spec.js Outdated
@@ -250,6 +265,7 @@ describe('user sync', function () {

it('should throw a warning and default to basic resgistration rules when filterSettings config is invalid', function () {
// invalid config - passed invalid filter option
debugger; // eslint-disable-line
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this breakpoint

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking that, I've removed it now.

robertrmartinez
robertrmartinez reviewed Nov 26, 2019
View reviewed changes
src/userSync.js
@@ -31,7 +36,7 @@ export function newUserSync(userSyncDependencies) {

// for now - default both to false in case filterSettings config is absent/misconfigured
let permittedPixels = {
image: false,
image: true,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not mentioned in the PR,

Are we defaulting to enabling image pixels now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Yes, userSync feature had image pixels enabled by default, prior to this change. Reason for this change here is that, we removed certain deprecated fields, as a result, we lost that default setting. We're setting this value to true now to maintain the default setting.

robertrmartinez
robertrmartinez approved these changes Dec 2, 2019
View reviewed changes
Copy link
Collaborator

@robertrmartinez robertrmartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks!

@Fawke Fawke merged commit f561c71 into prebid-3.0 Dec 3, 2019
@jsnellbaker jsnellbaker mentioned this pull request Dec 11, 2019
Merged
1 task
jsnellbaker added a commit that referenced this pull request Dec 11, 2019
@jsnellbaker
Prebid 3.0 (#4580)
2cd8607 
* Remove pbs depracated legacy url (#4226)

* remove deprecated legacy url from pbs adapter

* fix eslint errors

* add and update tests for openRtb2 endpoint

* sync with master

* Revert "sync with master"

This reverts commit 8c2b196.

* removed targeting set filter and moved where render status is set to work with safeframe creatives (#4236)

* Depracate adloader loadscript fn (#4228)

* test commit

* add callback support to loadExternalScript()

* pass moduleCode for renderers

* test cases for loadExternalScript()

* store callbacks for cached url

* fully remove adloader()

* call callback() from stub

* remove and update function name

* getHighestCpmBids only returns non-rendered bids (#4247)

* Make all adapters https (#4294)

* update all adapters to https

* convert all adapters to https

* update unit tests

* remove files confilicting with other PR

* Removed pub common and unified id submodules as defaults in user id module (#4445)

* Deprecate user sync (#4241)

* deprecate some properties of userSync object

* change bid adapter to Appnexus

* fix 3 failing test cases

* make all unit test cases pass

* remove debugger

* deprecate support for adUnit.sizes for pubs (#4458)

* deprecate support for adUnit.sizes for pubs

* remove commented code

* Deprecations utils.js (#4249)

* deprecate domain/referer type functions

* delete modules that are using deprecated methods from utils.js

* remove reference to getTopWindowLocation

* sync with prebid-3.0 branch

* remove test suite for getTopWindowLocation

* add back md files of all deleted adapters

* add md files of deleted analytics adapters

* add adapters that are 3.0 compliant

* add back the rubicon skipped test

* remove min field from priceGranularity feature (#4574)
bretg pushed a commit that referenced this pull request Jan 15, 2020
@DeepthiNeeladri @sumit116
@Fawke @coryhammon1 @jsnellbaker @bretg
Sync pixel change onevideo adaptor (#4718)
d40ca16 
* outstream changes

* removing global filtet

* reverting page

* message

* adapter change

* remove space

* testcases

* testpage

* spaces for test page

* renderer exist case

* reverting package-lock.json

* adding schain object

* adding tagid

* syntaxx error fix

* video.html

* space trailing

* space

* tagid

* inventoryId and placement

* rewarded video

* added unit test case

* Remove pbs depracated legacy url (#4226)

* remove deprecated legacy url from pbs adapter

* fix eslint errors

* add and update tests for openRtb2 endpoint

* sync with master

* Revert "sync with master"

This reverts commit 8c2b196.

* removed targeting set filter and moved where render status is set to work with safeframe creatives (#4236)

* Depracate adloader loadscript fn (#4228)

* test commit

* add callback support to loadExternalScript()

* pass moduleCode for renderers

* test cases for loadExternalScript()

* store callbacks for cached url

* fully remove adloader()

* call callback() from stub

* remove and update function name

* getHighestCpmBids only returns non-rendered bids (#4247)

* Make all adapters https (#4294)

* update all adapters to https

* convert all adapters to https

* update unit tests

* remove files confilicting with other PR

* Removed pub common and unified id submodules as defaults in user id module (#4445)

* Deprecate user sync (#4241)

* deprecate some properties of userSync object

* change bid adapter to Appnexus

* fix 3 failing test cases

* make all unit test cases pass

* remove debugger

* deprecate support for adUnit.sizes for pubs (#4458)

* deprecate support for adUnit.sizes for pubs

* remove commented code

* ccpa cahnges

* ccpa change

* test page

* test page change

* test page change 2

* change the variable

* Deprecations utils.js (#4249)

* deprecate domain/referer type functions

* delete modules that are using deprecated methods from utils.js

* remove reference to getTopWindowLocation

* sync with prebid-3.0 branch

* remove test suite for getTopWindowLocation

* add back md files of all deleted adapters

* add md files of deleted analytics adapters

* add adapters that are 3.0 compliant

* add back the rubicon skipped test

* remove min field from priceGranularity feature (#4574)

* ccpa support for v3.0

* Update oneVideoBidAdapter_spec.js

* Update oneVideoBidAdapter.js

* sync pixel chnge

* fix

* sync

* fix

* sync

* sync

* adding gdpr

* test cases

Co-authored-by: sumit sharma <sharmasumit116@gmail.com>
Co-authored-by: Neelanjan Sen <14229985+Fawke@users.noreply.github.com>
Co-authored-by: r-schweitzer <50628828+r-schweitzer@users.noreply.github.com>
Co-authored-by: coryhammon1 <coryhammon1@gmail.com>
Co-authored-by: jsnellbaker <31102355+jsnellbaker@users.noreply.github.com>
bretg pushed a commit that referenced this pull request Jan 16, 2020
@DeepthiNeeladri @sumit116
@Fawke @coryhammon1 @jsnellbaker @bretg
Sync pixel redirect fix and Test cases (#4741)
15204c5 
* outstream changes

* removing global filtet

* reverting page

* message

* adapter change

* remove space

* testcases

* testpage

* spaces for test page

* renderer exist case

* reverting package-lock.json

* adding schain object

* adding tagid

* syntaxx error fix

* video.html

* space trailing

* space

* tagid

* inventoryId and placement

* rewarded video

* added unit test case

* Remove pbs depracated legacy url (#4226)

* remove deprecated legacy url from pbs adapter

* fix eslint errors

* add and update tests for openRtb2 endpoint

* sync with master

* Revert "sync with master"

This reverts commit 8c2b196.

* removed targeting set filter and moved where render status is set to work with safeframe creatives (#4236)

* Depracate adloader loadscript fn (#4228)

* test commit

* add callback support to loadExternalScript()

* pass moduleCode for renderers

* test cases for loadExternalScript()

* store callbacks for cached url

* fully remove adloader()

* call callback() from stub

* remove and update function name

* getHighestCpmBids only returns non-rendered bids (#4247)

* Make all adapters https (#4294)

* update all adapters to https

* convert all adapters to https

* update unit tests

* remove files confilicting with other PR

* Removed pub common and unified id submodules as defaults in user id module (#4445)

* Deprecate user sync (#4241)

* deprecate some properties of userSync object

* change bid adapter to Appnexus

* fix 3 failing test cases

* make all unit test cases pass

* remove debugger

* deprecate support for adUnit.sizes for pubs (#4458)

* deprecate support for adUnit.sizes for pubs

* remove commented code

* ccpa cahnges

* ccpa change

* test page

* test page change

* test page change 2

* change the variable

* Deprecations utils.js (#4249)

* deprecate domain/referer type functions

* delete modules that are using deprecated methods from utils.js

* remove reference to getTopWindowLocation

* sync with prebid-3.0 branch

* remove test suite for getTopWindowLocation

* add back md files of all deleted adapters

* add md files of deleted analytics adapters

* add adapters that are 3.0 compliant

* add back the rubicon skipped test

* remove min field from priceGranularity feature (#4574)

* ccpa support for v3.0

* Update oneVideoBidAdapter_spec.js

* Update oneVideoBidAdapter.js

* sync pixel chnge

* fix

* sync

* fix

* sync

* sync

* adding gdpr

* test cases

* test cases

* test case

Co-authored-by: sumit sharma <sharmasumit116@gmail.com>
Co-authored-by: Neelanjan Sen <14229985+Fawke@users.noreply.github.com>
Co-authored-by: r-schweitzer <50628828+r-schweitzer@users.noreply.github.com>
Co-authored-by: coryhammon1 <coryhammon1@gmail.com>
Co-authored-by: jsnellbaker <31102355+jsnellbaker@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsnellbaker jsnellbaker jsnellbaker approved these changes

@robertrmartinez robertrmartinez robertrmartinez approved these changes

@jaiminpanchal27 jaiminpanchal27 jaiminpanchal27 approved these changes

Assignees

@robertrmartinez robertrmartinez

Labels
needs 2nd review Core module updates require two approvals from the core team pinned won't be closed by stalebot Prebid 3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Fawke @jaiminpanchal27 @robertrmartinez @jsnellbaker