Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onevideo adapter version param support #4826

Merged
merged 38 commits into from
Feb 7, 2020

Conversation

DeepthiNeeladri
Copy link
Contributor

@DeepthiNeeladri DeepthiNeeladri commented Feb 6, 2020

Type of change

  • [ X] Other

Description of change

version param support for onevideo Adapter

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@mike-chowla mike-chowla self-requested a review February 7, 2020 22:29
@mike-chowla mike-chowla self-assigned this Feb 7, 2020
Copy link
Contributor

@mike-chowla mike-chowla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mike-chowla mike-chowla merged commit 659b23c into prebid:master Feb 7, 2020
@bretg
Copy link
Collaborator

bretg commented Feb 13, 2020

Didn't see a docs PR with this. Please consider whether https://github.com/prebid/prebid.github.io/blob/master/dev-docs/bidders/oneVideo.md needs to be updated.

@DeepthiNeeladri DeepthiNeeladri deleted the OnevideoAdptor_version branch January 17, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants