Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onevideo adapter version param support #4826

Merged
merged 38 commits into from
Feb 7, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
62516db
outstream changes
Jun 27, 2019
05e333a
removing global filtet
Jun 27, 2019
054b515
reverting page
Jun 27, 2019
94cbc2d
message
Jul 2, 2019
d49e922
adapter change
Jul 3, 2019
7a43143
remove space
Jul 3, 2019
bc859b3
testcases
Jul 3, 2019
0a8a86c
testpage
Jul 3, 2019
22e4ec9
spaces for test page
Jul 3, 2019
9637b48
renderer exist case
Jul 4, 2019
0e2d31b
reverting package-lock.json
Jul 9, 2019
88ac283
Merge branch 'master' of https://github.com/prebid/Prebid.js
Jul 11, 2019
d81769b
Merge branch 'master' of https://github.com/prebid/Prebid.js
Jul 24, 2019
2d48e1e
Merge branch 'master' of https://github.com/prebid/Prebid.js
Aug 1, 2019
63a37e3
adding schain object
Aug 2, 2019
873a2c1
Merge branch 'master' of https://github.com/prebid/Prebid.js
Aug 4, 2019
7e68c35
Merge branch 'master' of https://github.com/prebid/Prebid.js
Aug 7, 2019
e8c40c3
adding tagid
Aug 7, 2019
af32e45
syntaxx error fix
Aug 7, 2019
4bb7c45
video.html
Aug 7, 2019
caf81ac
space trailing
Aug 7, 2019
514f68d
space
Aug 7, 2019
5dc1086
tagid
Aug 7, 2019
606eb96
inventoryId and placement
Aug 14, 2019
4cfb6f4
rewarded video
Sep 3, 2019
e03ff33
added unit test case
Sep 5, 2019
a17b3d3
merge
Nov 14, 2019
31bd686
Merge branch 'master' of https://github.com/prebid/Prebid.js
Dec 2, 2019
187b7af
Merge branch 'master' of https://github.com/prebid/Prebid.js
Dec 11, 2019
918cc48
Merge branch 'master' of https://github.com/prebid/Prebid.js
Dec 19, 2019
1cdef6d
comment
Dec 19, 2019
360009b
Merge branch 'master' of https://github.com/prebid/Prebid.js
Jan 7, 2020
57b2089
Merge branch 'master' of https://github.com/prebid/Prebid.js
Jan 10, 2020
b7bfbd0
Merge branch 'master' of https://github.com/prebid/Prebid.js
Jan 11, 2020
bde4e23
Merge remote-tracking branch 'upstream/master'
Jan 30, 2020
fba90d5
adding version params
Feb 5, 2020
f290dff
test cases for version
Feb 6, 2020
d184329
removing console log
Feb 6, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions modules/oneVideoBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import {registerBidder} from '../src/adapters/bidderFactory';
const BIDDER_CODE = 'oneVideo';
export const spec = {
code: 'oneVideo',
VERSION: '3.0.0',
ENDPOINT: 'https://ads.adaptv.advertising.com/rtb/openrtb?ext_id=',
SYNC_ENDPOINT1: 'https://cm.g.doubleclick.net/pixel?google_nid=adaptv_dbm&google_cm&google_sc',
SYNC_ENDPOINT2: 'https://pr-bh.ybp.yahoo.com/sync/adaptv_ortb/{combo_uid}',
Expand Down Expand Up @@ -153,6 +154,8 @@ function getRequestData(bid, consentData, bidRequest) {
bidfloor: bid.params.bidfloor,
ext: {
hb: 1,
prebidver: '$prebid.version$',
adapterver: spec.VERSION,
}
}],
site: {
Expand Down Expand Up @@ -244,6 +247,7 @@ function getRequestData(bid, consentData, bidRequest) {
}
};
}
// ccpa support
if (bidRequest && bidRequest.uspConsent) {
bidData.regs.ext.us_privacy = bidRequest.uspConsent
}
Expand Down
3 changes: 3 additions & 0 deletions test/spec/modules/oneVideoBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -136,12 +136,15 @@ describe('OneVideoBidAdapter', function () {
const placement = bidRequest.params.video.placement;
const rewarded = bidRequest.params.video.rewarded;
const inventoryid = bidRequest.params.video.inventoryid;
const VERSION = '3.0.0';
expect(data.imp[0].video.w).to.equal(width);
expect(data.imp[0].video.h).to.equal(height);
expect(data.imp[0].bidfloor).to.equal(bidRequest.params.bidfloor);
expect(data.imp[0].ext.rewarded).to.equal(rewarded);
expect(data.imp[0].video.placement).to.equal(placement);
expect(data.imp[0].ext.inventoryid).to.equal(inventoryid);
expect(data.imp[0].ext.prebidver).to.equal('$prebid.version$');
expect(data.imp[0].ext.adapterver).to.equal(VERSION);
});

it('must parse bid size from a nested array', function () {
Expand Down