Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use all request id #4849

Merged
merged 1 commit into from
Feb 19, 2020
Merged

use all request id #4849

merged 1 commit into from
Feb 19, 2020

Conversation

vincentproxistore
Copy link
Contributor

@vincentproxistore vincentproxistore commented Feb 12, 2020 •
edited
Loading

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Use all request ID.
I had a problem with my previous pull request so i've created this new one.
#4818

@jsnellbaker jsnellbaker mentioned this pull request Feb 13, 2020
Closed
9 tasks
@jsnellbaker jsnellbaker requested a review from sumit116 February 13, 2020 14:37
sumit116
sumit116 approved these changes Feb 19, 2020
View reviewed changes
Copy link
Contributor

@sumit116 sumit116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sumit116 sumit116 merged commit a76a84d into prebid:master Feb 19, 2020
hellsingblack pushed a commit to SublimeSkinz/Prebid.js that referenced this pull request Mar 5, 2020
@vincentproxistore @hellsingblack
use all request id (prebid#4849)
ac1cdc9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumit116 sumit116 sumit116 approved these changes

Assignees

@sumit116 sumit116

Labels
LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vincentproxistore @sumit116 @jsnellbaker