new bidder & analytics adapter: Concert

[walia]

Type of change

• New bidder and analytics adapter

Description of change

• test parameters for validating bids

  var adUnits = [
    {
      code: 'desktop_leaderboard_variable',
      mediaTypes: {
        banner: {
          sizes: [[1030, 590]]
        }
      }
      bids: [
        {
          bidder: "concert",
          params: {
            partnerId: 'test_partner'
          }
        }
      ]
    }
  ];
}

Be sure to test the integration with your adserver using the Hello World sample page.

• support@concert.io
• official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

• A link to a PR on the docs repo at New Adapter: Concert prebid.github.io#2033

Other information

[lgtm-com]

This pull request introduces 1 alert when merging 5c50b8d into 02d5b67 - view on LGTM.com

new alerts:

• 1 for Useless conditional

[harpere]

@walia some of your tests are failing. See the circle CI link above.

[walia]

@harpere Is there way to debug this test locally since its an IE 11 issue? I was not able to get this error when running the unit tests with gulp test.

[robertrmartinez]

@walia There is a lint error in your PR.

Please fix.

@afewcc can you please give this a review when you get a chance?

[harpere]

still have failed tests @walia

[bsheldon]

@harpere thanks for taking a look here, please advise on relevant IE test question above from comment @walia left, when able.

[gglas]

@msm0504 reassigned to you - please have a look when you get a chance!

[msm0504]

Code all looks good.

Only thing I noticed was the given sample params didn't return data. And please fix that 1 test in IE, as well.

[msm0504]

Can this be a partnerId that will return data? When I used these params in a test page, I got this response:

{"bids":[],"debug":{}}

Also, all responses from your endpoint should be compressed (such as gzip, compress, deflate)

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.