-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New bidder & analytics adapter: Concert (attempt #2) #5623
Merged
msm0504
merged 17 commits into
prebid:master
from
voxmedia:concert-adapter-submit-for-review
Aug 20, 2020
Merged
New bidder & analytics adapter: Concert (attempt #2) #5623
msm0504
merged 17 commits into
prebid:master
from
voxmedia:concert-adapter-submit-for-review
Aug 20, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Concert bid adapter
Use US Privacy string to determine if we can send PPID
This reverts commit 829ad84.
@msm0504 re-opened this PR to add the
|
msm0504
approved these changes
Aug 20, 2020
BrightMountainMediaInc
pushed a commit
to BrightMountainMediaInc/Prebid.js
that referenced
this pull request
Sep 14, 2020
* Add concert bid adapter, doc and tests. * Add analytics adapter * Add email * fix alert from lgtm * try to fix test for ie 11 * Handle USP string for PPID * Fix linking error * Debug: Find out why IE11 is failing * More debugging * More debugging * Attempt to store queue in-prototype * Revert "Attempt to store queue in-prototype" This reverts commit 829ad84. * More debugging * More debugging * Remove Array.includes to support IE11 Co-authored-by: Messay Bekele <messay.bekele@voxmedia.com> Co-authored-by: Messay Bekele <walia@users.noreply.github.com> Co-authored-by: Andrew Amato <andrew.amato@voxmedia.com>
BrightMountainMediaInc
pushed a commit
to BrightMountainMediaInc/Prebid.js
that referenced
this pull request
Sep 14, 2020
…rebid#5623)" This reverts commit 39d4697.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(resubmit of #5338)
Type of change
Description of change
This PR adds the Concert bid adapter and analytics adapter to Prebid.
Other information
WIP until we can fix IE11 tests and update params