Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New bidder & analytics adapter: Concert (attempt #2) #5623

Merged
merged 17 commits into from
Aug 20, 2020

Conversation

jplhomer
Copy link
Contributor

@jplhomer jplhomer commented Aug 18, 2020

(resubmit of #5338)

Type of change

  • New bidder and analytics adapter

Description of change

This PR adds the Concert bid adapter and analytics adapter to Prebid.

  • test parameters for validating bids
  var adUnits = [
    {
      code: 'desktop_leaderboard_variable',
      mediaTypes: {
        banner: {
          sizes: [[1030, 590]]
        }
      }
      bids: [
        {
          bidder: "concert",
          params: {
            partnerId: 'test_partner'
          }
        }
      ]
    }
  ];
}
  • contact email of the adapter’s maintainer: support@concert.io
  • official adapter submission

Other information

  • WIP until we can fix IE11 tests and update params

@jplhomer jplhomer marked this pull request as ready for review August 18, 2020 19:36
@jplhomer
Copy link
Contributor Author

@msm0504 re-opened this PR to add the concert bidder and analytics adapter!

  • Addressed your concerns about gzipping 👍
  • Our server should now be returning bids for the test_partner parameters provided in the description
  • The IE11 error is fixed - though CircleCI failed on an unrelated adapter timeout - and I can't trigger a re-run manually.

@msm0504 msm0504 merged commit b4c6b47 into prebid:master Aug 20, 2020
BrightMountainMediaInc pushed a commit to BrightMountainMediaInc/Prebid.js that referenced this pull request Sep 14, 2020
* Add concert bid adapter, doc and tests.

* Add analytics adapter

* Add email

* fix alert from lgtm

* try to fix test for ie 11

* Handle USP string for PPID

* Fix linking error

* Debug: Find out why IE11 is failing

* More debugging

* More debugging

* Attempt to store queue in-prototype

* Revert "Attempt to store queue in-prototype"

This reverts commit 829ad84.

* More debugging

* More debugging

* Remove Array.includes to support IE11

Co-authored-by: Messay Bekele <messay.bekele@voxmedia.com>
Co-authored-by: Messay Bekele <walia@users.noreply.github.com>
Co-authored-by: Andrew Amato <andrew.amato@voxmedia.com>
BrightMountainMediaInc added a commit to BrightMountainMediaInc/Prebid.js that referenced this pull request Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants