Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aol (ADTECH) integration #55

Merged
merged 9 commits into from
Nov 2, 2015
Merged

aol (ADTECH) integration #55

merged 9 commits into from
Nov 2, 2015

Conversation

nickjacob
Copy link
Collaborator

re: #4

  • user will prbly need to work closely with their AR if they'd want to do multiple bids/unit, right now this assumes that an AOL placement : bid
  • quirk: AOL expects the bids to be requested after the slots are defined, and will try to document.write() if they aren't, that's why _dummyUnit

@nickjacob nickjacob force-pushed the aol-adapter branch 2 times, most recently from d6f31d2 to 43b9a47 Compare October 7, 2015 17:24
@nickjacob nickjacob mentioned this pull request Oct 7, 2015
Closed
@ikhemissi
Copy link
Contributor

Hi Nick,

Sorry, I didn't see that you have already created a pull-request and went creating an other one for AOL integration /pull/67.

@mkendall07
Copy link
Member

@nickjacob, @ikhemissi,

I just tested this branch and it's working correctly. Thank you both for contributing. I'll merge this branch and close the other AOL PR.

mkendall07 added a commit that referenced this pull request Nov 2, 2015
@mkendall07
Merge pull request #55 from prebid/aol-adapter
08c1e98 
aol (ADTECH) integration
@mkendall07 mkendall07 merged commit 08c1e98 into master Nov 2, 2015
@mkendall07 mkendall07 mentioned this pull request Nov 2, 2015
Closed
@mkendall07 mkendall07 deleted the aol-adapter branch November 6, 2015 19:16
mp-12301 pushed a commit to aol/Prebid.js that referenced this pull request Apr 10, 2017
Merge pull request prebid#55 in AOLP_ADS_JS/prebid.js from feature/Pr…
4f6762b 
…ebid-0.15.2 to release/1.8.0

* commit '3c3d298eb248a7f69dd4ae86f3f6341f2c04b1b5': (36 commits)
  CHANGELOG
  Add new adapters for AOL analytics.
  Prebid 0.15.2 Release
  Fix issue with building prebid from npm install. Babel loader was being skipped because of the project residing in /node_modules/ directory. (prebid#820)
  Increment pre version
  Prebid 0.15.1 Release
  Update bidFloor->bidfloor to match other bidders + updated conversant docs (prebid#818)
  Correct 'bidloor' typo in Conversant adapter (prebid#815)
  Increment pre version
  0.15.0 release
  support IE userLanguage Navigator property (prebid#807)
  exclude node_modules from babel-loader as to prevent strict mode errors (prebid#806)
  PulsePoint Adapter - Support for additional parameters. (prebid#784)
  Fix 'skippable' targeting typo (prebid#804)
  Adding adKernel adapter (prebid#739)
  Babel plugin fixes to make the generated code syntax valid in ie8 (prebid#799)
  Vertoz Adapter (prebid#789)
  RubiconLite is now just Rubicon and "rubicon" aliases "rubiconLite" (prebid#783)
  add version to global namespace (prebid#794)
  Adform adapter tests fixed prebid#769 (prebid#793)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickjacob @ikhemissi @mkendall07