Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support IE userLanguage Navigator property #807

Merged
merged 2 commits into from
Nov 16, 2016

Conversation

protonate
Copy link
Collaborator

Type of change

  • Bugfix

Description of change

IE does not support Navigator.language so add a check for this and support Navigator.userLanguage in case of IE.

@protonate
Copy link
Collaborator Author

@matthewlane @mkendall07 for review

Copy link
Collaborator

@matthewlane matthewlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@protonate protonate merged commit 232b0ca into master Nov 16, 2016
@protonate protonate deleted the bugfix/conversant-navigator-language branch November 17, 2016 22:51
mp-12301 pushed a commit to aol/Prebid.js that referenced this pull request Apr 10, 2017
…ebid-0.15.2 to release/1.8.0

* commit '3c3d298eb248a7f69dd4ae86f3f6341f2c04b1b5': (36 commits)
  CHANGELOG
  Add new adapters for AOL analytics.
  Prebid 0.15.2 Release
  Fix issue with building prebid from npm install. Babel loader was being skipped because of the project residing in /node_modules/ directory. (prebid#820)
  Increment pre version
  Prebid 0.15.1 Release
  Update bidFloor->bidfloor to match other bidders + updated conversant docs (prebid#818)
  Correct 'bidloor' typo in Conversant adapter (prebid#815)
  Increment pre version
  0.15.0 release
  support IE userLanguage Navigator property (prebid#807)
  exclude node_modules from babel-loader as to prevent strict mode errors (prebid#806)
  PulsePoint Adapter - Support for additional parameters. (prebid#784)
  Fix 'skippable' targeting typo (prebid#804)
  Adding adKernel adapter (prebid#739)
  Babel plugin fixes to make the generated code syntax valid in ie8 (prebid#799)
  Vertoz Adapter (prebid#789)
  RubiconLite is now just Rubicon and "rubicon" aliases "rubiconLite" (prebid#783)
  add version to global namespace (prebid#794)
  Adform adapter tests fixed prebid#769 (prebid#793)
  ...
mp-12301 pushed a commit to aol/Prebid.js that referenced this pull request Apr 10, 2017
…8.0 to master

* commit '997aa5bce17aafd6b215d335551e89757f92bf3e': (37 commits)
  CHANGELOG.
  CHANGELOG
  Add new adapters for AOL analytics.
  Prebid 0.15.2 Release
  Fix issue with building prebid from npm install. Babel loader was being skipped because of the project residing in /node_modules/ directory. (prebid#820)
  Increment pre version
  Prebid 0.15.1 Release
  Update bidFloor->bidfloor to match other bidders + updated conversant docs (prebid#818)
  Correct 'bidloor' typo in Conversant adapter (prebid#815)
  Increment pre version
  0.15.0 release
  support IE userLanguage Navigator property (prebid#807)
  exclude node_modules from babel-loader as to prevent strict mode errors (prebid#806)
  PulsePoint Adapter - Support for additional parameters. (prebid#784)
  Fix 'skippable' targeting typo (prebid#804)
  Adding adKernel adapter (prebid#739)
  Babel plugin fixes to make the generated code syntax valid in ie8 (prebid#799)
  Vertoz Adapter (prebid#789)
  RubiconLite is now just Rubicon and "rubicon" aliases "rubiconLite" (prebid#783)
  add version to global namespace (prebid#794)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants