add quantcast ID submodule #5727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mckurt
commented
Sep 10, 2020
| mediaTypes: { | ||
| banner: {} | ||
| banner: { | ||
| sizes: [[300,250],[300,600],[728,90]] |
There was a problem hiding this comment.
I noticed that a recent PR tackled the same issue (#5606), but I was still getting errors if the sizes aren't defined inside the banner object. I can move this to a different PR if that'd be better.
smenzer
requested changes
Sep 11, 2020
jlukas79
reviewed
Sep 11, 2020
|
Here is the documentation PR: prebid/prebid.github.io#2339 I also updated the description. |
jlukas79
approved these changes
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This adds quantcast user ID submodule. The submodule reads Quantcast first party cookie and passes the value to prebid bidding adapters. Currently, the submodule doesn't need any configuration parameters. The code is tested using with unit tests and userId_example.html. The code coverage on the submodule is 85.71%. Please contact asig@quantcast.com for any issues.
Link to the documentation PR: prebid/prebid.github.io#2339