Not using utils.isEmpty on non objects #6036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Also updated certain param names used in the test spec.
…g the CircleCI tests to fail.
…'t always have the crid, so using a sentinel value when we don't have the crid.
- Removed the package-lock file.
# Conflicts: # package-lock.json
…diaTypes.video.playerSize instead of bid.sizes. prebid#3331
- updated the test spec to reflect the above change - removed changes to the package-lock.json file.
# Conflicts: # modules/telariaBidAdapter.js
# Conflicts: # modules/telariaBidAdapter.js Added GDPR support
Merging with master
Merged the fork with the latest master
- Added an example URL.
Merging the telaria prebid fork to master
… timeout. - Added the ability to serialize an schain object according to the description provided here: https://github.com/InteractiveAdvertisingBureau/openrtb/blob/master/supplychainobject.md
added 10 commits
August 30, 2019 14:53
Merging with master
…to checking if params has it if not.
aleksatr
reviewed
Dec 2, 2020
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Not using
utils.isEmptyfor emptiness checks on primitives.#5958