Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not using utils.isEmpty on non objects #6036

Merged
merged 41 commits into from
Dec 4, 2020
Merged

Not using utils.isEmpty on non objects #6036

Changes from 40 commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
5dcf4b5
Added telaria bid adapter
tremorvideo Aug 1, 2018
0a19ea2
more documentation
tremorvideo Aug 1, 2018
e1d19e4
Added more test cases. And improved some code in the adapter
tremorvideo Aug 1, 2018
0863824
Removed the check for optional params, they are handled in the server…
tremorvideo Aug 1, 2018
cb0973a
added some spaces to fix CircleCI tests
tremorvideo Aug 1, 2018
836779c
added some spaces to fix CircleCI tests
tremorvideo Aug 1, 2018
850c4f4
fixed code indentation in /spec/AnalyticsAdapter_spec.js which causin…
tremorvideo Aug 1, 2018
ad01373
Reverted the changes
tremorvideo Aug 1, 2018
df23a42
merged with prebid master.
tremorvideo Aug 1, 2018
de868c1
merged with prebid master.
tremorvideo Aug 1, 2018
dd996a9
creative Id is required when we build a response but our server doesn…
tremorvideo Aug 1, 2018
7ef41b9
- removed an un used method
tremorvideo Aug 3, 2018
d7b95e6
Merge https://github.com/prebid/Prebid.js
tremorvideo Aug 3, 2018
58cc7ce
Merge branch 'master' of https://github.com/prebid/Prebid.js
Dec 12, 2018
81ec17a
merging to master
Dec 12, 2018
cebc764
updated telaria bid adapter to use player size provided by the bid.me…
Dec 13, 2018
7d617a7
- removed the requirement for having player size
Dec 14, 2018
012a77b
added a param to the ad call url to let us know that the request is c…
Dec 18, 2018
178c072
to lower casing the bidder code.
Dec 19, 2018
fb10552
Merge branch 'master' of https://github.com/prebid/Prebid.js
Apr 1, 2019
7c6f20c
Merge branch 'master' of https://github.com/prebid/Prebid.js
Apr 1, 2019
32831bf
Sending the gdpr & gdpr consent string only if they're defined
Apr 2, 2019
a9607be
Merge branch 'master' of https://github.com/prebid/Prebid.js
May 6, 2019
3b3e433
Merge branch 'master' of https://github.com/prebid/Prebid.js
May 21, 2019
95f6d98
- Updated the test ad unit to use 'telaria' as the bidder code.
May 21, 2019
5385ca0
using the bidder code constant
May 23, 2019
787a6ff
Merge branch 'master' of https://github.com/prebid/Prebid.js
Aug 28, 2019
6f2cb7d
- Implemented the 'onTimeout' callback to fire a pixel when there's a…
Aug 29, 2019
b64b614
some mods to the schain tag generation
Aug 29, 2019
fa420db
- added tests for schain param checking.
Aug 30, 2019
4d8f45d
- fixed a malformed url for timeouts
Aug 30, 2019
834945d
- Removed a trailing ',' while generating a schain param.
Aug 30, 2019
9fd494e
Merge branch 'master' of https://github.com/prebid/Prebid.js
Sep 3, 2019
969e275
- Using the schain object from validBidRequest if present. Reverting …
Sep 3, 2019
991fb84
- reverting changes to merge with master
Sep 3, 2019
a9ff4f8
resolving merge conflicts
Sep 3, 2019
f744560
- Resolving merge issues
Sep 3, 2019
453e260
Merge branch 'master' of https://github.com/prebid/Prebid.js
Nov 25, 2020
ad8cbf9
- some formatting changes
Nov 26, 2020
b88df21
using val !== '' instead of utils.isEmpty(val)
Nov 26, 2020
95322bf
Checking for undefined in the getEncodedValIfNotEmpty method
Dec 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/telariaBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ function getDefaultSrcPageUrl() {
}

function getEncodedValIfNotEmpty(val) {
return !utils.isEmpty(val) ? encodeURIComponent(val) : '';
return (val !== '') ? encodeURIComponent(val) : '';
aleksatr marked this conversation as resolved.
Show resolved Hide resolved
}

/**
Expand Down