ParrableIdSystem: Store third-party cookie support status in first-party cookie #6741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PBID-91: Store third-party cookie support state in compound cookie and expire after ttl
…PBID-91_thirdPartyCookieSupport
…thub.com:Parrable/Prebid.js into parrableIdSystem/PBID-91_thirdPartyCookieSupport
|
@ChrisHuie it looks like the CircleCI 'build' workflow didn't kick off for this new PR either. Same issue as #6689 We recently setup our own BrowserStack and enabled CircleCI on our fork of Prebid so that we can do some testing before opening a PR here, upstream. This shouldn't have affected your build in any way. I'll try pushing another commit to the branch in this PR and see what happens. Our CircleCI Prebid.js project won't trigger on a commit to a branch that doesn't have a corresponding PR in our repo. |
|
@icflournoy Thanks for resubmitting! I think this sometimes happens if you are following your repo and not the main Prebid repo in CircleCi. I can kick off the tests manually from my end but looks like I don't have access to edit this commit. |
|
@ChrisHuie what do you need from me to get the commit building? I can add you as an outside collaborator on our Prebid.js fork, but that doesn't seem scalable. Especially if this issue is going to be present into the future, so long as we're running a Prebid.js build in our own CircleCI environment. |
|
@icflournoy yeah that works. I'm not sure if there is a way to check to let contributors make edits on a pr after it is already submitted? I personally haven't been able to reproduce this situation so not 100% sure how persistent it is. I will reach out to CircleCI to get a bit more context and see what ways there are to mitigate it in the future. |
|
@ChrisHuie I've added you with "Write" permissions to our Prebid.js fork https://github.com/Parrable/Prebid.js Let me know if you're able to kick off the tests manually for the If you're not already aware - GitHub Status Checks (applied on a per-branch level) can be used to enforce certain named status checks to pass on a branch before a PR can be merged. Example from on of our internal repos: Something to consider, if this behavior is not easily fixable from CircleCI's side. |
|
@icflournoy I will have to work on this for a vit. Looks like this is a unique situation since I couldn't even automatically kick off the circleci tests like I usually do :/ |
|
Reaching out to CircleCi to work with them on a solution for this pr and going forward how to make sure no pr has a way to slip through the tests. |
…PBID-91_thirdPartyCookieSupport
|
Yay for circleCi tests working now :) |
|
@icflournoy @ChrisHuie Circle CI tests are failing again. |
|
@ChrisHuie we fixed the problem with our tests, caused by an early expiring cookie. Fix is in the last commit. Can you please rebuild? Thanks! |
|
It looks like the build is now failing due to some timing on BrowserStack:
|
|
@icflournoy circle ci I think was experiencing outages when this was last ran. Just kicked off the tests again |
|
Thanks @ChrisHuie I see the CircleCI build ran! Friday was not a good day for CircleCI. I recently re-enabled our CircleCI build for our Prebid fork (around 9:30 this morning). Which, by past evidence, should have prevented your build from running. |
msm0504
approved these changes
May 24, 2021
|
@icflournoy it looks like the behavior isn't consistent on firefox 72.0 -> https://app.circleci.com/pipelines/github/prebid/Prebid.js/5921/workflows/33f4dd7d-1f09-4bfe-8a46-7abe45d9dddf/jobs/14605 Could you take a look when you get a chance 🙏 |
|
@icflournoy yeah there seems to be a decent amount of flakiness with this pr because now i have seen it fail on new chrome, edge, and old firefox. Can you please work on stabilizing this a bit so we don't have to revert it again. |
1 task
pm-shashank-jain
added a commit
to PubMatic-OpenWrap/Prebid.js
that referenced
this pull request
Jun 29, 2021
* display bidder in utils.logs and disable bidder config on auction end (#6683)
* add X-Prebid header to ajax requests fixes #6627 (#6676)
* Prebid Docs: Typo fix in README.md (#6704)
* Revert "add X-Prebid header to ajax requests fixes #6627 (#6676)" (#6702)
This reverts commit a887289546bdf830a3ff450a664627471eec9dfc.
* Criteo Bid Adapter: update contact email (#6701)
* Fixing flaky adapter unit tests (#6706)
* stub appendChild stuff
* use ie11 safe strIncludes
* update prebidManager to use storageManager
* use ie safe stuff
* going too fast ;P
* Floc Userid System: add new ID module (#6521)
* Zeta Bid Adapter: update to endpoint (#6697)
* adapter updates
* remove testing changes
* modify endpoint path
* address testing issues
* prebid 4.38.0 release
* 4.39.0-pre
* Adkernel Bid Adapter: converge digital alias (#6714)
* fix linting in gulpfile (#6694)
* eslint(standard/object-curly-even-spacing)
* eslint(space-before-blocks)
* eslint(no-multi-spaces)
* Admixer Bid Adapter: add meta key to response (#6674)
* Grid Bid Adapter: add support for advertiserDomains (#6716)
* Update gridBidAdapter.js
* Update gridBidAdapter_spec.js
* Update gridBidAdapter_spec.js
* Update gridBidAdapter_spec.js
* 33across bid adapter: Add adomain support (#6719)
* Fix typo in UID 2.0 doc (#6724)
* Bump url-parse from 1.4.7 to 1.5.0 (#6718)
Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.4.7 to 1.5.0.
- [Release notes](https://github.com/unshiftio/url-parse/releases)
- [Commits](https://github.com/unshiftio/url-parse/compare/1.4.7...1.5.0)
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* smartx Bid Adapter: bugfix renderer url (#6725)
* Bump handlebars from 4.7.6 to 4.7.7 (#6717)
Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.7.6 to 4.7.7.
- [Release notes](https://github.com/wycats/handlebars.js/releases)
- [Changelog](https://github.com/handlebars-lang/handlebars.js/blob/master/release-notes.md)
- [Commits](https://github.com/wycats/handlebars.js/compare/v4.7.6...v4.7.7)
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Tappx Bid Adapter: add floor module support (#6626)
* UPDATE: add initial UID
* UPDATE: UID change user ext
* UPDATE: UID clean logs
* UPDATE: add host info
* UPDATE: tappx bid adapter universal id
* UPDATE: fix bidder param
* UPDATE: tappxBidAdapter tests
* tappxBidAdapter - fix spacing
* tappxBidAdapter: add test user eids array
* tappxBidAdapter: update eids array
* FIX: package-lock.json
* Conversant adapter: add adomain, remove digitrust (#6495)
* Update eids.js
* Update eids_spec.js
* Update eids.js
* Update pubmaticBidAdapter_spec.js
* Update eids.js
* Update eids_spec.js
* Update conversantBidAdapter_spec.js
* Update rubiconBidAdapter_spec.js
* Update conversantBidAdapter_spec.js
* Delete test/spec/adapters directory
* Update userId_spec.js
* Update conversantBidAdapter.js
* Update conversantBidAdapter_spec.js
* Update conversantBidAdapter_spec.js
* Update conversantBidAdapter_spec.js
* Rads Bid Adapter: add GDPR support & user sync support (#6455)
* Proxistore Bid Adapter: add cookieless url endpoint & use floor module (#6427)
* use floor module
* call cookieless endpoint when necessary
* test endpoint url
* change url endpoint
* delete console log
* fix tests
* add language to url
* use ortb interface
* unit test
* update test unit
* create proxistore module
* add unit tests and documentation
* delete modules
* delete module
* add proxistore rtd submodule
* delete proxistore module
* spacing
* change url
* AdYoulike Bid Adapter: Add an "Insertion" tracking for Native mediatype (#6481)
* add insertion event
* add missing campaign ID parameter
* update unit test with new tracking checked
* Dspx Bid Adapter : add user sync support (#6456)
* Add sync support for dspx adapter
* Dspx Bid Adapter : add user sync support
Co-authored-by: Alexander <avj83@list.ru>
* Multibid Module: add new module to handle multiple bids from single bidder & update rubicon adapter (#6404)
* Multibid module - create new module
- Expands the number of key value pairs going to the ad server in the normal Prebid way by establishing the concept of a "dynamic alias"
First commit
* Continued updates from 1st commit
* Adding logWarn for filtered bids
* Update to include passing multibid configuration to PBS requests
* Update to rubicon bid adapter to pass query param rp_maxbids value taken from bidderRequest.bidLimit
* Update to config to look for camelcase property names according to spec. These convert to all lowercase when passed to PBS endpoint
* Adjust RP adapter to always include maxbids value - default is 1
* Added support for bidders array in multibid config
* Fixed floor comparison to be <= bid cpm as oppossed to just < bid cpm. Updated md file to fix camelCase tpyo
* Update to include originalBidderRequest in video call to prebid cache
* Update to ignore adpod bids from multibid and allow them to return as normal bids
* Adding uid2 to submodules.json (#6508)
* NextRoll ID System: add new ID module (#6396)
* Add Nextroll ID Module
* Add nextroll to eids
* Make configuration value names consistent with Adapter Module
* Use parnerId instead of sellerId
* Add nextroll to userId and eids md files
* Remove storage configuration
* Rename nextroll -> nextrollId
* Add nextrollId to common ID specs
* Qwarry Bid Adapter: add GDPR and consent string handling (#6489)
* qwarry bid adapter
* formatting fixes
* fix tests for qwarry
* qwarry bid adapter
* add header for qwarry bid adapter
* bid requests fix
* fix tests
* response fix
* fix tests for Qwarry bid adapter
* add pos parameter to qwarry bid adapter
* qwarryBidAdapter onBidWon hotfix
* Change bidder endpoint url for Qwarry adapter
* add referer JS detection
* use bidderRequest.refererInfo
* fix tests
* GDPR consent string support
* NPE fix
Co-authored-by: Artem Kostritsa <akostritsa@akostritsa.com>
Co-authored-by: Alexander Kascheev <akascheev@asteriosoft.com>
Co-authored-by: pro-nsk <32703851+pro-nsk@users.noreply.github.com>
* Zemanta Bid Adapter: add support for new params & consent strings to usersync URL (#6468)
* add gvl id to spec
* add support for bcat and badv params
* add consent strings to usersync url
* add bcat and badv params to doc
* Automatad Bid Adapter: Add meta.advertiserDomains to bid response (#6509)
* added bid meta with advertiserDomains
* Adhese Bid Adapter: add support for caching video content (#6501)
* adpod category support test
* Revert "adpod category support test"
This reverts commit 70a3cf2ad5db94757addd9e08c3a083caca282d0.
* adpod category support test
* Revert "adpod category support test"
This reverts commit 70a3cf2ad5db94757addd9e08c3a083caca282d0.
* Adhese Bid Adapter: cache video content
Co-authored-by: Tim Sturtewagen <tim@adhese.com>
Co-authored-by: Mateusz <mateusz@adhese.eu>
* update apacdex unit test to disable debug mode (#6511)
* Telaria: not setting adid (#6507)
* Prebid 4.33.0 Release
* increment pre version
* rubicon: removing maxduration as a required bidder parameter (#6513)
* Zemanta adapter: add advertiserDomains (#6517)
* Lemma Bid Adapter: accepting the floor to use the getFloor function (#6497)
* lemmaBidAdapter.js
Added lemma bid adapter file
* lemmaBidAdapter.md
Added lemma bid adapter md file
* lemmaBidAdapter_spec.js
Added lemma bid adapter test spec file
* Update lemmaBidAdapter.js
Fixed automated code review alert comparison between inconvertible types
* Update lemmaBidAdapter.js
Fixed review changes
* Update lemmaBidAdapter.md
Correct parameter value.
* Update lemmaBidAdapter.js
Lemma Bid Adapter - v3.0 compliance
* Update lemmaBidAdapter_spec.js
Lemma Bid Adapter - v3.0 compliance
* Update lemmaBidAdapter.md
Lemma Bid Adapter - v3.0 compliance
* Update lemmaBidAdapter.js
Added user sync support into bid adapter.
* updated include modules file extension.
updated include modules js file extension.
* Update lemmaBidAdapter_spec.js
Added unit test for user sync feature.
* Update lemmaBidAdapter.js
Fixed format error.
* Update lemmaBidAdapter_spec.js
Fixed format error and typo error.
* Set mediaType key value into bid object
Set mediaType key value into the bid object.
* Update lemmaBidAdapter.js
remove duplicate function
* Update lemmaBidAdapter.js
Remove non supported code.
* Update lemmaBidAdapter_spec.js
Remove GDPR test cases.
* Update lemmaBidAdapter.js
Made changes for accepting the floor to use the getFloor function
* Update lemmaBidAdapter.js
correct undefined keyword name.
* Update lemmaBidAdapter_spec.js
Added test coverage floor value
* Update lemmaBidAdapter.js
Remove trailing spaces on lines 379 and 381.
* Update lemmaBidAdapter_spec.js
Added getFloor function test case changes, Please review it.
* Update lemmaBidAdapter_spec.js
* Update lemmaBidAdapter.js
* Update lemmaBidAdapter.js
Fixed lint issue.
* Update lemmaBidAdapter_spec.js
Fixed test cases.
* Update lemmaBidAdapter_spec.js
Made suggested changes. Please review it.
Co-authored-by: Abhijit Mane <abhipucsd.123@gmail.com>
* Mediasquare Bid Adapter: fix getUserSyncs issue with empty bids + add metrics to onBidWon Event (#6480)
* Mediasquare bidder: fix getUserSyncs issue with empty bids + add metrics to onBidWon Event
* Mediasquare bidder: fix getUserSyncs issue with empty bids + add metrics to onBidWon Event
* removing status as it does not seem populated when called
* add tests
* Update nextroll ID variable name to match published ID module (#6519)
* Merkle User ID Module: updates to user id submodule (#6503)
* AdKernel Bid/Analytics Adapters: user privacy related changes (#6488)
* SynacorMedia: remove adId from the bid response (#6520)
* Rubicon: making doc data types consistent (#6526)
* Synacormedia Bid Adapter: add meta.advertiserDomains (#6527)
* Adloox Analytics Adapter: add new analytics adapter (#6308)
* gulp: fix supplying list of browsers to test against
The following now works: gulp test --browserstack --nolint --nolintfix --browsers=bs_ie_11_windows_10 --file 'test/spec/modules/adloox{AnalyticsAdapter,AdServerVideo,RtdProvider}_spec.js'
* instreamTracking: unit test tidy
From @robertrmartinez in https://github.com/prebid/Prebid.js/pull/6308#issuecomment-810537538
* adloaderStub: expose stub for other unit tests to use
From @robertrmartinez in https://github.com/prebid/Prebid.js/pull/6308#issuecomment-810537538
* Adloox analytic module
* Seedtag adapter: Fixing bug preventing to receive the right params onTimeout. (#6525)
* adot bid adapter: add publisher path from bidder config to endpoint url (#6476)
* Admixer ID System: add userId submodule (#6238)
* Migrating to Prebid 1.0
* Migrating to Prebid 1.0
* Fix spec
* add gdpr and usp
* remove changes in gdpr_hello_world.html
* Update gdpr_hello_world.html
add spaces
* add user syncs
* remove comments
* tests
* admixer id system
* admixer id system
* admixer id system eids.md userId.md
* admixer id system .submodules.json
* admixer id system
Co-authored-by: atkachov <atkachov91@admixer.ua>
* PBJS Core: call custom render func after loadscript if provided (#6422)
* Pubxai Analytics Adapter: bug fixes and code revamp (#6474)
* Updated PubxAiAnalytics adapter - Bug fixes and Code restructuring
* Updated endpoint URLs
* Changed array.includes to array.indexOf to fix IE issue
* Code cleanup and changes as suggested.
* Updated browser testing order and edge browser token
* PBJS Core: canBidderRegisterSync ignoring iframe sync disabled by default (#6535)
* Update eids.js
* Update eids_spec.js
* Update eids.js
* Update pubmaticBidAdapter_spec.js
* Update eids.js
* Update eids_spec.js
* Update conversantBidAdapter_spec.js
* Update rubiconBidAdapter_spec.js
* Update conversantBidAdapter_spec.js
* Delete test/spec/adapters directory
* Update userId_spec.js
* Update userSync.js
* Update userSync_spec.js
* Added automatic tzo and targetId to adserver request. (#6534)
* Impactify Bid Adapter: add new bid adapter (#6518)
* Add impactify adapter with MD file
* Add impactify adapter
* Prebid 4.34.0 Release
* Increment pre version
* Prebid server adapter: add config for openx hosting (#6530)
* Yieldmo adapter: add meta data to bids (#6550)
* Smartx Bid Adapter: Add meta.advertiserDomains support (#6547)
* Onevideo / Adap.tv Adapter: updated example configuration (#6546)
* Mass Deal Rendering Module: support multiple custom configs for dealId and rendering (#6500)
* ZetaSsp Bid Adapter: add new bid adapter (#6432)
* Adnuntius Bid Adapter: Fix for bid too low. (#6557)
* Added automatic tzo and targetId to adserver request.
* Fixing issues with bid price being too low.
* Fixing issues with bid price being too low.
* ReadPeak Bid Adapter: fix api issues, add gdpr consent, & getfloor module support (#6548)
* BetweenBidAdatper: added sharedid support (#6531)
* adWMG Bid Adapter: update endpoints for cookie sync (#6544)
* Support floorCPM parameter, fix some minor bugs
* fix space-in-parens circleci error
* example fix
* clean usersync URL
* spaces
* spaces
* add new unit tests, compatibility with IE11
* remove logInfo
* Check for floorCPM value
* Check params before sending
* New endpoints
* code format
* new endpoint for cookie sync
* update tests
Co-authored-by: Mikhail Dykun <m.dykun@wmgroup.us>
* Yieldmo Bid Adapter: add support for the floors module (#6541)
* Sortable Bid Adapter: add eids support (#6565)
* Add Sortable adapter for Prebid 3.x
Update tests to reflect changes.
* Add .js in imports
* hostname not host: don't include port
* Trivial change to trigger build: failure wasn't our adapter
* More failures in other adapters
* PR Feedback
- use https for URL
- fix examples in markdown
- request to endpoint should work now
* Feedback: add native and video examples
* Update unit tests
Co-authored-by: Shannon Broekhoven <shannon@sortable.com>
* Outbrain Bid Adapter: replacing Zemanta (#6558)
* Sirdata Real-time Data Module: add new RTD module (#6515)
* Logicad Bid Adapter: add support for userid modules (#6529)
* ATS-identityLinkIdSystem - add use3P config property to control firing of 3P envelope endpoint (#6568)
* Proxistore Bid Adapter: add support for tcf v2 consent (#6543)
* use tcf v2 consent
* set cosentGiven to false and test Gdpr api v2
* BlueBillyWig Bid Adapter: add renderer customization options (#6540)
* add Blue Billywig adapter
* Blue Billywig Adapter - update according to review feedback
* Blue Billywig Adapter - update to try and pass CircleCI
* Remove the last for .. of in bluebillywigBidAdapter.js, hopefully...
* Update bluebillywigBidAdapter test parameters to match renderer to rendererCode rename
* Blue Billywig - Also pass through site config with OpenRTB request
* add Blue Billywig adapter
* Blue Billywig Adapter - update according to review feedback
* Blue Billywig Adapter - update to try and pass CircleCI
* Remove the last for .. of in bluebillywigBidAdapter.js, hopefully...
* Code quality update, always hit user syncs, improved video params
* Remove unnecessary export
* Add rendererSettings param to bluebillywig adapter
* Kick off CircleCi tests manually
Co-authored-by: Klaas-Jan Boon <klaas-janboon@ip-172-16-224-85.eu-west-1.compute.internal>
Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com>
* OpenX Bid Adapter: Set Deal ID for video requests (#6573)
* 33Across Bid Adapter: add support for User ID modules (#6554)
* pubGENIUS bid adapter: support floor module (#6555)
* Welect Bid Adapter: update url of API (#6570)
* update api url
* update api url in tests
* Bright Mountain Media Bid Adapter: change bidder code to bmtm; alias old name (#6574)
* Adtelligent Bid Adapter: add adUrl support & new alias (#6559)
* add adUrl support
* add adUrl test
* Bright Mountain Media Bid Adapter: Change Endpoint URL (#6576)
* tappxBidAdapter: update
* tasppxBidAdapter: add video
* tappxBidAdapter: update video
* tappxBidAdapter: update name interpret banner
* tappxBidAdapter: add tests for video
* tappxBidAdapter: add adomain
* tappxBidAdapter: update adapter version
* tappxBidAdapter: update interpretBid adomain and dealid
* tappxBidAdapter: update isBidRequestValid
* tappxBidAdapter: update tests. Adding video to isBidRequestValid
* tappxBidAdapter: update doc .md file
* Tappx - Change accept floor module
* Tappx - feature simplification
* Tappx - remove log
* Change version
* Try to unrevert bad merge change
* Tappx - prebid recomendations and changes
* Tappx - CircleCI hotfixes
* Tappx - Non important fix
* Tappx - Test Coverage
* Tappx - CircleCI hotfixes
* Tappx - Only USD allowed in module floor + test
* Tappx - aesthetic change for uniformity of logs
* Tappx - CircleCI hotfixes
* Tappx - remove don't used module
* Tappx - Change the place and only one let
* Tappx - use of beforeEach
* Tappx - CircleCI hotfixes
Co-authored-by: marc_tappx <marc@tappx.com>
Co-authored-by: Patrick McCann <patmmccann@gmail.com>
Co-authored-by: onlsol <48312668+onlsol@users.noreply.github.com>
Co-authored-by: vincentproxistore <56686565+vincentproxistore@users.noreply.github.com>
Co-authored-by: guiann <guillaume.andouard@adyoulike.com>
Co-authored-by: Alexander <avj83@list.ru>
Co-authored-by: mmoschovas <63253416+mmoschovas@users.noreply.github.com>
Co-authored-by: SKOCHERI <37454420+SKOCHERI@users.noreply.github.com>
Co-authored-by: Abimael Martinez <abijr@users.noreply.github.com>
Co-authored-by: artemiokost <artemiokost@gmail.com>
Co-authored-by: Artem Kostritsa <akostritsa@akostritsa.com>
Co-authored-by: Alexander Kascheev <akascheev@asteriosoft.com>
Co-authored-by: pro-nsk <32703851+pro-nsk@users.noreply.github.com>
Co-authored-by: Rok Sušnik <rsusnik@outbrain.com>
Co-authored-by: Kanchika - Automatad <kanchika@automatad.com>
Co-authored-by: Paweł L <pawel.lankocz@adhese.eu>
Co-authored-by: Tim Sturtewagen <tim@adhese.com>
Co-authored-by: Mateusz <mateusz@adhese.eu>
Co-authored-by: jsnellbaker <31102355+jsnellbaker@users.noreply.github.com>
Co-authored-by: bretg <bgorsline@gmail.com>
Co-authored-by: Jason Snellbaker <jsnellbaker@appnexus.com>
Co-authored-by: Lemma Dev <54662130+lemmadev@users.noreply.github.com>
Co-authored-by: Abhijit Mane <abhipucsd.123@gmail.com>
Co-authored-by: matthieularere-msq <63732822+matthieularere-msq@users.noreply.github.com>
Co-authored-by: Denis Logachov <denis@adkernel.com>
Co-authored-by: RAJKUMAR NATARAJAN <raj.cs.psg@gmail.com>
Co-authored-by: Alexander Clouter <alex+github@digriz.org.uk>
Co-authored-by: Laura Morillo-Velarde <laura.morillovelarde@gmail.com>
Co-authored-by: Giudici-a <34242194+Giudici-a@users.noreply.github.com>
Co-authored-by: Galphimbl <sashatkachov91@gmail.com>
Co-authored-by: atkachov <atkachov91@admixer.ua>
Co-authored-by: Jérémie Girault <jeremie.girault@gmail.com>
Co-authored-by: Phaneendra Hegde <pnhegde@users.noreply.github.com>
Co-authored-by: Mikael Lundin <mikael-lundin@users.noreply.github.com>
Co-authored-by: Thomas <thomas.dseao@gmail.com>
Co-authored-by: Mike Chowla <mike.chowla@pubmatic.com>
Co-authored-by: Deivydas Šabaras <deivydas@users.noreply.github.com>
Co-authored-by: ym-atsymuk <81176595+ym-atsymuk@users.noreply.github.com>
Co-authored-by: Skylinar <53079123+Skylinar@users.noreply.github.com>
Co-authored-by: Adam Browning <19834421+adam-browning@users.noreply.github.com>
Co-authored-by: Catalin Ciocov <catalin.ciocov@gmail.com>
Co-authored-by: asurovenko-zeta <80847074+asurovenko-zeta@users.noreply.github.com>
Co-authored-by: readpeaktuomo <66239046+readpeaktuomo@users.noreply.github.com>
Co-authored-by: Ignat Khaylov <ignat@ignat.one>
Co-authored-by: nyakove <43004249+nyakove@users.noreply.github.com>
Co-authored-by: Mikhail Dykun <m.dykun@wmgroup.us>
Co-authored-by: ym-dlabuzov <81709888+ym-dlabuzov@users.noreply.github.com>
Co-authored-by: karentnarvaez <61426156+karentnarvaez@users.noreply.github.com>
Co-authored-by: Shannon Broekhoven <shannon@sortable.com>
Co-authored-by: nouchy <33549554+nouchy@users.noreply.github.com>
Co-authored-by: logicad <dev-ex-service@so-netmedia.jp>
Co-authored-by: mamatic <52153441+mamatic@users.noreply.github.com>
Co-authored-by: Klaas-Jan Boon <klaas-janboon@live.nl>
Co-authored-by: Klaas-Jan Boon <klaas-janboon@ip-172-16-224-85.eu-west-1.compute.internal>
Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com>
Co-authored-by: Kenan Gillet <1706856+kenan-gillet@users.noreply.github.com>
Co-authored-by: Aparna Rao <aparna.hegde@33across.com>
Co-authored-by: Meng <5110935+edmonl@users.noreply.github.com>
Co-authored-by: Nick Duitz <42961155+nduitz@users.noreply.github.com>
Co-authored-by: BrightMountainMedia <69471268+BrightMountainMediaInc@users.noreply.github.com>
Co-authored-by: Gena <wertixvost@gmail.com>
Co-authored-by: Albert Grandes <agrandes@tappx.com>
* Undertone, Unruly, Concert, Adform: stub support for advertiserDomains (#6727)
* Update eids.js
* Update eids_spec.js
* Update eids.js
* Update pubmaticBidAdapter_spec.js
* Update eids.js
* Update eids_spec.js
* Update conversantBidAdapter_spec.js
* Update rubiconBidAdapter_spec.js
* Update conversantBidAdapter_spec.js
* Delete test/spec/adapters directory
* Update userId_spec.js
* Delete iasBidAdapter.js
* Add files via upload
* Update openxBidAdapter.js
* Update openxBidAdapter.js
* Update concertBidAdapter.js
* Update unrulyBidAdapter.js
* Update undertoneBidAdapter.js
* Update adformBidAdapter.js
* Update adformBidAdapter_spec.js
* Update unrulyBidAdapter_spec.js
* Update concertBidAdapter_spec.js
* Update undertoneBidAdapter_spec.js
* Update undertoneBidAdapter.js
* Update adformBidAdapter_spec.js
* Update adformBidAdapter_spec.js
* Update undertoneBidAdapter_spec.js
* Update adformBidAdapter_spec.js
* Update adformBidAdapter_spec.js
* Bump hosted-git-info from 2.8.8 to 2.8.9 (#6728)
Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9.
- [Release notes](https://github.com/npm/hosted-git-info/releases)
- [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md)
- [Commits](https://github.com/npm/hosted-git-info/compare/v2.8.8...v2.8.9)
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* VIS.X: add instream video support (#6687)
* VIS.X: add instream video support
* VIS.X: move video params from bid.params to mediaTypes.video
* move reading and writing of the consent string hash for the user id module to after the gdpr checks. if no user id modules will be executed, this value isn't really necessary anyways. (#6551)
* Bright Mountain Media Bid Adapter: add video support and refactor (#6607)
* Update BrightMountainMedia cookie sync URL
* Bright Mountain Media: Update bidder code
* Bright Mountain Media: Add brightmountainmedia as alias
* Bright Mountain Media: Update Bid Endpoint
* Bright Mountain Media: Add support for Video and refactor
* Bright Mountain Media Bid Adapter: add video support and refactor
* Bright Mountain Media Bid Adapter: add video support and refactor
* Bright Mountain Media Bid Adapter: update test coverage
* Bright Mountain Media Bid Adapter: fix typo
* Bright Mountain Media Bid Adapter: fix example
* Bright Mountain Media Bid Adapter: add support for reading video params from ad unit
* Bright Mountain Media Bid Adapter: update read video config from bid.mediaTypes.video object
* Bright Mountain Media Bid Adapter: update playbackmethod and skip for video params
* Bright Mountain Media Bid Adapter: update skip for video params in test
* RTB House Bid Adapter: updated supply chain support, included floor module support and identity module support (eids) (#6721)
* ParrableIdSystem : Store third-party cookie support status in first-party cookie (#6689)
* Add tpcSupport, read it from xxhr and store it in compound cookie
* Parse a cookie boolean number (0, 1) as a boolean value
* Improve conditions
* Add tests
* Tests passing
* Read the cookie splitting parrableId and params (tpc, tpcUntil)
* Adapt tests
* Revert linting in test task
* Convert Date.now to seconds on reading cookie
* Add tests
* Replace Math.trunc with Math.floor
Co-authored-by: Victor <victorigualada@gmail.com>
* Bump lodash from 4.17.19 to 4.17.21 (#6722)
* Bump lodash from 4.17.19 to 4.17.21
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.19 to 4.17.21.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](https://github.com/lodash/lodash/compare/4.17.19...4.17.21)
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* ViewDeos: add gvlid (#6737)
* Revert "ParrableIdSystem : Store third-party cookie support status in first-party cookie (#6689)" (#6735)
This reverts commit ca100f4709f0a1d8782f09c159554a9914217653.
* Eplanning Bid Adapter: add eids (#6732)
* Adkernel: alias for adomega network (#6739)
* Update to move fpd data matching from taxonomyname to segtax values (#6679)
* Qwarry Bid Adapter: remove gdpr field from request (#6746)
* qwarry bid adapter
* formatting fixes
* fix tests for qwarry
* qwarry bid adapter
* add header for qwarry bid adapter
* bid requests fix
* fix tests
* response fix
* fix tests for Qwarry bid adapter
* add pos parameter to qwarry bid adapter
* qwarryBidAdapter onBidWon hotfix
* Change bidder endpoint url for Qwarry adapter
* add referer JS detection
* use bidderRequest.refererInfo
* fix tests
* GDPR consent string support
* NPE fix
* gdpr value added
* merge master
* gdpr value added
* qwarry bid adapter: add tests
* Qwarry bid adapter: remove gdpr field from request
Co-authored-by: Artem Kostritsa <akostritsa@akostritsa.com>
Co-authored-by: Alexander Kascheev <akascheev@asteriosoft.com>
* Halo RTD Module: add publisher params to RTD request (#6742)
* add pub provided halo params to rtd request
* missing semicolon
* halo id url arg update
* Prebid Core: Remove size check on native icons and image assets (#6678)
* remove image size checking
* fix unit tests
* Prebid Server Bid Adapter: Bugfix for not taking defaultVendor enabled (#6740)
* quick fix for enabled s2s bug
* move enabled check outside of defaultVendor if
* Prebid 4.39.0 Release
* increment pre version
* Beachfront Bid Adapter: add schain support (#6751)
* add schain support to beachfront adapter
* remove unnecessary mock tests for outstream player
Co-authored-by: John Salis <john@beachfront.com>
* fix: Webpack v5 complain about named export from JSON modules (#6755)
* Pbs bid adapter: constants import styling for webpack v5 upgrade (#6723)
* mapping spotx dealid to bid object
* using proper syntax to import default json module
* kick off tests
* es lint fix
Co-authored-by: Danny Khatib <dk2020@Dannys-MacBook-Pro.local>
Co-authored-by: Chris Huie <3444727+ChrisHuie@users.noreply.github.com>
* First Party Data module: Add new module and two submodules to populate defaults and validate ortb2 (#6452)
* Creating fpd module
* Continued work on FPD module.
- Data validation
- Pubcid optout check
- Misc Fixes
* Revert userId update. Committed in error
* Added first party data unit tests and fixed bug
* Added an unsubscribe for tests to run properly
* Reworked logic to use bidderRequests hook to update global/bidder configs instead of subscribing - former method was preventing tests from completing properly
* Merge master
* Removing unused references. Fixing device data to point to device.h/device.w
* Update to include opt out configuration for enrichments/validations
* Modified logic to use ortb2 configuration mapping. This will allow for entries to be added/removed/modified from configuration as opposed to be specifically called out in the validation functions
* Removed LGTM unneeded defensive code for check on object 'cur'
* Remove unused conditional
* Fix lint error
* Updates to remove currency enrichment as well as optout for user object
* Added optout flag to user.yob and user.gender fields
* Added test for arbitrary values
Added more comments
* Broke module out into module and two submodules
* Updated cur to validate as an array of strings not just a string
Updated comments
* Datablocks bid adapter: update adapter to conform to new bid server's format (#6696)
* update datablocks bid adapter
* remove TODO and fix linting errors
* updated readme and changed insights to ortb2
* fixed ortb2 change
Co-authored-by: John Mayor <john@Johns-iMac.local>
* Update to videoCache to include auction Id in vasttrack payload (#6757)
* Revert "Datablocks bid adapter: update adapter to conform to new bid server's format (#6696)" (#6763)
This reverts commit 2b8f888dc11d727f49867309f37e492d65eaee96.
* clarify dependency on global rtdModule (#6759)
As discussed with David from Permutive
* Update to PBS bid adapter for video bids, pass along w and h respectively and filter out contxt and playerSize params as PBS does not use them (#6682)
* Sovrn and Sharethrough Bid Adapters: support for advertiserDomains (#6764)
* Update eids.js
* Update eids_spec.js
* Update eids.js
* Update pubmaticBidAdapter_spec.js
* Update eids.js
* Update eids_spec.js
* Update conversantBidAdapter_spec.js
* Update rubiconBidAdapter_spec.js
* Update conversantBidAdapter_spec.js
* Delete test/spec/adapters directory
* Update userId_spec.js
* Delete iasBidAdapter.js
* Add files via upload
* Update openxBidAdapter.js
* Update openxBidAdapter.js
* Update sovrnBidAdapter.js
* Update sharethroughBidAdapter.js
* Update sharethroughBidAdapter_spec.js
* Update sovrnBidAdapter_spec.js
* Update sovrnBidAdapter_spec.js
* Update sharethroughBidAdapter_spec.js
* Update sharethroughBidAdapter_spec.js
* Update sharethroughBidAdapter_spec.js
* ucfunnel Bid Adapter: add support for FLoC and Verizon Media ConnectID (#6744)
* Add a new ucfunnel Adapter and test page
* Add a new ucfunnel Adapter and test page
* 1. Use prebid lib in the repo to keep updated
2. Replace var with let
3. Put JSON.parse(JSON.stringify()) into try catch block
* utils.getTopWindowLocation is a function
* Change to modules from adapters
* Migrate to module design
* [Dev Fix] Remove width and height which can be got from ad unit id
* Update ucfunnelBidAdapter to fit into new spec
* Correct the endpoint. Fix the error of query string
* Add test case for ucfunnelBidAdapter
* Fix lint error
* Update version number
* Combine all checks on bid request
* Add GDPR support for ucfunnel adapter
* Add in-stream video and native support for ucfunnel adapter
* Remove demo page. Add more test cases.
* Change request method from POST to GET
* Remove unnecessary comment
* Support vastXml and vastUrl for video request
* update TTL to 30 mins
* Avoid using arrow function which is not discuraged in mocha
* ucfunnel tdid support
* ucfunnel fix error message in debug mode
* ucfunnel adapter add bidfloor parameter
* ucfunnel adapter support CCPA
* ucfunnel adapter native support clicktrackers
* ucfunnel adapter change cookie sync setting
* ucfunnel adapter update request parameter
* Update ucfunnelBidAdapter
* ucfunnel adapter add currency in ad response
* ucfunnel adapter support uid2
* ucfunnel Bid Adapter: add support for FLoC and Verizon Media ConnectID
Co-authored-by: root <root@ubuntu.members.linode.com>
Co-authored-by: Ryan Chou <ryanchou0210@gmail.com>
Co-authored-by: ucfunnel <support@ucfunnel.com>
Co-authored-by: jack.hsieh <moonnight8520@gmail.com>
* Permutive Rtd Submodule: register submodule in submodules list (#6768)
* Beachfront Bid Adapter: update beachfront example docs (#6774)
Co-authored-by: John Salis <john@beachfront.com>
* Eplanning Bid Adapter: Adjust endpoint parameter formatting (#6772)
* Beachfront Bid Adapter: add Unified ID 2.0 support (#6770)
* appnexus bid adapter - create stub for meta.advertiserDomains (#6753)
* Conversant adapter - picks up additional params from mediaTypes.video (#6775)
* Relaido Adapter : size of the banner is checked and the banner can be bid on. (#6776)
* add relaido adapter
* remove event listener
* fixed UserSyncs and e.data
* fix conflicts
* take size each mediaType
Co-authored-by: ishigami_shingo <s.ishigami@relaido.co.jp>
Co-authored-by: cmertv-sishigami <s.ishigami@cmertv.com>
Co-authored-by: t_bun <t.bun@cmertv.com>
* ZetaSspBidAdapter fix typo (#6777)
Co-authored-by: Surovenko Alexey <surovenko.alexey@gmail.com>
* Adagio Bid Adapter: handle meta.advertiserDomains (and more) (#6781)
Related to #6650
* PubMatic Adapter: add support for FloCID (#6749)
* changes to support native in pubmaticbid adapter
* Removed port from endpoint
* Removed protocol from endpoint
* Formatting
* Fix request payload
* Updated test case
* Changed request and response as per ortb spec
* Change in request and response
* Removed comments and extra code
* Code Review comments
* Code Review Comments and Test cases for request and response
* Removed data type as all data asset types are handled
* Code Review Changes
* Code Review Comments
* Supporting both banner and native and sending 0x0 in case of native
* Bug Fixes
* Bug response not processed by prebid
* Change warning message
* Fixed typo
* Do not send request in case of invalid native bid
* Do not send request in case of invalid native requests
* objects converted to strings in log for debug purposes
* Fixed logic to check for required parmas
* Fixed typo for stringify
* documentation for native
* Review comments from Prebid
* Typo
* Typo
* Updated pub id for native
* Code Review
* Support for pubid
* Test Cases for PubCommonId in PubMatic adapter
* Delete yarn.lock
* Rename adaptermanager.js to adapterManager.js
* Rename yieldNexusBidAdapter.js to yieldnexusBidAdapter.js
* Rename yieldNexusBidAdapter.md to yieldnexusBidAdapter.md
* Rename yieldNexusBidAdapter_spec.js to yieldnexusBidAdapter_spec.yieldnexusBidAdaptera
* Rename yieldnexusBidAdapter_spec.yieldnexusBidAdaptera to yieldnexusBidAdapter_spec.js
* bluebillywig outstream player support in pubmatic adapter
* removed pubcommon id test cases
* BBW Renderer
* Pubmatic should work with provided renderer
* Review Comments
* changes for flocId
* code review comments
* fixed for eids
* code review comments
* unit test cases for floc
* updated md file
* code review comment
* TrustX Bid Adapter: added additional sync url (#6771)
* Bucksense Bid Adapter: add adomain to adapter (#6779)
* Update bucksenseBidAdapter.js
Added support for advertiserDomains
* Update bucksenseBidAdapter_spec.js
Co-authored-by: Patrick McCann <patmmccann@gmail.com>
* Update to PBS Bid Adapter and RP Bid Adapter to pass PBJS version in auction requests (#6767)
* AOL Bid Adapter: Remove client side support for already deprecated endpoint floor support (#6743)
* tappx Bid Adapter: update isBidRequestValid and fix request url (#6761)
* UPDATE: add initial UID
* UPDATE: UID change user ext
* UPDATE: UID clean logs
* UPDATE: add host info
* UPDATE: tappx bid adapter universal id
* UPDATE: fix bidder param
* UPDATE: tappxBidAdapter tests
* tappxBidAdapter - fix spacing
* tappxBidAdapter: add test user eids array
* tappxBidAdapter: update eids array
* FIX: package-lock.json
* Conversant adapter: add adomain, remove digitrust (#6495)
* Update eids.js
* Update eids_spec.js
* Update eids.js
* Update pubmaticBidAdapter_spec.js
* Update eids.js
* Update eids_spec.js
* Update conversantBidAdapter_spec.js
* Update rubiconBidAdapter_spec.js
* Update conversantBidAdapter_spec.js
* Delete test/spec/adapters directory
* Update userId_spec.js
* Update conversantBidAdapter.js
* Update conversantBidAdapter_spec.js
* Update conversantBidAdapter_spec.js
* Update conversantBidAdapter_spec.js
* Rads Bid Adapter: add GDPR support & user sync support (#6455)
* Proxistore Bid Adapter: add cookieless url endpoint & use floor module (#6427)
* use floor module
* call cookieless endpoint when necessary
* test endpoint url
* change url endpoint
* delete console log
* fix tests
* add language to url
* use ortb interface
* unit test
* update test unit
* create proxistore module
* add unit tests and documentation
* delete modules
* delete module
* add proxistore rtd submodule
* delete proxistore module
* spacing
* change url
* AdYoulike Bid Adapter: Add an "Insertion" tracking for Native mediatype (#6481)
* add insertion event
* add missing campaign ID parameter
* update unit test with new tracking checked
* Dspx Bid Adapter : add user sync support (#6456)
* Add sync support for dspx adapter
* Dspx Bid Adapter : add user sync support
Co-authored-by: Alexander <avj83@list.ru>
* Multibid Module: add new module to handle multiple bids from single bidder & update rubicon adapter (#6404)
* Multibid module - create new module
- Expands the number of key value pairs going to the ad server in the normal Prebid way by establishing the concept of a "dynamic alias"
First commit
* Continued updates from 1st commit
* Adding logWarn for filtered bids
* Update to include passing multibid configuration to PBS requests
* Update to rubicon bid adapter to pass query param rp_maxbids value taken from bidderRequest.bidLimit
* Update to config to look for camelcase property names according to spec. These convert to all lowercase when passed to PBS endpoint
* Adjust RP adapter to always include maxbids value - default is 1
* Added support for bidders array in multibid config
* Fixed floor comparison to be <= bid cpm as oppossed to just < bid cpm. Updated md file to fix camelCase tpyo
* Update to include originalBidderRequest in video call to prebid cache
* Update to ignore adpod bids from multibid and allow them to return as normal bids
* Adding uid2 to submodules.json (#6508)
* NextRoll ID System: add new ID module (#6396)
* Add Nextroll ID Module
* Add nextroll to eids
* Make configuration value names consistent with Adapter Module
* Use parnerId instead of sellerId
* Add nextroll to userId and eids md files
* Remove storage configuration
* Rename nextroll -> nextrollId
* Add nextrollId to common ID specs
* Qwarry Bid Adapter: add GDPR and consent string handling (#6489)
* qwarry bid adapter
* formatting fixes
* fix tests for qwarry
* qwarry bid adapter
* add header for qwarry bid adapter
* bid requests fix
* fix tests
* response fix
* fix tests for Qwarry bid adapter
* add pos parameter to qwarry bid adapter
* qwarryBidAdapter onBidWon hotfix
* Change bidder endpoint url for Qwarry adapter
* add referer JS detection
* use bidderRequest.refererInfo
* fix tests
* GDPR consent string support
* NPE fix
Co-authored-by: Artem Kostritsa <akostritsa@akostritsa.com>
Co-authored-by: Alexander Kascheev <akascheev@asteriosoft.com>
Co-authored-by: pro-nsk <32703851+pro-nsk@users.noreply.github.com>
* Zemanta Bid Adapter: add support for new params & consent strings to usersync URL (#6468)
* add gvl id to spec
* add support for bcat and badv params
* add consent strings to usersync url
* add bcat and badv params to doc
* Automatad Bid Adapter: Add meta.advertiserDomains to bid response (#6509)
* added bid meta with advertiserDomains
* Adhese Bid Adapter: add support for caching video content (#6501)
* adpod category support test
* Revert "adpod category support test"
This reverts commit 70a3cf2ad5db94757addd9e08c3a083caca282d0.
* adpod category support test
* Revert "adpod category support test"
This reverts commit 70a3cf2ad5db94757addd9e08c3a083caca282d0.
* Adhese Bid Adapter: cache video content
Co-authored-by: Tim Sturtewagen <tim@adhese.com>
Co-authored-by: Mateusz <mateusz@adhese.eu>
* update apacdex unit test to disable debug mode (#6511)
* Telaria: not setting adid (#6507)
* Prebid 4.33.0 Release
* increment pre version
* rubicon: removing maxduration as a required bidder parameter (#6513)
* Zemanta adapter: add advertiserDomains (#6517)
* Lemma Bid Adapter: accepting the floor to use the getFloor function (#6497)
* lemmaBidAdapter.js
Added lemma bid adapter file
* lemmaBidAdapter.md
Added lemma bid adapter md file
* lemmaBidAdapter_spec.js
Added lemma bid adapter test spec file
* Update lemmaBidAdapter.js
Fixed automated code review alert comparison between inconvertible types
* Update lemmaBidAdapter.js
Fixed review changes
* Update lemmaBidAdapter.md
Correct parameter value.
* Update lemmaBidAdapter.js
Lemma Bid Adapter - v3.0 compliance
* Update lemmaBidAdapter_spec.js
Lemma Bid Adapter - v3.0 compliance
* Update lemmaBidAdapter.md
Lemma Bid Adapter - v3.0 compliance
* Update lemmaBidAdapter.js
Added user sync support into bid adapter.
* updated include modules file extension.
updated include modules js file extension.
* Update lemmaBidAdapter_spec.js
Added unit test for user sync feature.
* Update lemmaBidAdapter.js
Fixed format error.
* Update lemmaBidAdapter_spec.js
Fixed format error and typo error.
* Set mediaType key value into bid object
Set mediaType key value into the bid object.
* Update lemmaBidAdapter.js
remove duplicate function
* Update lemmaBidAdapter.js
Remove non supported code.
* Update lemmaBidAdapter_spec.js
Remove GDPR test cases.
* Update lemmaBidAdapter.js
Made changes for accepting the floor to use the getFloor function
* Update lemmaBidAdapter.js
correct undefined keyword name.
* Update lemmaBidAdapter_spec.js
Added test coverage floor value
* Update lemmaBidAdapter.js
Remove trailing spaces on lines 379 and 381.
* Update lemmaBidAdapter_spec.js
Added getFloor function test case changes, Please review it.
* Update lemmaBidAdapter_spec.js
* Update lemmaBidAdapter.js
* Update lemmaBidAdapter.js
Fixed lint issue.
* Update lemmaBidAdapter_spec.js
Fixed test cases.
* Update lemmaBidAdapter_spec.js
Made suggested changes. Please review it.
Co-authored-by: Abhijit Mane <abhipucsd.123@gmail.com>
* Mediasquare Bid Adapter: fix getUserSyncs issue with empty bids + add metrics to onBidWon Event (#6480)
* Mediasquare bidder: fix getUserSyncs issue with empty bids + add metrics to onBidWon Event
* Mediasquare bidder: fix getUserSyncs issue with empty bids + add metrics to onBidWon Event
* removing status as it does not seem populated when called
* add tests
* Update nextroll ID variable name to match published ID module (#6519)
* Merkle User ID Module: updates to user id submodule (#6503)
* AdKernel Bid/Analytics Adapters: user privacy related changes (#6488)
* SynacorMedia: remove adId from the bid response (#6520)
* Rubicon: making doc data types consistent (#6526)
* Synacormedia Bid Adapter: add meta.advertiserDomains (#6527)
* Adloox Analytics Adapter: add new analytics adapter (#6308)
* gulp: fix supplying list of browsers to test against
The following now works: gulp test --browserstack --nolint --nolintfix --browsers=bs_ie_11_windows_10 --file 'test/spec/modules/adloox{AnalyticsAdapter,AdServerVideo,RtdProvider}_spec.js'
* instreamTracking: unit test tidy
From @robertrmartinez in https://github.com/prebid/Prebid.js/pull/6308#issuecomment-810537538
* adloaderStub: expose stub for other unit tests to use
From @robertrmartinez in https://github.com/prebid/Prebid.js/pull/6308#issuecomment-810537538
* Adloox analytic module
* Seedtag adapter: Fixing bug preventing to receive the right params onTimeout. (#6525)
* adot bid adapter: add publisher path from bidder config to endpoint url (#6476)
* Admixer ID System: add userId submodule (#6238)
* Migrating to Prebid 1.0
* Migrating to Prebid 1.0
* Fix spec
* add gdpr and usp
* remove changes in gdpr_hello_world.html
* Update gdpr_hello_world.html
add spaces
* add user syncs
* remove comments
* tests
* admixer id system
* admixer id system
* admixer id system eids.md userId.md
* admixer id system .submodules.json
* admixer id system
Co-authored-by: atkachov <atkachov91@admixer.ua>
* PBJS Core: call custom render func after loadscript if provided (#6422)
* Pubxai Analytics Adapter: bug fixes and code revamp (#6474)
* Updated PubxAiAnalytics adapter - Bug fixes and Code restructuring
* Updated endpoint URLs
* Changed array.includes to array.indexOf to fix IE issue
* Code cleanup and changes as suggested.
* Updated browser testing order and edge browser token
* PBJS Core: canBidderRegisterSync ignoring iframe sync disabled by default (#6535)
* Update eids.js
* Update eids_spec.js
* Update eids.js
* Update pubmaticBidAdapter_spec.js
* Update eids.js
* Update eids_spec.js
* Update conversantBidAdapter_spec.js
* Update rubiconBidAdapter_spec.js
* Update conversantBidAdapter_spec.js
* Delete test/spec/adapters directory
* Update userId_spec.js
* Update userSync.js
* Update userSync_spec.js
* Added automatic tzo and targetId to adserver request. (#6534)
* Impactify Bid Adapter: add new bid adapter (#6518)
* Add impactify adapter with MD file
* Add impactify adapter
* Prebid 4.34.0 Release
* Increment pre version
* Prebid server adapter: add config for openx hosting (#6530)
* Yieldmo adapter: add meta data to bids (#6550)
* Smartx Bid Adapter: Add meta.advertiserDomains support (#6547)
* Onevideo / Adap.tv Adapter: updated example configuration (#6546)
* Mass Deal Rendering Module: support multiple custom configs for dealId and rendering (#6500)
* ZetaSsp Bid Adapter: add new bid adapter (#6432)
* Adnuntius Bid Adapter: Fix for bid too low. (#6557)
* Added automatic tzo and targetId to adserver request.
* Fixing issues with bid price being too low.
* Fixing issues with bid price being too low.
* ReadPeak Bid Adapter: fix api issues, add gdpr consent, & getfloor module support (#6548)
* BetweenBidAdatper: added sharedid support (#6531)
* adWMG Bid Adapter: update endpoints for cookie sync (#6544)
* Support floorCPM parameter, fix some minor bugs
* fix space-in-parens circleci error
* example fix
* clean usersync URL
* spaces
* spaces
* add new unit tests, compatibility with IE11
* remove logInfo
* Check for floorCPM value
* Check params before sending
* New endpoints
* code format
* new endpoint for cookie sync
* update tests
Co-authored-by: Mikhail Dykun <m.dykun@wmgroup.us>
* Yieldmo Bid Adapter: add support for the floors module (#6541)
* Sortable Bid Adapter: add eids support (#6565)
* Add Sortable adapter for Prebid 3.x
Update tests to reflect changes.
* Add .js in imports
* hostname not host: don't include port
* Trivial change to trigger build: failure wasn't our adapter
* More failures in other adapters
* PR Feedback
- use https for URL
- fix examples in markdown
- request to endpoint should work now
* Feedback: add native and video examples
* Update unit tests
Co-authored-by: Shannon Broekhoven <shannon@sortable.com>
* Outbrain Bid Adapter: replacing Zemanta (#6558)
* Sirdata Real-time Data Module: add new RTD module (#6515)
* Logicad Bid Adapter: add support for userid modules (#6529)
* ATS-identityLinkIdSystem - add use3P config property to control firing of 3P envelope endpoint (#6568)
* Proxistore Bid Adapter: add support for tcf v2 consent (#6543)
* use tcf v2 consent
* set cosentGiven to false and test Gdpr api v2
* BlueBillyWig Bid Adapter: add renderer customization options (#6540)
* add Blue Billywig adapter
* Blue Billywig Adapter - update according to review feedback
* Blue Billywig Adapter - update to try and pass CircleCI
* Remove the last for .. of in bluebillywigBidAdapter.js, hopefully...
* Update bluebillywigBidAdapter test parameters to match renderer to rendererCode rename
* Blue Billywig - Also pass through site config with OpenRTB request
* add Blue Billywig adapter
* Blue Billywig Adapter - update according to review feedback
* Blue Billywig Adapter - update to try and pass CircleCI
* Remove the last for .. of in bluebillywigBidAdapter.js, hopefully...
* Code quality update, always hit user syncs, improved video params
* Remove unnecessary export
* Add rendererSettings param to bluebillywig adapter
* Kick off CircleCi tests manually
Co-authored-by: Klaas-Jan Boon <klaas-janboon@ip-172-16-224-85.eu-west-1.compute.internal>
Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com>
* OpenX Bid Adapter: Set Deal ID for video requests (#6573)
* 33Across Bid Adapter: add support for User ID modules (#6554)
* pubGENIUS bid adapter: support floor module (#6555)
* Welect Bid Adapter: update url of API (#6570)
* update api url
* update api url in tests
* Bright Mountain Media Bid Adapter: change bidder code to bmtm; alias old name (#6574)
* Adtelligent Bid Adapter: add adUrl support & new alias (#6559)
* add adUrl support
* add adUrl test
* Bright Mountain Media Bid Adapter: Change Endpoint URL (#6576)
* tappxBidAdapter: update
* tasppxBidAdapter: add video
* tappxBidAdapter: update video
* tappxBidAdapter: update name interpret banner
* tappxBidAdapter: add tests for video
* tappxBidAdapter: add adomain
* tappxBidAdapter: update adapter version
* tappxBidAdapter: update interpretBid adomain and dealid
* tappxBidAdapter: update isBidRequestValid
* tappxBidAdapter: update tests. Adding video to isBidRequestValid
* tappxBidAdapter: update doc .md file
* tappxBidAdapter: update isBidRequestValid
* tappxBidAdapter: update ads sizes available
* tappxBidAdapter: update isBidRequestValid
* tappxBidAdapter: update host depending tappx endpoint
* tappxBidAdapter: update tappx adapter version
* tappxBidAdapter: add EOL
* revert outbrain cahnges to untrack in this pr
* tappxBidAdapter: update isBidRequestValid tests
* tappxBidAdapter: fix circleci error
Co-authored-by: marc_tappx <marc@tappx.com>
Co-authored-by: Patrick McCann <patmmccann@gmail.com>
Co-authored-by: onlsol <48312668+onlsol@users.noreply.github.com>
Co-authored-by: vincentproxistore <56686565+vincentproxistore@users.noreply.github.com>
Co-authored-by: guiann <guillaume.andouard@adyoulike.com>
Co-authored-by: Alexander <avj83@list.ru>
Co-authored-by: mmoschovas <63253416+mmoschovas@users.noreply.github.com>
Co-authored-by: SKOCHERI <37454420+SKOCHERI@users.noreply.github.com>
Co-authored-by: Abimael Martinez <abijr@users.noreply.github.com>
Co-authored-by: artemiokost <artemiokost@gmail.com>
Co-authored-by: Artem Kostritsa <akostritsa@akostritsa.com>
Co-authored-by: Alexander Kascheev <akascheev@asteriosoft.com>
Co-authored-by: pro-nsk <32703851+pro-nsk@users.noreply.github.com>
Co-authored-by: Rok Sušnik <rsusnik@outbrain.com>
Co-authored-by: Kanchika - Automatad <kanchika@automatad.com>
Co-authored-by: Paweł L <pawel.lankocz@adhese.eu>
Co-authored-by: Tim Sturtewagen <tim@adhese.com>
Co-authored-by: Mateusz <mateusz@adhese.eu>
Co-authored-by: jsnellbaker <31102355+jsnellbaker@users.noreply.github.com>
Co-authored-by: bretg <bgorsline@gmail.com>
Co-authored-by: Jason Snellbaker <jsnellbaker@appnexus.com>
Co-authored-by: Lemma Dev <54662130+lemmadev@users.noreply.github.com>
Co-authored-by: Abhijit Mane <abhipucsd.123@gmail.com>
Co-authored-by: matthieularere-msq <63732822+matthieularere-msq@users.noreply.github.com>
Co-authored-by: Denis Logachov <denis@adkernel.com>
Co-authored-by: RAJKUMAR NATARAJAN <raj.cs.psg@gmail.com>
Co-authored-by: Alexander Clouter <alex+github@digriz.org.uk>
Co-authored-by: Laura Morillo-Velarde <laura.morillovelarde@gmail.com>
Co-authored-by: Giudici-a <34242194+Giudici-a@users.noreply.github.com>
Co-authored-by: Galphimbl <sashatkachov91@gmail.com>
Co-authored-by: atkachov <atkachov91@admixer.ua>
Co-authored-by: Jérémie Girault <jeremie.girault@gmail.com>
Co-authored-by: Phaneendra Hegde <pnhegde@users.noreply.github.com>
Co-authored-by: Mikael Lundin <mikael-lundin@users.noreply.github.com>
Co-authored-by: Thomas <thomas.dseao@gmail.com>
Co-authored-by: Mike Chowla <mike.chowla@pubmatic.com>
Co-authored-by: Deivydas Šabaras <deivydas@users.noreply.github.com>
Co-authored-by: ym-atsymuk <81176595+ym-atsymuk@users.noreply.github.com>
Co-authored-by: Skylinar <53079123+Skylinar@users.noreply.github.com>
Co-authored-by: Adam Browning <19834421+adam-browning@users.noreply.github.com>
Co-authored-by: Catalin Ciocov <catalin.ciocov@gmail.com>
Co-authored-by: asurovenko-zeta <80847074+asurovenko-zeta@users.noreply.github.com>
Co-authored-by: readpeaktuomo <66239046+readpeaktuomo@users.noreply.github.com>
Co-authored-by: Ignat Khaylov <ignat@ignat.one>
Co-authored-by: nyakove <43004249+nyakove@users.noreply.github.com>
Co-authored-by: Mikhail Dykun <m.dykun@wmgroup.us>
Co-authored-by: ym-dlabuzov <81709888+ym-dlabuzov@users.noreply.github.com>
Co-authored-by: karentnarvaez <61426156+karentnarvaez@users.noreply.github.com>
Co-authored-by: Shannon Broekhoven <shannon@sortable.com>
Co-authored-by: nouchy <33549554+nouchy@users.noreply.github.com>
Co-authored-by: logicad <dev-ex-service@so-netmedia.jp>
Co-authored-by: mamatic <52153441+mamatic@users.noreply.github.com>
Co-authored-by: Klaas-Jan Boon <klaas-janboon@live.nl>
Co-authored-by: Klaas-Jan Boon <klaas-janboon@ip-172-16-224-85.eu-west-1.compute.internal>
Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com>
Co-authored-by: Kenan Gillet <1706856+kenan-gillet@users.noreply.github.com>
Co-authored-by: Aparna Rao <aparna.hegde@33across.com>
Co-authored-by: Meng <5110935+edmonl@users.noreply.github.com>
Co-authored-by: Nick Duitz <42961155+nduitz@users.noreply.github.com>
Co-authored-by: BrightMountainMedia <69471268+BrightMountainMediaInc@users.noreply.github.com>
Co-authored-by: Gena <wertixvost@gmail.com>
Co-authored-by: Chris Huie <3444727+ChrisHuie@users.noreply.github.com>
* Qwarry Bid Adapter: add sizes (#6787)
* qwarry bid adapter
* formatting fixes
* fix tests for qwarry
* qwarry bid adapter
* add header for qwarry bid adapter
* bid requests fix
* fix tests
* response fix
* fix tests for Qwarry bid adapter
* add pos parameter to qwarry bid adapter
* qwarryBidAdapter onBidWon hotfix
* Change bidder endpoint url for Qwarry adapter
* add referer JS detection
* use bidderRequest.refererInfo
* fix tests
* GDPR consent string support
* NPE fix
* gdpr value added
* merge master
* gdpr value added
* qwarry bid adapter: add tests
* Qwarry bid adapter: remove gdpr field from request
* qwarry bid adapter: add sizes
* qwarry bid adapter: add sizes
Co-authored-by: Artem Kostritsa <akostritsa@akostritsa.com>
Co-authored-by: Alexander Kascheev <akascheev@asteriosoft.com>
* Medianet bid adapter: floor module support (#6713)
* Medianet floor module support
* removing backslash from wildcard
* add adomain support (#6791)
Co-authored-by: Ignat Khaylov <khaylov@betweenx.com>
* Beachfront Bid Adapter: add floors module support (#6752)
* add price floors support to beachfront adapter
* revert doc changes to create separate pull request
Co-authored-by: John Salis <john@beachfront.com>
* Zeta Ssp Bid Adapter: merge fpd.device and params.device (#6786)
* pubGENIUS bid adapter: read more video params from mediaTypes.video (#6793)
* Remove camel case for adserver.adslot value in RP Analytics Adapter (#6795)
* Prebid 4.40.0 Release
* Increment pre version
* CCX Bid Adapter: add support for mediatypes video parameters (#6736)
* adomain support
* adomain support
* adomain support
* adomain support
* adomain support
* video params
* docs changes
* Index Exchange Bid Adapter: adds support for floc (#6758)
* InvibesBidAdapter - multiposition support & support for multiple id modules (#6506)
* appnexus bid adapter: add support for flocid (#6801)
* appnexus bid adapter: add support for uid2 (#6802)
* Delete xhbBidAdapter.js
* Restore xhb (#6803)
* EMX Digital Bid Adapter: floor module and advertiserDomain support (#6805)
* Index Exchange Bid Adapter: coppa support, dealid & ttl field updates (#6782)
* set bidderRequestId to be a string in r.id
* set coppa value in r.reqs.coppa
* added support for seat[].bid[].exp ttl value
* read dealid from openrtb first, then fallback to ext
* use utils.isInteger
Co-authored-by: Kajan Umakanthan <umakajan@umakajan.com>
Co-authored-by: punkiller <pankajkumar555@gmail.com>
* Update permutiveRtdProvider.md (#6810)
Updated to reflect current audience connector support.
* Conversant adapter - add support for the floor module (#6798)
* JW Player RTD Module - dev doc improvements (#6811)
* update OpenX adapter to support mediaTypes.video and gpid (#6813)
* SynacorMedia Bid Adapter: Add userID support (#6790)
* SynacorMedia Bid Adapter: Add userID support
* SynacorMedia Bid Adapter: User ID Support - Remove an unncessary conditional and use indexOf vs includes for IE11 support
* VIS.X: change tracking win & pending url's (#6815)
* Ogury Bid Adapter: add new adapter (#6729)
* ParrableIdSystem: Store third-party cookie support status in first-party cookie (#6741)
* Add tpcSupport, read it from xxhr and store it in compound cookie
* Parse a cookie boolean number (0, 1) as a boolean value
* Improve conditions
* Add tests
* Tests passing
* Read the cookie splitting parrableId and params (tpc, tpcUntil)
* Adapt tests
* Revert linting in test task
* Convert Date.now to seconds on reading cookie
* Add tests
* Replace Math.trunc with Math.floor
* kick off test
* unfollowed local fork, kick off test
* Increase cookie expire time to 20s
Co-authored-by: Victor <victorigualada@gmail.com>
Co-authored-by: Chris Huie <3444727+ChrisHuie@users.noreply.github.com>
* update ID5 docs for PD string links (#6824)
* Adagio Bid Adapter: decrease adapter weight (#6699)
* PubMatic Adapter : Support For Video Params from AdUnit MediaTypes (#6773)
* Fill currency parameters for Kobler adapter. (#6825)
* Adf Bid Adapter: banner and video media type support added (#6726)
* Trion bid adapter: support for meta advertiserDomains (#6829)
* Adding files associated with the trion adapter update to the newest prebid version(1.0).
* Updating pull request with safer checks for user sync and general clean up/consistency of tests.
* removing a call to bidder code for pull request review. also removing the test that requires it
* there were some changes to the bid factory after our initial release that we didn't account for. Changing adapter to account for response body and required params.
* Revert "there were some changes to the bid factory after our initial release that we didn't account for. Changing adapter to account for response body and required params."
This reverts commit 324d15785fb61c92db9c0a37f1001f47721e3a25.
* there were some changes to the bid factory after our initial release that we didn't account for. Changing adapter to account for response body and required params.
* adding safety checks to Trion adapter
* Sending up to trion endpoint if there is bot traffic or the browser tab is not visible.
* sending the wrong param in the test.
* Trion test cleanup. returning document and window states to their original form after tests.
* Trion test cleanup. using before and after to alter window and document objects in tests.
* re-adding trion adapter to prebid project to stop using deprecated function for page url for 3.0 release
* minor formatting change
* accept size array from media types banner over the sizes array from pubs.
* updating trion bid adapter to be us privacy and gdpr compliant
* encoding consent strings for test
* Trion adapter update. Changing request params to trion including removing support for optional 're' param, cleaning up existing params to send 1/0 instead of null when non is present and adding prebid version.
* adding support for meta advertiserDomains in trion bid adapter for future use
Co-authored-by: Mike Groh <mgroh@trioninteractive.com>
* Release Drafter: update to minor as the default (#6827)
* Sonobi bid adapter: add support for gpid and set advertiserDomains (#6826)
* added gpid to sonobi bidder adapter. It tries to get the gpt ad unit code
* added advertiser domain to bid meta
* Eplanning Bid Adapter: verify getUserIds exists and is a function; add adomain support (#6832)
* Dgkeyword Rtd Provider: add new real-time data submodule (#6410)
* add dgkeywordRtdProvider
* change access url
* we change not to access real url.
and one test case delete because of the changing.
* update test code.
update api access using ajax()
* update test code
* set keywords using setBidderConfig in ortb2.
* change test code for circle CI
Co-authored-by: Patrick McCann <patmmccann@gmail.com>
* Revert "Dgkeyword Rtd Provider: add new real-time data submodule (#6410)" (#6837)
This reverts commit e97db76c9288c82f849b9456b017ab010843b1a4.
Co-authored-by: Olivier <osazos@adagio.io>
* NativoBidAdapter - Added new QS param to the bid request endpoint (#6838)
* Initial nativoBidAdapter document creation (js, md and spec)
* Fulling working prebid using nativoBidAdapter. Support for GDPR and CCPA in user syncs.
* Added defult size settings based on the largest ad unit. Added response body validation. Added consent to request url qs params.
* Changed bidder endpoint url
* Changed double quotes to single quotes.
* Reverted package-json.lock to remove modifications from PR
* Added optional bidder param 'url' so the ad server can force- match an existing placement
* Lint fix. Added space after if.
* Added new QS param to send various adUnit data to adapter endpopint
* Updated unit test for new QS param
* Vuukle bid adapter: support for meta advertiserDomains (#6839)
* add vuukle adapter
* add readme
* doc: add email
* Vuukle bid adapter: support for meta advertiserDomains
* add support for advertiser domains and other bid meta (#6842)
Co-authored-by: John Salis <john@beachfront.com>
* Prebid Core: Check for stale rendering (#6707)
* Check for stale rendering
* Check for stale rendering - code review changes
* tappx Bid Adapter: fix wrong regex and gdpr bug (#6834)
* tappxBidAdapter: hotfix gdpr url param
* tappxBidAdapter: update version
* tappxBidAdapter: update regex errors
* Adyoulike bid adapter - improvements on Native case (#6831)
* add required clickurl in every native adrequest
* allows the native response to be given as is to prebid if possible
* add unit tests on new Native case
* Zeta Ssp Bid Adapter: Improve user sync logic (#6835)
* Mediasquare Bid Adapter: support advertiserDomains (#6843)
* Mediasquare Bid Adapter: support advertiserDomains
* Update mediasquareBidAdapter.js
* add unit tests
* fix unit test
* fix string single quote
* Apacdex Bid Adapter: add support for me…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
(First-attempt #6689)
The Parrable backend tests a browser's support of third-party cookies on each request. If the test cookie is stored successfully (third party cookies are supported in the browser) then the cookie may remain up to 24 hours in the browser and be sent along with subsequent requests to our backend. We will not attempt to re-test third-party cookie status if the third-party cookie is received.
This change introduces a small value, to be stored in our compound/composite first-party cookie that retains the state of the browser's third-party cookie support from the last time it was tested. This is beneficial in browsers that don't support third-party cookies where we would otherwise always re-test their third-party cookie support on each request made.
The solution is implemented by storing two additional values in the first-party cookie maintained under prebid. The first is the actual state of third-party cookie support in the browser. This value is returned from our backend systems after the third-party cookie test is complete. The second value is a future unix timestamp (in seconds) that determines when the stored third-party cookie state is no longer valid, and will not be supplied to our backend, thus causing a re-test of the browser's third-party cookie support.
This change is internally facing and only affects our cookie storage layout, and the request/response exchange with our backend systems.
Other information