Datablocks Bid Adapter : update bid adapter and add 5.0 compliance

[htang555]

Type of change

• Bugfix
• Feature
• New bidder adapter
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Does this change affect user-facing APIs or examples documented on http://prebid.org?
• Other

Description of change

As per @ChrisHuie in #6696 (comment)

• test parameters for validating bids

{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

• contact email of the adapter’s maintainer
• official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

• A link to a PR on the docs repo at https://github.com/prebid/prebid.github.io/

Other information

[ChrisHuie]

Working to figure out how to kick off the CircleCI tests on this pr.

[ChrisHuie]

@htang555 could you give me edit access to this pr to try and manually kick off the tests

[htang555]

@ChrisHuie just granted you write access to the repo.

[ChrisHuie]

@htang555 I tried to manually kick-off the CircleCi tests but that didn't seem to work. I think merging upstream, in this case, should kick off the CircleCi tests. This is a pretty unique situation so sorry for the back and forth to get this working with our testing setup.

[patmmccann]

Please make sure to add support for meta.advertiserDomains

[ChrisHuie]

I have a follow-up call with CircleCI on this specific pr because everything they told me and I have tried hasn't worked and want to get to the bottom of why this is not being ran through CircleCI.

[htang555]

Can we just have this merged manually and troubleshoot the circleCI issue later? The delay in this is due to your automation/devops whereas the actual tests run fine when done manually.

[ChrisHuie]

@htang555 so the CircleCI is our end2end and integration tests on multiple browsers so usually passing unit tests is only a piece of the puzzle. Let me see if I can create a new pr that kicks off the tests

[ChrisHuie]

@htang555 I tried to reopen this pr and still isn't working. Talking to CircleCI today to get this moving so we can have this in next weeks release. Usually this problem has to do with following the fork of prebid in circleci but not the main project. However, never not been able to kick off tests myself.

[htang555]

Hey @ChrisHuie any more progress on this? This delay is really affecting us.

[ChrisHuie]

@htang555 I managed to kick off the tests for this pr but had to essentially clone it and tie it to a pr from me. This has to do with accepting forks as prs so going into the settings as soon as I can get admin access for our CircleCI to solve this going forward. Looks like some tests are not passing though. The tests that aren't related to yours also should hopefully resolve themselves because at first glance this looks like a timing issue.

[aleksatr]

@ChrisHuie I approved the changes on the previous PR, as well as on this one, but I'm not sure why CircleCI is failing, I restarted the workflow several times, but it keeps failing.

[ChrisHuie]

@aleksatr Yeah. These were the same errors I was getting when we merged it. Later I can dig into the code and see if anything jumps out in this pr at me.

[jmayor]

@ChrisHuie Do you have an ETA on when our changes will be merged into master?

Looking at the circleci tests I do see this error:

DatablocksAdapter
getUserSyncs
✗ Should return array of syncs
TypeError: Object doesn't support property or method 'fromEntries'
at addParams (webpack:///modules/datablocksBidAdapter.js:459:7 <- test/test_index.js:49157:7)
at Anonymous function (webpack:///modules/datablocksBidAdapter.js:450:11 <- test/test_index.js:49147:11)
at Array.prototype.forEach (native code)
at getUserSyncs (webpack:///modules/datablocksBidAdapter.js:448:7 <- test/test_index.js:49145:7)
at Anonymous function (webpack:///test/spec/modules/datablocksBidAdapter_spec.js:427:7 <- test/test_index.js:219233:7)

Is this what is holding things up? Line 459 is valid code - I am not sure why it would be failing
I can adjust the code if need be

[ChrisHuie]

@jmayor yes the failing tests are currently holding this up. I can't merge it in until it passes all current testing. This pr doesn't seem to be passing that unit test and also appears to be adding latency to the integration testing because it is impacting several other tests so not sure this is working as intended.

[jmayor]

Ok - I re-wrote that section of the code. It was using some ES6 code that I guess there is no polyfill for
Lets see if it passes

[jmayor]

@ChrisHuie

Chris - looks like all the tests finally passed!

They were all related to IE11 - I guess there is no polyfill for some of the Object functions in JS

[ChrisHuie]

Looks like we are getting closer! The datablocks errors seem to be cleared up but still looks like we are getting errors in a couple other adapters which I am assuming has to deal with storage manager interaction or sinon itself.

[htang555]

Thanks @ChrisHuie and @patmmccann for your guidance. Are the additional CircleCI failures anything we can handle on our end or do you guys have a handle on it?

[ChrisHuie]

@htang555 and @jmayor this looks to be good to go now. Thanks for working with us to get this pr passing :) Merging it now