Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: fix undefined variable in postbid_prebidServer_example.html #7024

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

jsut
Copy link
Contributor

@jsut jsut commented Jun 15, 2021

Type of change

  • Bugfix

Description of change

This is extremely minor, it just makes the example page not blow up if the adapter doesn't bid, which generally only happens if you happen to load the test page on localhost:9999. The bidsBackHandler assumes that sizes is defined in that execution path.

@ChrisHuie ChrisHuie self-requested a review June 15, 2021 11:21
@ChrisHuie ChrisHuie self-assigned this Jun 15, 2021
@ChrisHuie ChrisHuie changed the title Fix undefined variable in postbid_prebidServer_example.html Documentation: fix undefined variable in postbid_prebidServer_example.html Jun 15, 2021
@ChrisHuie ChrisHuie merged commit 9e87c74 into prebid:master Jun 15, 2021
AlvaroBrey pushed a commit to Parrable/Prebid.js that referenced this pull request Jun 17, 2021
* master: (103 commits)
  Opt Out Bid Adapter: add new bid adapter (prebid#7029)
  Dependencies/Testing: update dependencies, npm audit fixes, and bump Browserstack versions (prebid#6828)
  5.2.0-pre
  Prebid.js 5.1.0
  IX Bid Adapter :  reading video `placement` property (prebid#6994)
  changing PBS debug flag to boolean (prebid#7035)
  Ats analytics set sampling rate to 1 percent (prebid#7010)
  Update sspBC bid adapter (v5.0) (prebid#7002)
  Gamma Bid Adapter: support adomain for Prebid 5.0 (prebid#7033)
  Datablocks Bid Adapter : update bid adapter and add 5.0 compliance (prebid#6765)
  Add microadBidAdapter (prebid#7007)
  Adf Bid Adapter: add adform alias (prebid#7009)
  Fixed FPD issue after for Prebid.js 5.0 (prebid#7031)
  Zeta Ssp Bid Adapter: provide devicetype (prebid#7026)
  make sizes a variable as the code expects (prebid#7024)
  VidazooBidAdapter: support for response meta.advertiserDomains (v5.0) (prebid#7022)
  add uid2 to OpenX Bid Adapter (prebid#7015)
  Zeta Ssp Bid Adapter: page and domain fields from config (prebid#7019)
  tappx Bid Adapter: fix wrong requests with undefined params (prebid#7021)
  RealVu Analytics Adapter: remove "tablet" from device types (prebid#7016)
  ...
prebidtappx pushed a commit to prebidtappx/Prebid.js that referenced this pull request Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants