PulsePoint Adapter: Fixing issues related to Prebid 5.0 #6857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter * ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter * ET-1691: cleanup * ET-1691: minor * ET-1691: revert package.json change
ET-1850: Fixing #866
|
Excellent thank you! Can you also change pulsepointBidAdapter.md and any other doc to move the openrtb parameters to the ad unit in your video examples? |
|
Docs updated in |
patmmccann
approved these changes
May 27, 2021
|
It is unclear to me what is happening with circleci tests, but we'll get this merged before the next release. Thanks! |
|
@anand-venkatraman @patmmccann I believe a pr that we reverted on Tuesday is the issue here. Fetch and merging upstream should fix the tests. |
|
I pulled latest upstream changes and tests are passing. |
prebidtappx
pushed a commit
to prebidtappx/Prebid.js
that referenced
this pull request
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This PR addresses the issues that were marked for Prebid 5.0 release, listed below.
#6650
#6512
#6465