PulsePoint Adapter: Removing video params (using them from mediaTypes.video instead) #2993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
bretg
approved these changes
Jun 3, 2021
|
@anand-venkatraman - when did your adapter start looking for mediaTypes.video? You might want to consider leaving the video params option documented here with a note like "use mediaTypes.video for PBJS 5.0 and later" ? |
…ad)" This reverts commit ae0131d.
|
@bretg, that makes sense., I have updated the docs as you have suggested. |
bretg
approved these changes
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to changes made in prebid/Prebid.js#6857