Seedtag Bid Adapter: read video params from mediaTypes, and allow override from bidder params, support passing adomain #6888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patmmccann
changed the title
|
Did you also fix #6650 ? |
|
@patmmccann thx for the reminder, i've made an update to include it in this fix |
patmmccann
changed the title
ChrisHuie
approved these changes
Jun 2, 2021
patmmccann
reviewed
Jun 2, 2021
|
|
||
| return hasVideoMediaType(bid) && !!videoParams.playerSize && | ||
| utils.isArray(videoParams.playerSize) && | ||
| videoParams.playerSize.length > 0; |
There was a problem hiding this comment.
do you want to treat h and w as a substitute for playersize?
| nurl: seedtagBid.nurl | ||
| nurl: seedtagBid.nurl, | ||
| meta: { | ||
| advertiserDomains: seedtagBid && seedtagBid.adomain && seedtagBid.adomain.length > 0 ? seedtagBid.adomain : [] |
There was a problem hiding this comment.
i think should probably be seedtagBid.adomain && seedtagBid.adomain.length > 0 ? seedtagBid.adomain : []
K-JBoon
added a commit
to bluebillywig/Prebid.js
that referenced
this pull request
Jun 3, 2021
* 'master' of github.com:prebid/Prebid.js: (303 commits) BridgewellBidAdapter: modify to include user ids in the bid request object (prebid#6845) GridNMBidAdapter: Use absent in video params data from mediaTypes (prebid#6817) PubMatic: For Video: bid.mediaTypes.video.mimes OR bid.params.video.mimes should be present and must be a non-empty array (prebid#6926) Increment pre version Prebid 4.42.0 Release Seedtag Bid Adapter: read video params from mediaTypes, and allow override from bidder params, support passing adomain (prebid#6888) Medianet bid adapter: MD update for video parameters. (prebid#6922) dgkeyword RTD Provider: add new real time data module (prebid#6912) Smaato bid adapter: Rework multi imp support (prebid#6814) Adot Bid Adapter: add the advertising domains support (prebid#6876) Update Adtelligent, Adtarget, ViewDeos adapters to support adomain (prebid#6917) LockerDome Bid Adapter: support for meta.advertiserDomains (prebid#6921) Sublime Bid Adapter : Add support for meta.advertiserDomains (prebid#6920) Brightcom Bid Adapter: use getFloor function (prebid#6918) AdYouLike Bidder: Handle advertiser domains (prebid#6916) relaido Bid Adapter: Add meta OBJ to BidResponse (prebid#6914) Jixie Bid Adapter: add support for advertiserDomains (prebid#6898) Onomagic Bid Adapter: use getFloor function (prebid#6907) Sharethrough Bid Adapter: Use getFloor module for Prebid 5.0 compliance (prebid#6874) Accept outstream renderers defined in mediatype for PBS (prebid#6896) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Supports video params from adunit and bidder : #6512
Support advertiserDomains : #6650