Tnc id module: initial release #8435
Conversation
# Conflicts: # modules/TNCIDIdSystem.js
| source: 'thenewco.it', | ||
| atype: 3 | ||
| }, | ||
|
|
There was a problem hiding this comment.
you appear to be missing changes to eids.md, user id spec and eids spec
There was a problem hiding this comment.
Not sure why this was resolved without changes
- modules/tncIdSystem.md: spacing fix - added eids.md, user id spec and eids spec
|
@smenzer @patmmccann Can you please re-review this PR? We would like to know if any other changes are necessary. |
|
@smenzer @patmmccann Can you please let us know if code is good to go now? |
|
Hi all, sorry for the pressure, is there any update about this release? We have a big client who's waiting for proceeding with media activities with deep intergration with our TNCID. Thanks for understanding! |
|
Appears to be missing changes to eids spec and userid spec files |
modules/tncIdSystem.js
Outdated
|
|
||
| const loadRemoteScript = (providerId) => { | ||
| return new Promise((resolve) => { | ||
| loadExternalScript('https://js.tncid.app/remote.js?ns=' + FALLBACK_TNC_INSTANCE + '&providerId=' + providerId, MODULE_NAME, resolve); |
There was a problem hiding this comment.
Thank you for converting to load external script, please also do either of the below:
- open source and lock this script to a version
- change its location to a configuration parameter with no default ( but feel free to mention the usual location in an integration example or documentation )
Thanks!!
There was a problem hiding this comment.
Hi,
Thank you for your feedback. We followed your second suggestion and now the script URL is an input parameter configurable by module user.
const loadRemoteScript = () => {
return new Promise((resolve) => {
loadExternalScript(url, MODULE_NAME, resolve);
})
}
We also added missing tests in eids_spec and userid_spec files and update documentation.
Thnak you!
|
@jlukas79 could you take another look? Ty! |
* - TNCID UserID Module * revert * - TNCID UserID Module * - TNCID UserID Module * Converted loadTNCScript to Promise * Added CacheID * - TNCID UserID module * - Documentation updated * - File naming fix * - type fix * -no change * - space removed * new line removed * - lint fix * - eids fix * - .submodules.json: module name moved in alphabetical order - modules/tncIdSystem.md: spacing fix - added eids.md, user id spec and eids spec * - tnc script loaded by loadExternalScript util function * -resolved lint errors * - module name refactoring * - input parameter added to disable load of fallback script * - TNC fallback script is now input param * - Added missing tests Co-authored-by: AzureAD\AnnaVane <anna.vane@thenewco.com> Co-authored-by: micheletnc <michele.milani@thenewco.it>
* - TNCID UserID Module * revert * - TNCID UserID Module * - TNCID UserID Module * Converted loadTNCScript to Promise * Added CacheID * - TNCID UserID module * - Documentation updated * - File naming fix * - type fix * -no change * - space removed * new line removed * - lint fix * - eids fix * - .submodules.json: module name moved in alphabetical order - modules/tncIdSystem.md: spacing fix - added eids.md, user id spec and eids spec * - tnc script loaded by loadExternalScript util function * -resolved lint errors * - module name refactoring * - input parameter added to disable load of fallback script * - TNC fallback script is now input param * - Added missing tests Co-authored-by: AzureAD\AnnaVane <anna.vane@thenewco.com> Co-authored-by: micheletnc <michele.milani@thenewco.it>
Type of change
Description of change
New UserId Module: TNCIDIdSystem
Maintainer contact: anna.vane@thenewco.it