Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added The Newco userId module - TNCID documentation #5703

Merged
merged 10 commits into from
Nov 19, 2024
Merged

Added The Newco userId module - TNCID documentation #5703

merged 10 commits into from
Nov 19, 2024

Conversation

annavane
Copy link
Contributor

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • [ x] text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

  • Related pull requests in prebid.js or server are linked -> Paste link in this list or reference it on the PR itself
  • For new adapters check submitting your adapter docs

@netlify Netlify
Copy link

netlify bot commented Nov 13, 2024 •
edited
Loading

✅ Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit ac23e7b
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/673c54082dbdce0008c66ad6
😎 Deploy Preview https://deploy-preview-5703--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

muuki88
muuki88 requested changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you PR . I assume this relates to prebid/Prebid.js#8435 (which is 2 years ago).

I added a few changes.

dev-docs/modules/userId.md Outdated Show resolved Hide resolved
dev-docs/modules/userid-submodules/tncIdSystem.md Show resolved Hide resolved
annavane and others added 2 commits November 15, 2024 11:43
@annavane @muuki88
Update dev-docs/modules/userid-submodules/tncIdSystem.md
4931f88 
TNCID metadata fields

Co-authored-by: Muki Seiler <muuki88@users.noreply.github.com>
@annavane
> This is not going be necessary thanks to prebid#5673 , which genera…
7b42cb1 
…tes this automatically.
@annavane annavane requested a review from muuki88 November 15, 2024 10:56
@annavane
Copy link
Contributor Author

Hi,
There is still label "need work", is there something else blocking the merge?

Thank you!

@muuki88 muuki88 added LGTM and removed needs work labels Nov 19, 2024
@muuki88 muuki88 merged commit 9598da0 into prebid:master Nov 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muuki88 muuki88 muuki88 approved these changes

Assignees
No one assigned
Labels
LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annavane @muuki88