NextMillennium Bid Adapter: Add ortb and element offsets #8671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JacobKlein26 pulling in recent prs should fix the CircleCi issue 👍 Can you also please add unit testing for this pr? |
….ext.tid) (prebid#8641) * IX Bid Adapter: add imp ext tid support * fix tid level in imp ext object Co-authored-by: shahin.rahbariasl <shahin.rahbariasl@indexexchange.com>
…larify which CPM is being compared with which floor (prebid#8655) * Price floors module: improve logging on bid rejections to clarify which CPM is being compared with which floor * Use full precision in log message
…test. (prebid#8642) * update Adgeneration to add Criteo system and ID5 systems. * Change method name. * Correction_of_code_and_test_specs. * Adding adgext_id5_id_link_type parameter to ID5 object.
…ia/Prebid.js into get-element-clientRect
|
@ChrisHuie Thank you! Thanks :) |
ChrisHuie
approved these changes
Jul 13, 2022
ahmadlob
referenced
this pull request
in taboola/Prebid.js
Jul 27, 2022
* ortb2 and el offsets * return empty object * ortb2 and el offsets * IX Bid Adapter: Add support for impression level transactionId (imp[].ext.tid) (#8641) * IX Bid Adapter: add imp ext tid support * fix tid level in imp ext object Co-authored-by: shahin.rahbariasl <shahin.rahbariasl@indexexchange.com> * PBjs Core Price Floors Module: improve logging on bid rejections to clarify which CPM is being compared with which floor (#8655) * Price floors module: improve logging on bid rejections to clarify which CPM is being compared with which floor * Use full precision in log message * Adgeneration Bid Adpter: add Criteo system and ID5 system and update test. (#8642) * update Adgeneration to add Criteo system and ID5 systems. * Change method name. * Correction_of_code_and_test_specs. * Adding adgext_id5_id_link_type parameter to ID5 object. * return empty object * fix ortb location (not in ext) * add unit testing Co-authored-by: shahinrahbariasl <56240400+shahinrahbariasl@users.noreply.github.com> Co-authored-by: shahin.rahbariasl <shahin.rahbariasl@indexexchange.com> Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> Co-authored-by: Keisuke Kakinuma <keisuke.kakinuma@supership.jp>
RomainLofaso
pushed a commit
to criteo-forks/Prebid.js
that referenced
this pull request
Aug 8, 2022
* ortb2 and el offsets * return empty object * ortb2 and el offsets * IX Bid Adapter: Add support for impression level transactionId (imp[].ext.tid) (prebid#8641) * IX Bid Adapter: add imp ext tid support * fix tid level in imp ext object Co-authored-by: shahin.rahbariasl <shahin.rahbariasl@indexexchange.com> * PBjs Core Price Floors Module: improve logging on bid rejections to clarify which CPM is being compared with which floor (prebid#8655) * Price floors module: improve logging on bid rejections to clarify which CPM is being compared with which floor * Use full precision in log message * Adgeneration Bid Adpter: add Criteo system and ID5 system and update test. (prebid#8642) * update Adgeneration to add Criteo system and ID5 systems. * Change method name. * Correction_of_code_and_test_specs. * Adding adgext_id5_id_link_type parameter to ID5 object. * return empty object * fix ortb location (not in ext) * add unit testing Co-authored-by: shahinrahbariasl <56240400+shahinrahbariasl@users.noreply.github.com> Co-authored-by: shahin.rahbariasl <shahin.rahbariasl@indexexchange.com> Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> Co-authored-by: Keisuke Kakinuma <keisuke.kakinuma@supership.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Added more information to the bid request (bid.ortb2 / Ad Element.getBoundingClientRect)
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information