PBjs Core Price Floors Module: improve logging on bid rejections to clarify which CPM is being compared with which floor #8655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch CPM is being compared with which floor
robertrmartinez
approved these changes
Jul 6, 2022
patmmccann
previously requested changes
Jul 6, 2022
modules/priceFloors.js
Outdated
| logWarn(`${MODULE_NAME}: ${flooredBid.bidderCode}'s Bid Response for ${adUnitCode} was rejected due to floor not met`, bid); | ||
| const floorMsg = (() => { | ||
| try { | ||
| return ` (adjusted cpm: ${bid.floorData.cpmAfterAdjustments.toFixed(2)}, floor: ${floorInfo.matchingFloor.toFixed(2)})` |
There was a problem hiding this comment.
I have a feeling the lack of precision is going to generate more bug reports when the rounded values are equal; how about toFixed(4)?
There was a problem hiding this comment.
how about keeping the full precision then? (because if 2 digits are not enough why would 4 be?)
ChrisHuie
approved these changes
Jul 11, 2022
ChrisHuie
changed the title
JacobKlein26
pushed a commit
to nextmillenniummedia/Prebid.js
that referenced
this pull request
Jul 12, 2022
…larify which CPM is being compared with which floor (prebid#8655) * Price floors module: improve logging on bid rejections to clarify which CPM is being compared with which floor * Use full precision in log message
bwhisp
pushed a commit
to bwhisp/Prebid.js
that referenced
this pull request
Jul 13, 2022
…larify which CPM is being compared with which floor (prebid#8655) * Price floors module: improve logging on bid rejections to clarify which CPM is being compared with which floor * Use full precision in log message
ChrisHuie
pushed a commit
that referenced
this pull request
Jul 13, 2022
* ortb2 and el offsets * return empty object * ortb2 and el offsets * IX Bid Adapter: Add support for impression level transactionId (imp[].ext.tid) (#8641) * IX Bid Adapter: add imp ext tid support * fix tid level in imp ext object Co-authored-by: shahin.rahbariasl <shahin.rahbariasl@indexexchange.com> * PBjs Core Price Floors Module: improve logging on bid rejections to clarify which CPM is being compared with which floor (#8655) * Price floors module: improve logging on bid rejections to clarify which CPM is being compared with which floor * Use full precision in log message * Adgeneration Bid Adpter: add Criteo system and ID5 system and update test. (#8642) * update Adgeneration to add Criteo system and ID5 systems. * Change method name. * Correction_of_code_and_test_specs. * Adding adgext_id5_id_link_type parameter to ID5 object. * return empty object * fix ortb location (not in ext) * add unit testing Co-authored-by: shahinrahbariasl <56240400+shahinrahbariasl@users.noreply.github.com> Co-authored-by: shahin.rahbariasl <shahin.rahbariasl@indexexchange.com> Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> Co-authored-by: Keisuke Kakinuma <keisuke.kakinuma@supership.jp>
ahmadlob
referenced
this pull request
in taboola/Prebid.js
Jul 27, 2022
…larify which CPM is being compared with which floor (#8655) * Price floors module: improve logging on bid rejections to clarify which CPM is being compared with which floor * Use full precision in log message
ahmadlob
referenced
this pull request
in taboola/Prebid.js
Jul 27, 2022
* ortb2 and el offsets * return empty object * ortb2 and el offsets * IX Bid Adapter: Add support for impression level transactionId (imp[].ext.tid) (#8641) * IX Bid Adapter: add imp ext tid support * fix tid level in imp ext object Co-authored-by: shahin.rahbariasl <shahin.rahbariasl@indexexchange.com> * PBjs Core Price Floors Module: improve logging on bid rejections to clarify which CPM is being compared with which floor (#8655) * Price floors module: improve logging on bid rejections to clarify which CPM is being compared with which floor * Use full precision in log message * Adgeneration Bid Adpter: add Criteo system and ID5 system and update test. (#8642) * update Adgeneration to add Criteo system and ID5 systems. * Change method name. * Correction_of_code_and_test_specs. * Adding adgext_id5_id_link_type parameter to ID5 object. * return empty object * fix ortb location (not in ext) * add unit testing Co-authored-by: shahinrahbariasl <56240400+shahinrahbariasl@users.noreply.github.com> Co-authored-by: shahin.rahbariasl <shahin.rahbariasl@indexexchange.com> Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> Co-authored-by: Keisuke Kakinuma <keisuke.kakinuma@supership.jp>
RomainLofaso
pushed a commit
to criteo-forks/Prebid.js
that referenced
this pull request
Aug 8, 2022
…larify which CPM is being compared with which floor (prebid#8655) * Price floors module: improve logging on bid rejections to clarify which CPM is being compared with which floor * Use full precision in log message
RomainLofaso
pushed a commit
to criteo-forks/Prebid.js
that referenced
this pull request
Aug 8, 2022
* ortb2 and el offsets * return empty object * ortb2 and el offsets * IX Bid Adapter: Add support for impression level transactionId (imp[].ext.tid) (prebid#8641) * IX Bid Adapter: add imp ext tid support * fix tid level in imp ext object Co-authored-by: shahin.rahbariasl <shahin.rahbariasl@indexexchange.com> * PBjs Core Price Floors Module: improve logging on bid rejections to clarify which CPM is being compared with which floor (prebid#8655) * Price floors module: improve logging on bid rejections to clarify which CPM is being compared with which floor * Use full precision in log message * Adgeneration Bid Adpter: add Criteo system and ID5 system and update test. (prebid#8642) * update Adgeneration to add Criteo system and ID5 systems. * Change method name. * Correction_of_code_and_test_specs. * Adding adgext_id5_id_link_type parameter to ID5 object. * return empty object * fix ortb location (not in ext) * add unit testing Co-authored-by: shahinrahbariasl <56240400+shahinrahbariasl@users.noreply.github.com> Co-authored-by: shahin.rahbariasl <shahin.rahbariasl@indexexchange.com> Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> Co-authored-by: Keisuke Kakinuma <keisuke.kakinuma@supership.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
When a bid is rejected because below its price floor, the logged bid object shows a
cpmbeforebidCpmAdjustment, but the comparison to the floor may have taken adjustment into account. This can appear as if a valid bid is being rejected (see #8565)This modifies the log message to explicitly show which cpm was found to be below the floor, which should help avoid confusion.