-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kargo Bid Adapter: page URL from topmostLocation #9152
Conversation
@patmmccann curious to get your thoughts on this. I noticed that some bidders use DSPs have requested us passing the full URL including params, so we want to make sure we're using the right Prebid.js property. Is |
@jsadwith, this was changed with version 7, #8450
If it's preferable to always provide a value regardless of its validity, my suggestion is to use |
@dgirardi did 8450 change behavior on query string params being reported? |
I missed that this was about URL params. #8450 did not remove them, but it gives precedence to the canonical URL, which may not have them. |
should we give precedence to topmostlocation if topmostlocation has params and canonical is a substring of topmostlocation? In other words, pass the params unless canonical overrides the host or page |
I don't love that idea because a) it would break canonical URLs that are legitimately just changing the query params and b) it would still lose the query params when the domains are different. I don't have a better suggestion though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@patmmccann @dgirardi just a heads up that this caused an issue with us for a large publisher where the canonical URL maps to the original URL of an article even when reading syndicated versions of the article on other domains. TTD pointed it out to them that they're receiving incorrect domains from multiple bidders where the domain being passed in the bid request doesn't match the URL of the article itself (ie., xyz.com/original-article is syndicated to abc.com/original-article and def.com/original-article, but the canonical URL across all 3 domains is always xyz.com/original-article). Giving preference to canonical URL may not be the best bet in these types of cases. |
@jsadwith sounds like fraudulent inventory to me; ttd shouldnt buy it. Why can't the syndicating pubs fix? |
@patmmccann it's for SEO purposes so the same article isn't listed in search engines for each site that it's syndicated to. The publisher syndicates the article content across their brands but only wants the source site to be listed in search engines. A canonical URL is defined by Google as "the best representative page from a group of duplicate pages", so it's not a matter of being fraudulent and more-so a matter of how the publisher wants their content to be represented in search engines. With regards to this particular publisher, it's a very premium one that TTD will happily buy. |
Type of change
Description of change
Updates to pull page URL from
topmostLocation
with a fallback topage