Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TTD Bid Adapter : use topmost location when available #9282

Closed
wants to merge 1 commit into from

Conversation

gielow
Copy link
Contributor

@gielow gielow commented Nov 24, 2022

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Other information

@gielow
Copy link
Contributor Author

gielow commented Nov 24, 2022

Use topmostlocation when available, or else use page.
Similar change: #9152

@ChrisHuie ChrisHuie changed the title TTD Bid Adapter: Use topmost location when available TTD Bid Adapter : use topmost location when available Nov 28, 2022
@patmmccann
Copy link
Collaborator

Did #9241 solve for you

@gielow
Copy link
Contributor Author

gielow commented Nov 28, 2022

I will add a different test to ttdBidAdapter_spec.js to confirm and update this PR.

@gielow
Copy link
Contributor Author

gielow commented Nov 29, 2022

Did #9241 solve for you

@patmmccann add a regression test that passes with the latest changes.
Created a new PR and will close this one. Thank you.

#9300

@gielow gielow closed this Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants