Add StickyAdsTV Bidder adapter #916

guillaume-sticky · 2017-01-11T17:03:10Z

Type of change

Description of change

Add StickyAdsTV Bidder Adaptor

test parameters for validating bids

{
  bidder: 'stickyadstv',
  params: {
    zoneId : 277225  //only this parameter is mandatory
  }
}

contact email of the adapter’s maintainer : gandouard@freewheel.tv
[x ] official adapter submission

Other information

Contact: gandouard@freewheel.tv

Test page: http://sandbox.stickyadstv.com/qa/prebid.html

mkendall07 · 2017-01-12T13:51:58Z

Please fix test failures.

guillaume-sticky · 2017-01-12T16:00:04Z

Done by merging in master.

protonate · 2017-01-25T14:46:57Z

src/adapters/stickyadstv.js

+
+    var script = "<script type='text/javascript'>"+
+
+    "var vast =  window.top.stickyadstv_cache[\""+placementCode+"\"];"+


Use of window.top will not work when running in a cross domain iframe, which is increasingly more common. Delivery of creatives into a SafeFrame, for example, or when integrating Prebid with an AMP Page.

Indeed, I'll remove it.

Is there a way I can get the context where my script has been loaded before the bid?

When I use "adloader.loadScript" I load a full API that I would need to access again inside the "Ad" (html/javascript loaded if my bid wins) which is loaded inside an iframe.

That is what "window.top" was for.

protonate · 2017-01-25T14:48:32Z

src/adapters/stickyadstv.js

+    var bidObject;
+    if(valid && priceData) {
+      // valid bid response
+      bidObject = bidfactory.createBid(1);


Pass in the bid requested here so the request/response pair can be matched.

How? the documentation says to use "var bidObject = bidfactory.createBid(1);"
see: http://prebid.org/dev-docs/bidder-adaptor.html

OK, seen an example in bidder adaptor AppNexus.js:
bidfactory.createBid(1, bidObj);

You should add it in the documentation, I didn't find an API reference for the bidfactory.
(did I miss it?)

Ah, thanks, created an issue on docs repo:
prebid/prebid.github.io#168

protonate · 2017-01-25T14:48:49Z

src/adapters/stickyadstv.js

+    }
+    else {
+      // invalid bid response
+      bidObject = bidfactory.createBid(2);


Pass in the bid requested here as well.

protonate · 2017-02-01T19:23:39Z

@guillaume-sticky please let us know the status on this, thanks.

guillaume-sticky · 2017-02-02T08:32:58Z

I'm sorry I was quite busy those days.

I'll push the requested modifications soon.

guillaume-sticky · 2017-02-03T16:26:19Z

Updated with requested modifications.

protonate · 2017-02-08T00:19:09Z

This appears to be a video adapter. Please have a look at the docs on video support: http://prebid.org/dev-docs/show-video-with-a-dfp-video-tag.html

This PR can be updated to incorporate the video config as described.

guillaume-sticky · 2017-02-08T08:37:12Z

Can you be more specific on what is needed here ? We don't want to use your video player example as we are already setup our player as we need it.

I guess I have to declare the supported media type video ?
"supportedMediaTypes" : ["video"]

Is that it ?

protonate · 2017-02-08T16:18:27Z

@guillaume-sticky yes and also set the bid.mediaType to "video". This way the adapter will be registered as a video adapter and the bid will be handled as a video bid.

mkendall07 · 2017-02-08T16:43:53Z

@guillaume-sticky
Please hold off on changes for now. You only need to designate bid.mediaType to "video" if the bid returns a VAST response.

This format appears to be in banner video, is that correct?

guillaume-sticky · 2017-02-08T16:47:00Z

Yes it is, we never return a VAST response, we give the html ad in a bid object to be displayed in banner.

So "supportedMediaTypes" : ["video"] will be enough ?

protonate · 2017-02-09T05:03:53Z

@guillaume-sticky This is good as-is, thanks for the contribution!

guillaume-sticky · 2017-03-02T09:22:16Z

Thank you for adding stickyadstv bidder adapter.

I wonder if we should worry about the 20$ CPM cap? As we could see some CPM over 20$ in our video platform.
When I run tests using a price over 20$ everything seems fine.

And if we need to work around this, can we do it from inside the bidder adapter or is the "custom price bucket" something the publisher needs to setup?

…ebid-official-0.19.0 to release/1.14.0 * commit 'b13f7ba7ee8b3c168dc0af7c8bfc94747d017e70': (34 commits) Add changelog entry. Prebid 0.19.0 Release check truthiness of adUnitCode (prebid#990) fixed exception when refreshing individual Ad Units and bidder responds slowly (prebid#989) Stub pixel drop to prevent network request in test (prebid#988) Updating Komoona adapter to support future Prebid requirements (prebid#974) Use stable version of Chrome (prebid#984) Revert to running browser tests in Travis (prebid#983) Fix issue with appnexusAst sending `user` object in the wrong place. (prebid#980) Integrate Browserstack tests into Travis CI build (prebid#839) Add StickyAdsTV Bidder adapter (prebid#916) Stronger xdomain checks (prebid#971) added matomy as an alias for appnexus (prebid#850) Added 152Media Appnexus Alias (prebid#952) OpenX Adapter: Handles fallback ads correctly as a no fill (prebid#39) (prebid#963) Use package dependencies for ES6 Array shims (prebid#962) Make x-domain safe frame example work out of the box (prebid#955) added usersync for adkernel adapter (prebid#951) Rubicon adapter: add a floor variable (prebid#964) Added Lifestreet adapter. (prebid#965) ...

…14.0 to master * commit 'c008f3f531ae3409f4a16bf03470d84e82aead0e': (35 commits) Add adapters in aolPartnersIds.json. Add changelog entry. Prebid 0.19.0 Release check truthiness of adUnitCode (prebid#990) fixed exception when refreshing individual Ad Units and bidder responds slowly (prebid#989) Stub pixel drop to prevent network request in test (prebid#988) Updating Komoona adapter to support future Prebid requirements (prebid#974) Use stable version of Chrome (prebid#984) Revert to running browser tests in Travis (prebid#983) Fix issue with appnexusAst sending `user` object in the wrong place. (prebid#980) Integrate Browserstack tests into Travis CI build (prebid#839) Add StickyAdsTV Bidder adapter (prebid#916) Stronger xdomain checks (prebid#971) added matomy as an alias for appnexus (prebid#850) Added 152Media Appnexus Alias (prebid#952) OpenX Adapter: Handles fallback ads correctly as a no fill (prebid#39) (prebid#963) Use package dependencies for ES6 Array shims (prebid#962) Make x-domain safe frame example work out of the box (prebid#955) added usersync for adkernel adapter (prebid#951) Rubicon adapter: add a floor variable (prebid#964) ...

guillaume-sticky added 9 commits January 5, 2017 10:21

add stickyadsTV bidder adapter

632c8c1

init unit test file

a91ac2d

ad some unit tests

9e2d70e

fix unit test on ad format with parameters

9c92c3e

add some unit tests

7ed68e9

add unit tests on getBid method

88a45ac

add some test cases in unit tests

7d6bf3c

minor fix on component id tag.

affdd67

remove adapters-sticky.json test file

654a473

jaiminpanchal27 added the on deck label Jan 12, 2017

Merge remote-tracking branch 'Prebid/master'

3b0760e

mkendall07 assigned protonate Jan 23, 2017

mkendall07 added the needs review label Jan 23, 2017

mkendall07 added this to the Prebid 0.19.0 milestone Jan 23, 2017

protonate self-requested a review January 25, 2017 14:39

protonate removed the on deck label Jan 25, 2017

protonate suggested changes Jan 25, 2017

View reviewed changes

guillaume-sticky added 2 commits January 26, 2017 16:17

use top most accessible window instead of window.top

8c0f143

Pass in the bid request in the createBid call.

fd877dc

protonate added needs update and removed needs review labels Feb 1, 2017

guillaume-sticky added 4 commits February 3, 2017 16:49

use top most accessible window instead of window.top

09f7348

Merge remote-tracking branch 'Prebid/master'

28a36a6

add unit tests

90264e8

update unit tests

29453af

guillaume-sticky added 2 commits February 3, 2017 17:33

fix unit test.

b664ee1

fix CI build

57c31a1

protonate removed the needs update label Feb 8, 2017

protonate approved these changes Feb 8, 2017

View reviewed changes

protonate merged commit 82fd5a5 into prebid:master Feb 9, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add StickyAdsTV Bidder adapter #916

Add StickyAdsTV Bidder adapter #916

guillaume-sticky commented Jan 11, 2017

mkendall07 commented Jan 12, 2017

guillaume-sticky commented Jan 12, 2017

protonate Jan 25, 2017

guillaume-sticky Jan 26, 2017

guillaume-sticky Feb 2, 2017

protonate Jan 25, 2017

guillaume-sticky Jan 26, 2017

guillaume-sticky Jan 26, 2017

protonate Jan 26, 2017

protonate Jan 25, 2017

protonate commented Feb 1, 2017

guillaume-sticky commented Feb 2, 2017

guillaume-sticky commented Feb 3, 2017

protonate commented Feb 8, 2017

guillaume-sticky commented Feb 8, 2017 •

edited

Loading

protonate commented Feb 8, 2017

mkendall07 commented Feb 8, 2017

guillaume-sticky commented Feb 8, 2017 •

edited

Loading

protonate commented Feb 9, 2017

guillaume-sticky commented Mar 2, 2017 •

edited

Loading


		var script = "<script type='text/javascript'>"+

		"var vast = window.top.stickyadstv_cache[\""+placementCode+"\"];"+

Add StickyAdsTV Bidder adapter #916

Add StickyAdsTV Bidder adapter #916

Conversation

guillaume-sticky commented Jan 11, 2017

Type of change

Description of change

Other information

mkendall07 commented Jan 12, 2017

guillaume-sticky commented Jan 12, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

protonate commented Feb 1, 2017

guillaume-sticky commented Feb 2, 2017

guillaume-sticky commented Feb 3, 2017

protonate commented Feb 8, 2017

guillaume-sticky commented Feb 8, 2017 • edited Loading

protonate commented Feb 8, 2017

mkendall07 commented Feb 8, 2017

guillaume-sticky commented Feb 8, 2017 • edited Loading

protonate commented Feb 9, 2017

guillaume-sticky commented Mar 2, 2017 • edited Loading

guillaume-sticky commented Feb 8, 2017 •

edited

Loading

guillaume-sticky commented Feb 8, 2017 •

edited

Loading

guillaume-sticky commented Mar 2, 2017 •

edited

Loading