Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Lifestreet adapter. #965

Merged
merged 6 commits into from
Feb 7, 2017
Merged

Added Lifestreet adapter. #965

merged 6 commits into from
Feb 7, 2017

Conversation

Lifestreet
Copy link
Contributor

Type of change

  • New bidder adapter

Description of change

  • test parameters for validating bids
{
  bidder: 'lifestreet',
  params: {
    jstag_url: '//ads.lfstmedia.com/getad?site=285071',
    slot: 'slot166704',
    adkey: '78c',
    ad_size: '160x600',
    timeout: 700
  }
}

Other information

@protonate protonate self-requested a review February 1, 2017 19:21
@protonate protonate self-assigned this Feb 1, 2017
jaiminpanchal27
jaiminpanchal27 requested changes Feb 2, 2017
View reviewed changes
Copy link
Collaborator

@jaiminpanchal27 jaiminpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Lifestreet
Getting Bid Response so that is good.
Have left comments. Please check.

src/adapters/lifestreet.js Outdated

function _addSlotBidResponse(placementCode, cpm, ad, width, height) {
let hasResponse = cpm && ad && ad.length > 0;
let bidObject = bidfactory.createBid(hasResponse ? 1 : 2);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add bid request as second param to match request response pair.

src/adapters/lifestreet.js Outdated
if (slotName && !SLOTS_LOAD_MAP[slotName]) {
SLOTS_LOAD_MAP[slotName] = true;
let ad = `<div id="LSM_AD"></div>
<script>window.parent.$$PREBID_GLOBAL$$["` + slotName + `"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

window.parent will not work in safeframe.

@jaiminpanchal27 jaiminpanchal27 added this to the Prebid 0.19.0 milestone Feb 2, 2017
@Lifestreet
Copy link
Contributor Author

Lifestreet commented Feb 2, 2017 •
edited
Loading

Thanks for your comments @jaiminpanchal27 . Please check.

@Lifestreet
Copy link
Contributor Author

Lifestreet commented Feb 3, 2017 •
edited
Loading

Regarding SafeFrame: AFAIK these are not supported in Prebid.js currently. If it's an important issue, could you @jaiminpanchal27 please suggest what is the best way to access $$PREBID_GLOBAL$$ from the creative when it's needed?

@jaiminpanchal27
Copy link
Collaborator

@protonate can you answer this one ?

@protonate
Copy link
Collaborator

SafeFrame support was implemented here: 3ec356f

This is included in Prebid 0.18.0.

Have a look at #955 for an improved example, this PR will merge this release.

@Lifestreet
Copy link
Contributor Author

Lifestreet commented Feb 6, 2017 •
edited
Loading

Thanks @protonate and @jaiminpanchal27
We have added support for SafeFrame. Please check.

@jaiminpanchal27
Copy link
Collaborator

Looks good. Thanks for the changes @Lifestreet

@jaiminpanchal27 jaiminpanchal27 merged commit 522ed99 into prebid:master Feb 7, 2017
@jaiminpanchal27
Copy link
Collaborator

This is merged into master. Please submit a PR to the docs repo to add a file for your adapter to the bidders directory so your adapter's params will appear on the bidders page. Thank you for contributing

@Lifestreet
Copy link
Contributor Author

Thank you. Will do! Could you please let us know if there is anything additional required to be approved for the list of header bidding partners on the download page (http://prebid.org/download.html)?

@aneuway2
Copy link
Contributor

Hi @Lifestreet !
Are all of your parameters required to use the Life Street adaptor?

Thanks!

@Lifestreet
Copy link
Contributor Author

Lifestreet commented Feb 14, 2017 •
edited
Loading

Hi @aneuway2 !
A timeout parameter is optional, but preferable. The rest of parameters are required.

Thank you.

Walexander pushed a commit to MbidIO/Prebid.js that referenced this pull request Mar 6, 2017
@Lifestreet
Added Lifestreet adapter. (prebid#965)
63f6747 
* Added Lifestreet adapter.

* 1. Added bid request as second param to match request response pair.
2. Improvements for window.parent

* Enabled support for SafeFrame

* Added a minor fix for the creative.

* Additional fix for the creative.
mp-12301 pushed a commit to aol/Prebid.js that referenced this pull request Apr 10, 2017
@vzhukovsky
Merge pull request prebid#74 in AOLP_ADS_JS/prebid.js from feature/Pr…
5faf291 
…ebid-official-0.19.0 to release/1.14.0

* commit 'b13f7ba7ee8b3c168dc0af7c8bfc94747d017e70': (34 commits)
  Add changelog entry.
  Prebid 0.19.0 Release
  check truthiness of adUnitCode (prebid#990)
  fixed exception when refreshing individual Ad Units and bidder responds slowly (prebid#989)
  Stub pixel drop to prevent network request in test (prebid#988)
  Updating Komoona adapter to support future Prebid requirements (prebid#974)
  Use stable version of Chrome (prebid#984)
  Revert to running browser tests in Travis (prebid#983)
  Fix issue with appnexusAst sending `user` object in the wrong place. (prebid#980)
  Integrate Browserstack tests into Travis CI build (prebid#839)
  Add StickyAdsTV Bidder adapter (prebid#916)
  Stronger xdomain checks (prebid#971)
  added matomy as an alias for appnexus (prebid#850)
  Added 152Media Appnexus Alias (prebid#952)
  OpenX Adapter: Handles fallback ads correctly as a no fill (prebid#39) (prebid#963)
  Use package dependencies for ES6 Array shims (prebid#962)
  Make x-domain safe frame example work out of the box (prebid#955)
  added usersync for adkernel adapter (prebid#951)
  Rubicon adapter: add a floor variable (prebid#964)
  Added Lifestreet adapter. (prebid#965)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaiminpanchal27 jaiminpanchal27 jaiminpanchal27 approved these changes

@protonate protonate Awaiting requested review from protonate

Assignees

@jaiminpanchal27 jaiminpanchal27

Labels
needs update
Projects
None yet
Milestone
Prebid 0.19.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Lifestreet @jaiminpanchal27 @protonate @aneuway2 @dimalsm