-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix renderers key node on bid request #685
Conversation
Hi @github-lucas-bon ! In the server ticket prebid/prebid-server#2908 the If there are no other conversations or specs about using |
@YuriyVelichkoPI in the ticket you mentioned the structure fixed here is the one that was pushed, here is where exactly it was pushed. The problem is that there was a mismatch between what was decided on PBS and what was implemented on PBM |
Sorry, @github-lucas-bon, but I still do not understand. In the pull request for PBS GO, the path is So if the changes for PBS JAVA assume a different path - What I'm missing here? |
@github-lucas-bon , it looks like I understand my confusion. Everything is fine PBS, and the expected path for both GO and GAVA is Sorry! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
# Conflicts: # PrebidMobile/PrebidMobile-core/src/test/java/org/prebid/mobile/rendering/models/openrtb/bidRequests/PluginRendererListTest.java
This pull request is to solve the following issue:
This pull request intended to insert renderers on the following node path from the bid request:
.ext.prebid.sdk.renderers
But the implementation did not match the expectation as you can see here, so the current state is
.ext.sdk.renderers