-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prebid SDK rendering API protocol #2908
Comments
Here's a proposal for how this could work at a protocol level:
Notes:
|
Thank you for the proposal ! For the point 4/5, we no longer use We can do the modification in the corresponding object if you feel it mandatory tho, we will anyway change the naming for |
@github-maxime-liege - my understanding is that this proposal is still under discussion. It's generally a good idea to give these things a little time. I'll bring it up in the next Prebid Server committee meeting, which is in a week. |
No worries, i can wait on this side, we have a default configuration, but we are flexible according to your decision |
discussed in committee. @SyntaxNode offered to do a review of the proposal here. |
Okay @SyntaxNode, let us know if you have what you need in order to review it. |
The proposal from @bretg looks good. I would like to add stronger symmetry between the request parameters and response meta. If we use |
Ok, proposal updated. Thanks @SyntaxNode |
Thank you for the update, will follow this proposal then ! |
Thanks, this pull request will be updated accordingly |
@SyntaxNode could you clarify more what you expect us to change on the bid response? The current state was
But are you suggesting something like this?
Let me know, thanks! |
Right - @github-lucas-bon - you don't care about how it's represented in the Go code. In the ORTB, our standard is lower case with no separators:
|
@github-lucas-bon - note - changed the case of the meta fields after discussion in committee |
Here's the summary of the PBS work:
Flipping to ready-for-dev. |
Hello @bretg as the pull request is now updated with the output we had here, our stored response Is here the right place to request it?
|
@github-lucas-bon - where is your stored response? Is that in Prebid's test PBS? I guess wherever it is, you would the body of the stored response to something like
|
Please use |
fixed |
Okay, keys from meta were updated in the pull request to camel case. |
Hi @bretg ! In the draft implementation of this feature, we used the
Now we should add the Can we utilize the stored request for this purpose as well, or should we add the |
@YuriyVelichkoPI - you can add the |
fair warning that the PBS teams are backed up right now with privacy efforts, so it may take a while for the central teams to get to this. community input would be welcomed.
|
Implemented in PBS-Go 0.267.0. |
Hey everyone, I noticed that you remove the field Thanks a lot again for you support ! |
@github-maxime-liege - that word didn't appear in this issue until you mentioned it. But I looked over in the android repo issue and see it there. Is it a request field only? i.e. does token exist in the response? |
It could be existing on the response yes |
@github-maxime-liege - what is a token? Are there any concerns about where this value gets sent? |
it is a simple string value that could be filled by the custom renderer with any data that it wants, we could rename it to |
@github-maxime-liege Thank you for the explanation. I like your suggestion to rename to I've edited the most recent comment from to @bretg to rename token to data. |
Effects of this change: fair warning that the PBS teams are backed up right now with privacy efforts, so it may take a while for the central teams to get to this. community input would be welcomed.
|
Thank you for your answer @SyntaxNode, i'll try to get into this to do the corresponding change. Thanks again |
Looks like i don't have rights to push a new branch on this repository |
You're contribution would certainly be welcomed. Most of us fork this repository, create a branch on our fork, and open a pull request from there. Please message me on Prebid Slack if you prefer otherwise. |
Everything is done here, thanks everybody |
Not done on PBS-Java. #8 on Magnite's list. |
resolved with PBS-Java 2.2 |
Hello,
I am part of a task force to implement a new feature on prebid mobile that we call Custom Plugin Renderers, as you can see here. So it requires us to send new fields in the bid request. Implementation/documentation for the prebid adapter is ongoing as well.
So this issue is to ask your validation regarding this change in the bid request json we are submitting in the prebid android sdk repo: prebid/prebid-mobile-android#648
We have these alternatives so far. Can we follow with any of them? Let me know WDYT, please.
*.ext.prebid.data.plugin_renderers
*.ext.data.plugin_renderers
*.ext.plugin_renderers
The text was updated successfully, but these errors were encountered: