move pubmatic to HTTPS, remove macro, add back encoding #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Client was double encoding, fixed here: prebid/Prebid.js#1178 |
bokelley
approved these changes
May 5, 2017
|
Probably worth adding a unit test for usersync, just so we don't break this at some point in the future by accident. |
asweeney86
approved these changes
May 5, 2017
|
Yeah, I can do that |
nealeu
pushed a commit
to GiftConnect/prebid-server
that referenced
this pull request
Feb 12, 2019
nealeu
pushed a commit
to GiftConnect/prebid-server
that referenced
this pull request
Feb 12, 2019
nealeu
added a commit
to GiftConnect/prebid-server
that referenced
this pull request
Feb 12, 2019
nealeu
pushed a commit
to GiftConnect/prebid-server
that referenced
this pull request
Feb 12, 2019
nealeu
added a commit
to GiftConnect/prebid-server
that referenced
this pull request
Feb 12, 2019
…ativeId Also take out potential nil pointer dereferences so that we don't kill the server on omitted data.
hhhjort
pushed a commit
that referenced
this pull request
Feb 19, 2019
* Create placeholder type for Consumable adapter. * Create placeholder type for Consumable parameters. * Create placeholder JSON Schema for Consumable parameters. * Create skeleton implementation of Bidder for ConsumableAdapter. * Add placeholder NewConsumableBidder function. * Add Consumable to adapter map. * Add comment to ExtImpConsumable. * Generate skeleton bid request. * Set User-Agent header. * Set Forwarded and X-Forwarded-For headers. * Set Referer header. * Set Origin header. * Add type representing ad placement. * Add type representing user. * Add type representing Bid Request. * Add placeholder JSON body to request. * Populate Time field of bid request. * Populate more fields of bid request. * Don't panic if request.Site is nil. * #8 Initial partial implmentation of MakeBids * #11 Add initial exemplary test to get things going * #8 Some initial correct-looking impl and test for MakeBids * Partially implement creating placements from impressions. * #4 Add ExtImpConsumable contract class * #6 Add handling of Ext.SiteId and NetworkId * #11 Provide configurable instant time source to allow testing * #6 Add conversion of w,h formats to adtypes in MakeRequests * #8 Implement retrieveAd for ad markup * #4 Update JSON Schema to match prebid.js consumable docs See https://github.com/prebid/prebid.github.io/blob/b7e1f6fbdbdb87b2b8cd283d311e8ddb2264e599/dev-docs/bidders/consumable.md * #16 Add bidder-info/consumable.yaml * #8 Clean up comments in MakeBids * #12 Add params_test.go * #8 MakeBids: Use bid.id=decision.adId and bid.crId=decision.creativeId Also take out potential nil pointer dereferences so that we don't kill the server on omitted data. * #11 Add a JSON test for absent impressionUrl * #9 Implement usersync based on prebid.js adapter code Only question here is what to do with redirect * Make unitName optional * Duplicate networkId,siteId,unitId/Name from first placement to top of request This is to match requests observed on live sites making calls to serverbid. * Add header info to simple-banner.json test scenario * Handle adId as int64 and use for bid.crid. Use internalReq.id for bid.id Note: Need to validate that bid.id can be same on multiple bids (other adapters use rand(1000) and request.id) * #9 Turn buyeruid into azk Cookie header when calling serverbid.com * #17 Extract Consumable endpoint and usersync_url to config with defaults * #9 Update usersync to work based on templates * Add callback URL to usersync for consumable * Remove additional markup from ad markup - just pass Content.Body through * Remove println's that were accidentally committed * Organise import so consumable import is in order * Delete fmt.Printf calls that shouldn't be there * Clarify why VENDOR_ID is a TODO * Move getImp and error check within test for a valid decision
hhhjort
pushed a commit
that referenced
this pull request
Jun 5, 2019
* wip * wip * wip * exploration for sharethrough prebid-server * WIP: updating sharethrough adapter to latest prebid version Co-authored-by: Chris Nguyen <cnguyen@sharethrough.com> * WIP: adding butler params to the request #164291358 Co-authored-by: Josh Becker <jbecker@sharethrough.com> * Manage bid sizes [#164291358] Co-authored-by: Josh Becker <jbecker@sharethrough.com> * Manage GDPR [#164291358] Co-authored-by: Josh Becker <jbecker@sharethrough.com> * Populate prebid-server version if provided [#164291358] Co-authored-by: Josh Becker <jbecker@sharethrough.com> * Refactor gdpr data extraction from request [#164291358] Co-authored-by: Eddy Pechuzal <epechuzal@sharethrough.com> * Add instant play capability [#164291358] Co-authored-by: Eddy Pechuzal <epechuzal@sharethrough.com> * Split in multiple files [#164291358] Co-authored-by: Eddy Pechuzal <epechuzal@sharethrough.com> * Add s2s-win beacon todo? replace server name by server id? [#164291358] Co-authored-by: Eddy Pechuzal <epechuzal@sharethrough.com> * Removing `server` param in s2s-win beacon (will be added in imp req) [#164291358] * Clean up code + enable syncer (#4) [#165257793] * Proper error handling (#6) * Proper error handling [#165745574] * Address review (baby clean up) + catch error that was missed [#165745574] * Implement Unit Tests (#7) * Proper error handling [#165745574] * Address review (baby clean up) + catch error that was missed [#165745574] * Implement unit tests for utils [#165891351] * Add UT for utils + butler [#165891351] Co-authored-by: Michael Duran <mduran@sharethrough.com> * Attempt for testing Bidder interface function implementations [#165891351] Co-authored-by: Michael Duran <mduran@sharethrough.com> * Finalizing Unit tests [#165891351] Co-authored-by: Chris Nguyen <cnguyen@sharethrough.com> Co-authored-by: Josh Becker <jbecker@sharethrough.com> * Fixing sharethrough.yaml capabilities [#165891351] Co-authored-by: Josh Becker <jbecker@sharethrough.com> * Send supplyId to imp req instead of hbSource (#5) [#165477915] * Finalize PR (#8) [#164911891] Co-authored-by: Josh Becker <jbecker@sharethrough.com> * Remove test setting * Add Sharethrough in syncer_test * Update deserializing of third party partners * Refactor/optimize UserAgent parsing (#9) following josephveach's review in #903 * Addressing June 3rd review from #903 Optimizations, clean up suggested by @mansinahar * Addressing June 4th review from #903 (#10) * Addressing June 4th review from #903 Clean up canAutoPlayVideo + hardcode bhVersion to unknown for now... * Removing hbVersion butler param since it's not accessible * Fix adMarkup error handling
mgloystein
added a commit
to spotx/prebid-server
that referenced
this pull request
Jun 14, 2019
* Use the correct labels for cache performance metric (prebid#904) * PubMatic Adslot validation (prebid#886) * testing a few changes to validate adslot, more to follow * Changed AdSlot to optional parameter, modified validation and test cases for the same * removed imp id from adslot validation error msgs * assign banner size * remove TrimSpace where it is not needed as recommended in the review * Implementation of Categories Http fetcher (prebid#882) * Implementation of Categories Http fetcher -Added code to fetch data using http -Added previously loaded categories to run http request just at the first time * Moved common Category struct to stored_request * Added comments * Minor refactoring * Minor refactoring -Added verification if category exist in map * Minor refactoring * Minor refactoring -strings.Replace changed to strings.TrimSuffix * Improved error handling on Beachfront adapter (prebid#873) * Removed a redundant error message that was causing some confusion. * trying to turn '[]' into null and 200 inti 404 * not a goot path * looking at the status codes * I think I have covers all these bases. * checking for empty array response a failing sanely * removed an attempt to pointlessly reset the status code. * corrected and added test cases * Fix Rubicon bidder for multi-format impression processing (prebid#902) * Replace Dockerfile Alpine linux with Ubuntu (prebid#885) * Ubuntu dockerfile works, includes backups and out file * Ubuntu Dockerfile creates image successfully and prebid-server was tested with a sample request. Seems to work fine * Ubuntu 18.04 now builds, validates.sh, and curls sample request successfully * Removed sed command * [fix] broken Go 1.9 compatibility (prebid#910) This CL addresses Go 1.9 compatibility issue along with adding back Go 1.9 to travis testing setup to prevent such bugs. Issue: prebid#895 * Fixed "invalid BidType: " error for lifestreet adapter (prebid#893) * Fixed "invalid BidType: " error for lifestreet adapter * After run gofmt * Used standard bid.ext type to get bid.ext.prebid.type * [Currency support] Activate multi-currencies support (prebid#894) This CL is the last piece to activate currency conversion support in PBS. It activates currency support per default. Currency rates will be fetched once per hour (PrebidJS file is updated once a day). Issue: prebid#280 * ImproveDigital adapter: (prebid#887) - Add support for video - Add support for mobile/app - Add support for multibid responses - Extend optional parameters * Add a PI exemption environment variable to PBS (prebid#916) * Refactored to official name of config item * Changes suggested by Mansi Nahar * [Sharethrough] Add new Sharethrough Adapter (prebid#903) * wip * wip * wip * exploration for sharethrough prebid-server * WIP: updating sharethrough adapter to latest prebid version Co-authored-by: Chris Nguyen <cnguyen@sharethrough.com> * WIP: adding butler params to the request #164291358 Co-authored-by: Josh Becker <jbecker@sharethrough.com> * Manage bid sizes [#164291358] Co-authored-by: Josh Becker <jbecker@sharethrough.com> * Manage GDPR [#164291358] Co-authored-by: Josh Becker <jbecker@sharethrough.com> * Populate prebid-server version if provided [#164291358] Co-authored-by: Josh Becker <jbecker@sharethrough.com> * Refactor gdpr data extraction from request [#164291358] Co-authored-by: Eddy Pechuzal <epechuzal@sharethrough.com> * Add instant play capability [#164291358] Co-authored-by: Eddy Pechuzal <epechuzal@sharethrough.com> * Split in multiple files [#164291358] Co-authored-by: Eddy Pechuzal <epechuzal@sharethrough.com> * Add s2s-win beacon todo? replace server name by server id? [#164291358] Co-authored-by: Eddy Pechuzal <epechuzal@sharethrough.com> * Removing `server` param in s2s-win beacon (will be added in imp req) [#164291358] * Clean up code + enable syncer (prebid#4) [#165257793] * Proper error handling (prebid#6) * Proper error handling [#165745574] * Address review (baby clean up) + catch error that was missed [#165745574] * Implement Unit Tests (prebid#7) * Proper error handling [#165745574] * Address review (baby clean up) + catch error that was missed [#165745574] * Implement unit tests for utils [#165891351] * Add UT for utils + butler [#165891351] Co-authored-by: Michael Duran <mduran@sharethrough.com> * Attempt for testing Bidder interface function implementations [#165891351] Co-authored-by: Michael Duran <mduran@sharethrough.com> * Finalizing Unit tests [#165891351] Co-authored-by: Chris Nguyen <cnguyen@sharethrough.com> Co-authored-by: Josh Becker <jbecker@sharethrough.com> * Fixing sharethrough.yaml capabilities [#165891351] Co-authored-by: Josh Becker <jbecker@sharethrough.com> * Send supplyId to imp req instead of hbSource (prebid#5) [#165477915] * Finalize PR (prebid#8) [#164911891] Co-authored-by: Josh Becker <jbecker@sharethrough.com> * Remove test setting * Add Sharethrough in syncer_test * Update deserializing of third party partners * Refactor/optimize UserAgent parsing (prebid#9) following josephveach's review in prebid#903 * Addressing June 3rd review from prebid#903 Optimizations, clean up suggested by @mansinahar * Addressing June 4th review from prebid#903 (prebid#10) * Addressing June 4th review from prebid#903 Clean up canAutoPlayVideo + hardcode bhVersion to unknown for now... * Removing hbVersion butler param since it's not accessible * Fix adMarkup error handling * [Mgid] Add new Mgid Adapter (prebid#907) * new mgid adapter * increase coverage * remove extra imports * Cache validation fix (prebid#911) * Cache validation fix if no bids returned - don't throw cache error, just return empty result * Cache validation fix - optimization: do not run auction logic if no bids returned * Cache validation fix: minor refactoring * Cache validation fix: minor refactoring * Cache validation fix: added unit test for no bids returned * Cache validation fix: minor refactoring * Remove hard coded targeting keys (prebid#923)
katsuo5
referenced
this pull request
in flux-dev-team/prebid-server-1
Dec 1, 2020
* Create placeholder type for Consumable adapter. * Create placeholder type for Consumable parameters. * Create placeholder JSON Schema for Consumable parameters. * Create skeleton implementation of Bidder for ConsumableAdapter. * Add placeholder NewConsumableBidder function. * Add Consumable to adapter map. * Add comment to ExtImpConsumable. * Generate skeleton bid request. * Set User-Agent header. * Set Forwarded and X-Forwarded-For headers. * Set Referer header. * Set Origin header. * Add type representing ad placement. * Add type representing user. * Add type representing Bid Request. * Add placeholder JSON body to request. * Populate Time field of bid request. * Populate more fields of bid request. * Don't panic if request.Site is nil. * #8 Initial partial implmentation of MakeBids * #11 Add initial exemplary test to get things going * #8 Some initial correct-looking impl and test for MakeBids * Partially implement creating placements from impressions. * #4 Add ExtImpConsumable contract class * #6 Add handling of Ext.SiteId and NetworkId * #11 Provide configurable instant time source to allow testing * #6 Add conversion of w,h formats to adtypes in MakeRequests * #8 Implement retrieveAd for ad markup * #4 Update JSON Schema to match prebid.js consumable docs See https://github.com/prebid/prebid.github.io/blob/b7e1f6fbdbdb87b2b8cd283d311e8ddb2264e599/dev-docs/bidders/consumable.md * #16 Add bidder-info/consumable.yaml * #8 Clean up comments in MakeBids * #12 Add params_test.go * #8 MakeBids: Use bid.id=decision.adId and bid.crId=decision.creativeId Also take out potential nil pointer dereferences so that we don't kill the server on omitted data. * #11 Add a JSON test for absent impressionUrl * #9 Implement usersync based on prebid.js adapter code Only question here is what to do with redirect * Make unitName optional * Duplicate networkId,siteId,unitId/Name from first placement to top of request This is to match requests observed on live sites making calls to serverbid. * Add header info to simple-banner.json test scenario * Handle adId as int64 and use for bid.crid. Use internalReq.id for bid.id Note: Need to validate that bid.id can be same on multiple bids (other adapters use rand(1000) and request.id) * #9 Turn buyeruid into azk Cookie header when calling serverbid.com * #17 Extract Consumable endpoint and usersync_url to config with defaults * #9 Update usersync to work based on templates * Add callback URL to usersync for consumable * Remove additional markup from ad markup - just pass Content.Body through * Remove println's that were accidentally committed * Organise import so consumable import is in order * Delete fmt.Printf calls that shouldn't be there * Clarify why VENDOR_ID is a TODO * Move getImp and error check within test for a valid decision
katsuo5
referenced
this pull request
in flux-dev-team/prebid-server-1
Dec 1, 2020
* wip * wip * wip * exploration for sharethrough prebid-server * WIP: updating sharethrough adapter to latest prebid version Co-authored-by: Chris Nguyen <cnguyen@sharethrough.com> * WIP: adding butler params to the request #164291358 Co-authored-by: Josh Becker <jbecker@sharethrough.com> * Manage bid sizes [#164291358] Co-authored-by: Josh Becker <jbecker@sharethrough.com> * Manage GDPR [#164291358] Co-authored-by: Josh Becker <jbecker@sharethrough.com> * Populate prebid-server version if provided [#164291358] Co-authored-by: Josh Becker <jbecker@sharethrough.com> * Refactor gdpr data extraction from request [#164291358] Co-authored-by: Eddy Pechuzal <epechuzal@sharethrough.com> * Add instant play capability [#164291358] Co-authored-by: Eddy Pechuzal <epechuzal@sharethrough.com> * Split in multiple files [#164291358] Co-authored-by: Eddy Pechuzal <epechuzal@sharethrough.com> * Add s2s-win beacon todo? replace server name by server id? [#164291358] Co-authored-by: Eddy Pechuzal <epechuzal@sharethrough.com> * Removing `server` param in s2s-win beacon (will be added in imp req) [#164291358] * Clean up code + enable syncer (#4) [#165257793] * Proper error handling (#6) * Proper error handling [#165745574] * Address review (baby clean up) + catch error that was missed [#165745574] * Implement Unit Tests (#7) * Proper error handling [#165745574] * Address review (baby clean up) + catch error that was missed [#165745574] * Implement unit tests for utils [#165891351] * Add UT for utils + butler [#165891351] Co-authored-by: Michael Duran <mduran@sharethrough.com> * Attempt for testing Bidder interface function implementations [#165891351] Co-authored-by: Michael Duran <mduran@sharethrough.com> * Finalizing Unit tests [#165891351] Co-authored-by: Chris Nguyen <cnguyen@sharethrough.com> Co-authored-by: Josh Becker <jbecker@sharethrough.com> * Fixing sharethrough.yaml capabilities [#165891351] Co-authored-by: Josh Becker <jbecker@sharethrough.com> * Send supplyId to imp req instead of hbSource (#5) [#165477915] * Finalize PR (#8) [#164911891] Co-authored-by: Josh Becker <jbecker@sharethrough.com> * Remove test setting * Add Sharethrough in syncer_test * Update deserializing of third party partners * Refactor/optimize UserAgent parsing (#9) following josephveach's review in prebid#903 * Addressing June 3rd review from prebid#903 Optimizations, clean up suggested by @mansinahar * Addressing June 4th review from prebid#903 (#10) * Addressing June 4th review from prebid#903 Clean up canAutoPlayVideo + hardcode bhVersion to unknown for now... * Removing hbVersion butler param since it's not accessible * Fix adMarkup error handling
katsuo5
referenced
this pull request
in flux-dev-team/prebid-server-1
Dec 2, 2020
* Create placeholder type for Consumable adapter. * Create placeholder type for Consumable parameters. * Create placeholder JSON Schema for Consumable parameters. * Create skeleton implementation of Bidder for ConsumableAdapter. * Add placeholder NewConsumableBidder function. * Add Consumable to adapter map. * Add comment to ExtImpConsumable. * Generate skeleton bid request. * Set User-Agent header. * Set Forwarded and X-Forwarded-For headers. * Set Referer header. * Set Origin header. * Add type representing ad placement. * Add type representing user. * Add type representing Bid Request. * Add placeholder JSON body to request. * Populate Time field of bid request. * Populate more fields of bid request. * Don't panic if request.Site is nil. * #8 Initial partial implmentation of MakeBids * #11 Add initial exemplary test to get things going * #8 Some initial correct-looking impl and test for MakeBids * Partially implement creating placements from impressions. * #4 Add ExtImpConsumable contract class * #6 Add handling of Ext.SiteId and NetworkId * #11 Provide configurable instant time source to allow testing * #6 Add conversion of w,h formats to adtypes in MakeRequests * #8 Implement retrieveAd for ad markup * #4 Update JSON Schema to match prebid.js consumable docs See https://github.com/prebid/prebid.github.io/blob/b7e1f6fbdbdb87b2b8cd283d311e8ddb2264e599/dev-docs/bidders/consumable.md * #16 Add bidder-info/consumable.yaml * #8 Clean up comments in MakeBids * #12 Add params_test.go * #8 MakeBids: Use bid.id=decision.adId and bid.crId=decision.creativeId Also take out potential nil pointer dereferences so that we don't kill the server on omitted data. * #11 Add a JSON test for absent impressionUrl * #9 Implement usersync based on prebid.js adapter code Only question here is what to do with redirect * Make unitName optional * Duplicate networkId,siteId,unitId/Name from first placement to top of request This is to match requests observed on live sites making calls to serverbid. * Add header info to simple-banner.json test scenario * Handle adId as int64 and use for bid.crid. Use internalReq.id for bid.id Note: Need to validate that bid.id can be same on multiple bids (other adapters use rand(1000) and request.id) * #9 Turn buyeruid into azk Cookie header when calling serverbid.com * #17 Extract Consumable endpoint and usersync_url to config with defaults * #9 Update usersync to work based on templates * Add callback URL to usersync for consumable * Remove additional markup from ad markup - just pass Content.Body through * Remove println's that were accidentally committed * Organise import so consumable import is in order * Delete fmt.Printf calls that shouldn't be there * Clarify why VENDOR_ID is a TODO * Move getImp and error check within test for a valid decision
katsuo5
referenced
this pull request
in flux-dev-team/prebid-server-1
Dec 2, 2020
* wip * wip * wip * exploration for sharethrough prebid-server * WIP: updating sharethrough adapter to latest prebid version Co-authored-by: Chris Nguyen <cnguyen@sharethrough.com> * WIP: adding butler params to the request #164291358 Co-authored-by: Josh Becker <jbecker@sharethrough.com> * Manage bid sizes [#164291358] Co-authored-by: Josh Becker <jbecker@sharethrough.com> * Manage GDPR [#164291358] Co-authored-by: Josh Becker <jbecker@sharethrough.com> * Populate prebid-server version if provided [#164291358] Co-authored-by: Josh Becker <jbecker@sharethrough.com> * Refactor gdpr data extraction from request [#164291358] Co-authored-by: Eddy Pechuzal <epechuzal@sharethrough.com> * Add instant play capability [#164291358] Co-authored-by: Eddy Pechuzal <epechuzal@sharethrough.com> * Split in multiple files [#164291358] Co-authored-by: Eddy Pechuzal <epechuzal@sharethrough.com> * Add s2s-win beacon todo? replace server name by server id? [#164291358] Co-authored-by: Eddy Pechuzal <epechuzal@sharethrough.com> * Removing `server` param in s2s-win beacon (will be added in imp req) [#164291358] * Clean up code + enable syncer (#4) [#165257793] * Proper error handling (#6) * Proper error handling [#165745574] * Address review (baby clean up) + catch error that was missed [#165745574] * Implement Unit Tests (#7) * Proper error handling [#165745574] * Address review (baby clean up) + catch error that was missed [#165745574] * Implement unit tests for utils [#165891351] * Add UT for utils + butler [#165891351] Co-authored-by: Michael Duran <mduran@sharethrough.com> * Attempt for testing Bidder interface function implementations [#165891351] Co-authored-by: Michael Duran <mduran@sharethrough.com> * Finalizing Unit tests [#165891351] Co-authored-by: Chris Nguyen <cnguyen@sharethrough.com> Co-authored-by: Josh Becker <jbecker@sharethrough.com> * Fixing sharethrough.yaml capabilities [#165891351] Co-authored-by: Josh Becker <jbecker@sharethrough.com> * Send supplyId to imp req instead of hbSource (#5) [#165477915] * Finalize PR (#8) [#164911891] Co-authored-by: Josh Becker <jbecker@sharethrough.com> * Remove test setting * Add Sharethrough in syncer_test * Update deserializing of third party partners * Refactor/optimize UserAgent parsing (#9) following josephveach's review in prebid#903 * Addressing June 3rd review from prebid#903 Optimizations, clean up suggested by @mansinahar * Addressing June 4th review from prebid#903 (#10) * Addressing June 4th review from prebid#903 Clean up canAutoPlayVideo + hardcode bhVersion to unknown for now... * Removing hbVersion butler param since it's not accessible * Fix adMarkup error handling
katsuo5
referenced
this pull request
in flux-dev-team/prebid-server-1
Dec 4, 2020
* Create placeholder type for Consumable adapter. * Create placeholder type for Consumable parameters. * Create placeholder JSON Schema for Consumable parameters. * Create skeleton implementation of Bidder for ConsumableAdapter. * Add placeholder NewConsumableBidder function. * Add Consumable to adapter map. * Add comment to ExtImpConsumable. * Generate skeleton bid request. * Set User-Agent header. * Set Forwarded and X-Forwarded-For headers. * Set Referer header. * Set Origin header. * Add type representing ad placement. * Add type representing user. * Add type representing Bid Request. * Add placeholder JSON body to request. * Populate Time field of bid request. * Populate more fields of bid request. * Don't panic if request.Site is nil. * #8 Initial partial implmentation of MakeBids * #11 Add initial exemplary test to get things going * #8 Some initial correct-looking impl and test for MakeBids * Partially implement creating placements from impressions. * #4 Add ExtImpConsumable contract class * #6 Add handling of Ext.SiteId and NetworkId * #11 Provide configurable instant time source to allow testing * #6 Add conversion of w,h formats to adtypes in MakeRequests * #8 Implement retrieveAd for ad markup * #4 Update JSON Schema to match prebid.js consumable docs See https://github.com/prebid/prebid.github.io/blob/b7e1f6fbdbdb87b2b8cd283d311e8ddb2264e599/dev-docs/bidders/consumable.md * #16 Add bidder-info/consumable.yaml * #8 Clean up comments in MakeBids * #12 Add params_test.go * #8 MakeBids: Use bid.id=decision.adId and bid.crId=decision.creativeId Also take out potential nil pointer dereferences so that we don't kill the server on omitted data. * #11 Add a JSON test for absent impressionUrl * #9 Implement usersync based on prebid.js adapter code Only question here is what to do with redirect * Make unitName optional * Duplicate networkId,siteId,unitId/Name from first placement to top of request This is to match requests observed on live sites making calls to serverbid. * Add header info to simple-banner.json test scenario * Handle adId as int64 and use for bid.crid. Use internalReq.id for bid.id Note: Need to validate that bid.id can be same on multiple bids (other adapters use rand(1000) and request.id) * #9 Turn buyeruid into azk Cookie header when calling serverbid.com * #17 Extract Consumable endpoint and usersync_url to config with defaults * #9 Update usersync to work based on templates * Add callback URL to usersync for consumable * Remove additional markup from ad markup - just pass Content.Body through * Remove println's that were accidentally committed * Organise import so consumable import is in order * Delete fmt.Printf calls that shouldn't be there * Clarify why VENDOR_ID is a TODO * Move getImp and error check within test for a valid decision
katsuo5
referenced
this pull request
in flux-dev-team/prebid-server-1
Dec 4, 2020
* wip * wip * wip * exploration for sharethrough prebid-server * WIP: updating sharethrough adapter to latest prebid version Co-authored-by: Chris Nguyen <cnguyen@sharethrough.com> * WIP: adding butler params to the request #164291358 Co-authored-by: Josh Becker <jbecker@sharethrough.com> * Manage bid sizes [#164291358] Co-authored-by: Josh Becker <jbecker@sharethrough.com> * Manage GDPR [#164291358] Co-authored-by: Josh Becker <jbecker@sharethrough.com> * Populate prebid-server version if provided [#164291358] Co-authored-by: Josh Becker <jbecker@sharethrough.com> * Refactor gdpr data extraction from request [#164291358] Co-authored-by: Eddy Pechuzal <epechuzal@sharethrough.com> * Add instant play capability [#164291358] Co-authored-by: Eddy Pechuzal <epechuzal@sharethrough.com> * Split in multiple files [#164291358] Co-authored-by: Eddy Pechuzal <epechuzal@sharethrough.com> * Add s2s-win beacon todo? replace server name by server id? [#164291358] Co-authored-by: Eddy Pechuzal <epechuzal@sharethrough.com> * Removing `server` param in s2s-win beacon (will be added in imp req) [#164291358] * Clean up code + enable syncer (#4) [#165257793] * Proper error handling (#6) * Proper error handling [#165745574] * Address review (baby clean up) + catch error that was missed [#165745574] * Implement Unit Tests (#7) * Proper error handling [#165745574] * Address review (baby clean up) + catch error that was missed [#165745574] * Implement unit tests for utils [#165891351] * Add UT for utils + butler [#165891351] Co-authored-by: Michael Duran <mduran@sharethrough.com> * Attempt for testing Bidder interface function implementations [#165891351] Co-authored-by: Michael Duran <mduran@sharethrough.com> * Finalizing Unit tests [#165891351] Co-authored-by: Chris Nguyen <cnguyen@sharethrough.com> Co-authored-by: Josh Becker <jbecker@sharethrough.com> * Fixing sharethrough.yaml capabilities [#165891351] Co-authored-by: Josh Becker <jbecker@sharethrough.com> * Send supplyId to imp req instead of hbSource (#5) [#165477915] * Finalize PR (#8) [#164911891] Co-authored-by: Josh Becker <jbecker@sharethrough.com> * Remove test setting * Add Sharethrough in syncer_test * Update deserializing of third party partners * Refactor/optimize UserAgent parsing (#9) following josephveach's review in prebid#903 * Addressing June 3rd review from prebid#903 Optimizations, clean up suggested by @mansinahar * Addressing June 4th review from prebid#903 (#10) * Addressing June 4th review from prebid#903 Clean up canAutoPlayVideo + hardcode bhVersion to unknown for now... * Removing hbVersion butler param since it's not accessible * Fix adMarkup error handling
pm-nilesh-chate
pushed a commit
to pm-nilesh-chate/prebid-server
that referenced
this pull request
Feb 25, 2023
UOE-3793 Add a new request specific object to bid request extension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.