Remove hard coded targeting keys #923

mansinahar · 2019-05-29T21:03:21Z

This is a clean up PR that:

Removes hardcoded targeting keys
Removes targeting key constants defined in multiple places
Rename VideoTargeting struct fields to adhere to GoLang naming convention

guscarreon · 2019-05-30T19:00:25Z

endpoints/auction.go

@@ -34,11 +34,6 @@ type bidResult struct {
 const defaultPriceGranularity = "med"

 // Constant keys for ad server targeting for responses to Prebid Mobile


Can we also remove this comment?

Good catch. Thanks! I will remove that

endpoints/auction.go

guscarreon · 2019-05-30T19:24:38Z

Aside from a couple of comments, LGTM

guscarreon

LGTM Mansi

josephveach · 2019-06-05T20:26:55Z

openrtb_ext/bid_response_video.go

-	Hb_cache_id   string `json:"hb_cache_id"`
+	HbPb       string `json:"hb_pb"`
+	HbPbCatDur string `json:"hb_pb_cat_dur"`
+	HbCacheId  string `json:"hb_cache_id"`


In view of the earlier discussion of GoLint, why HbCacheId instead of HbCacheID?

Related to this, I see other "Id" instances in the above code (minimally, HbDealIdConstantKey). Are they outside the scope of what's being addressed here?

That should be HbCacheID. My bad!

And about the "Id" instances, there are a lot of violations of those and other GoLint issues in our code which we should address. We will probably not be able to address all of them in one PR but I agree, refactoring those targeting keys in openrtb_ext/bid.go should be minimal and can probably be done as part of this PR. Thanks for the catch Joe. I will update the PR

hhhjort · 2019-06-07T14:11:31Z

exchange/auction.go

@@ -73,11 +73,11 @@ func (a *auction) doCache(ctx context.Context, cache prebid_cache_client.Client,
 	toCache := make([]prebid_cache_client.Cacheable, 0, expectNumBids+expectNumVast)
 	expByImp := make(map[string]int64)
 	competitiveExclusion := false
-	var hbCacheID string
+	var HbCacheID string


Why capitalize HbCacheID? Normally that would indicate that HbCacheID is being exported, but that is not possible in this scope.

Ah! Good catch @hhhjort. This wasn't on purpose but an effect of rename all :p I will change it back. Thanks for pointing it out.

guscarreon

LGTM

@mansinahar

* Use the correct labels for cache performance metric (prebid#904) * PubMatic Adslot validation (prebid#886) * testing a few changes to validate adslot, more to follow * Changed AdSlot to optional parameter, modified validation and test cases for the same * removed imp id from adslot validation error msgs * assign banner size * remove TrimSpace where it is not needed as recommended in the review * Implementation of Categories Http fetcher (prebid#882) * Implementation of Categories Http fetcher -Added code to fetch data using http -Added previously loaded categories to run http request just at the first time * Moved common Category struct to stored_request * Added comments * Minor refactoring * Minor refactoring -Added verification if category exist in map * Minor refactoring * Minor refactoring -strings.Replace changed to strings.TrimSuffix * Improved error handling on Beachfront adapter (prebid#873) * Removed a redundant error message that was causing some confusion. * trying to turn '[]' into null and 200 inti 404 * not a goot path * looking at the status codes * I think I have covers all these bases. * checking for empty array response a failing sanely * removed an attempt to pointlessly reset the status code. * corrected and added test cases * Fix Rubicon bidder for multi-format impression processing (prebid#902) * Replace Dockerfile Alpine linux with Ubuntu (prebid#885) * Ubuntu dockerfile works, includes backups and out file * Ubuntu Dockerfile creates image successfully and prebid-server was tested with a sample request. Seems to work fine * Ubuntu 18.04 now builds, validates.sh, and curls sample request successfully * Removed sed command * [fix] broken Go 1.9 compatibility (prebid#910) This CL addresses Go 1.9 compatibility issue along with adding back Go 1.9 to travis testing setup to prevent such bugs. Issue: prebid#895 * Fixed "invalid BidType: " error for lifestreet adapter (prebid#893) * Fixed "invalid BidType: " error for lifestreet adapter * After run gofmt * Used standard bid.ext type to get bid.ext.prebid.type * [Currency support] Activate multi-currencies support (prebid#894) This CL is the last piece to activate currency conversion support in PBS. It activates currency support per default. Currency rates will be fetched once per hour (PrebidJS file is updated once a day). Issue: prebid#280 * ImproveDigital adapter: (prebid#887) - Add support for video - Add support for mobile/app - Add support for multibid responses - Extend optional parameters * Add a PI exemption environment variable to PBS (prebid#916) * Refactored to official name of config item * Changes suggested by Mansi Nahar * [Sharethrough] Add new Sharethrough Adapter (prebid#903) * wip * wip * wip * exploration for sharethrough prebid-server * WIP: updating sharethrough adapter to latest prebid version Co-authored-by: Chris Nguyen <cnguyen@sharethrough.com> * WIP: adding butler params to the request #164291358 Co-authored-by: Josh Becker <jbecker@sharethrough.com> * Manage bid sizes [#164291358] Co-authored-by: Josh Becker <jbecker@sharethrough.com> * Manage GDPR [#164291358] Co-authored-by: Josh Becker <jbecker@sharethrough.com> * Populate prebid-server version if provided [#164291358] Co-authored-by: Josh Becker <jbecker@sharethrough.com> * Refactor gdpr data extraction from request [#164291358] Co-authored-by: Eddy Pechuzal <epechuzal@sharethrough.com> * Add instant play capability [#164291358] Co-authored-by: Eddy Pechuzal <epechuzal@sharethrough.com> * Split in multiple files [#164291358] Co-authored-by: Eddy Pechuzal <epechuzal@sharethrough.com> * Add s2s-win beacon todo? replace server name by server id? [#164291358] Co-authored-by: Eddy Pechuzal <epechuzal@sharethrough.com> * Removing `server` param in s2s-win beacon (will be added in imp req) [#164291358] * Clean up code + enable syncer (prebid#4) [#165257793] * Proper error handling (prebid#6) * Proper error handling [#165745574] * Address review (baby clean up) + catch error that was missed [#165745574] * Implement Unit Tests (prebid#7) * Proper error handling [#165745574] * Address review (baby clean up) + catch error that was missed [#165745574] * Implement unit tests for utils [#165891351] * Add UT for utils + butler [#165891351] Co-authored-by: Michael Duran <mduran@sharethrough.com> * Attempt for testing Bidder interface function implementations [#165891351] Co-authored-by: Michael Duran <mduran@sharethrough.com> * Finalizing Unit tests [#165891351] Co-authored-by: Chris Nguyen <cnguyen@sharethrough.com> Co-authored-by: Josh Becker <jbecker@sharethrough.com> * Fixing sharethrough.yaml capabilities [#165891351] Co-authored-by: Josh Becker <jbecker@sharethrough.com> * Send supplyId to imp req instead of hbSource (prebid#5) [#165477915] * Finalize PR (prebid#8) [#164911891] Co-authored-by: Josh Becker <jbecker@sharethrough.com> * Remove test setting * Add Sharethrough in syncer_test * Update deserializing of third party partners * Refactor/optimize UserAgent parsing (prebid#9) following josephveach's review in prebid#903 * Addressing June 3rd review from prebid#903 Optimizations, clean up suggested by @mansinahar * Addressing June 4th review from prebid#903 (prebid#10) * Addressing June 4th review from prebid#903 Clean up canAutoPlayVideo + hardcode bhVersion to unknown for now... * Removing hbVersion butler param since it's not accessible * Fix adMarkup error handling * [Mgid] Add new Mgid Adapter (prebid#907) * new mgid adapter * increase coverage * remove extra imports * Cache validation fix (prebid#911) * Cache validation fix if no bids returned - don't throw cache error, just return empty result * Cache validation fix - optimization: do not run auction logic if no bids returned * Cache validation fix: minor refactoring * Cache validation fix: minor refactoring * Cache validation fix: added unit test for no bids returned * Cache validation fix: minor refactoring * Remove hard coded targeting keys (prebid#923)

Remove hard coded targeting keys

9d146ba

mansinahar requested review from hhhjort, josephveach, mkendall07 and guscarreon May 29, 2019 21:20

guscarreon reviewed May 30, 2019

View reviewed changes

endpoints/auction.go Outdated Show resolved Hide resolved

Remove leftover comment about targeting constants

7245c50

guscarreon previously approved these changes May 31, 2019

View reviewed changes

josephveach reviewed Jun 5, 2019

View reviewed changes

Replace Id with ID in targeting keys variable names

8499c00

mansinahar dismissed guscarreon’s stale review via 8499c00 June 6, 2019 17:19

hhhjort reviewed Jun 7, 2019

View reviewed changes

hhhjort assigned guscarreon, hhhjort and josephveach Jun 7, 2019

Unexport mistakenly exported hbCacheID variable

f44be2a

josephveach approved these changes Jun 10, 2019

View reviewed changes

guscarreon approved these changes Jun 10, 2019

View reviewed changes

mansinahar merged commit f1894cb into prebid:master Jun 10, 2019

katsuo5 pushed a commit to flux-dev-team/prebid-server-1 that referenced this pull request Dec 1, 2020

Remove hard coded targeting keys (prebid#923)

b28f10a

katsuo5 pushed a commit to flux-dev-team/prebid-server-1 that referenced this pull request Dec 2, 2020

Remove hard coded targeting keys (prebid#923)

e1ce5ea

katsuo5 pushed a commit to flux-dev-team/prebid-server-1 that referenced this pull request Dec 4, 2020

Remove hard coded targeting keys (prebid#923)

614abcb

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove hard coded targeting keys #923

Remove hard coded targeting keys #923

mansinahar commented May 29, 2019

guscarreon May 30, 2019

mansinahar May 31, 2019

mansinahar May 31, 2019

guscarreon commented May 30, 2019

guscarreon left a comment

josephveach Jun 5, 2019

mansinahar Jun 5, 2019

hhhjort Jun 7, 2019

mansinahar Jun 10, 2019

mansinahar Jun 10, 2019

guscarreon left a comment

		@@ -34,11 +34,6 @@ type bidResult struct {
		const defaultPriceGranularity = "med"

		// Constant keys for ad server targeting for responses to Prebid Mobile

Remove hard coded targeting keys #923

Remove hard coded targeting keys #923

Conversation

mansinahar commented May 29, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

guscarreon commented May 30, 2019

guscarreon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

guscarreon left a comment

Choose a reason for hiding this comment