Add data field for custom renderers #3059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-maxime-liege
force-pushed
the
add_data_field_custom_renderers
branch
from
abba3b4 to
83db0ba
Compare
SyntaxNode
approved these changes
Aug 31, 2023
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the proposal for the SDK Rendering API protocol
This PR adds a new field
datato renderers object as discussed in the related threadI switched to a more complex data type
raw objectinstead ofstringto allow passing more datas into it.Then all data related to the renderer SDK could be passed through this field.
Here is an example of how it could go:
{ "name": "myRenderer", "version": "2.4", "data": { "uiRendereringVersion": "1.2", "resizable": true } }