AppNexus: reform bid floor handling (#1261)

prebid · Aug 10, 2021 · 93209ed · 93209ed
1 parent bd7feaa
commit 93209ed
Show file tree

Hide file tree

Showing 2 changed files with 68 additions and 1 deletion.
diff --git a/src/main/java/org/prebid/server/bidder/appnexus/AppnexusBidder.java b/src/main/java/org/prebid/server/bidder/appnexus/AppnexusBidder.java
@@ -312,7 +312,7 @@ private ImpWithMemberId makeImpWithMemberId(Imp imp, String defaultDisplayManage
         }
 
         final BigDecimal reserve = appnexusExt.getReserve();
-        if (reserve != null && reserve.compareTo(BigDecimal.ZERO) > 0) {
+        if (!bidFloorIsValid(imp.getBidfloor()) && bidFloorIsValid(reserve)) {
             impBuilder.bidfloor(reserve); // This will be broken for non-USD currency.
         }
 
@@ -324,6 +324,10 @@ private ImpWithMemberId makeImpWithMemberId(Imp imp, String defaultDisplayManage
         return ImpWithMemberId.of(impBuilder.build(), appnexusExt.getMember());
     }
 
+    private static boolean bidFloorIsValid(BigDecimal bidFloor) {
+        return bidFloor != null && bidFloor.compareTo(BigDecimal.ZERO) > 0;
+    }
+
     private static AppnexusImpExt makeAppnexusImpExt(ExtImpAppnexus appnexusExt) {
         return AppnexusImpExt.of(
                 AppnexusImpExtAppnexus.of(appnexusExt.getPlacementId(), makeKeywords(appnexusExt.getKeywords()),

diff --git a/src/test/java/org/prebid/server/bidder/appnexus/AppnexusBidderTest.java b/src/test/java/org/prebid/server/bidder/appnexus/AppnexusBidderTest.java
@@ -482,6 +482,69 @@ public void makeHttpRequestsShouldSetImpTagidAndImpBidFloorIfExtImpAppnexusHasIn
                         .build()));
     }
 
+    @Test
+    public void makeHttpRequestsShouldSetReserveIfImpBidFloorIsNotSet() {
+        // given
+        final BidRequest bidRequest = givenBidRequest(
+                identity(),
+                identity(),
+                extImpAppnexusBuilder -> extImpAppnexusBuilder
+                        .placementId(20)
+                        .reserve(BigDecimal.valueOf(123)));
+
+        // when
+        final Result<List<HttpRequest<BidRequest>>> result = appnexusBidder.makeHttpRequests(bidRequest);
+
+        // then
+        assertThat(result.getValue()).hasSize(1)
+                .extracting(HttpRequest::getPayload)
+                .flatExtracting(BidRequest::getImp)
+                .extracting(Imp::getBidfloor)
+                .containsExactly(BigDecimal.valueOf(123));
+    }
+
+    @Test
+    public void makeHttpRequestsShouldSetReserveIfImpBidFloorIsZero() {
+        // given
+        final BidRequest bidRequest = givenBidRequest(
+                identity(),
+                impBuilder -> impBuilder.bidfloor(BigDecimal.ZERO),
+                extImpAppnexusBuilder -> extImpAppnexusBuilder
+                        .placementId(20)
+                        .reserve(BigDecimal.valueOf(123)));
+
+        // when
+        final Result<List<HttpRequest<BidRequest>>> result = appnexusBidder.makeHttpRequests(bidRequest);
+
+        // then
+        assertThat(result.getValue()).hasSize(1)
+                .extracting(HttpRequest::getPayload)
+                .flatExtracting(BidRequest::getImp)
+                .extracting(Imp::getBidfloor)
+                .containsExactly(BigDecimal.valueOf(123));
+    }
+
+    @Test
+    public void makeHttpRequestsShouldSetReserveIfImpBidFloorIsNegative() {
+        // given
+        final BidRequest bidRequest = givenBidRequest(
+                identity(),
+                impBuilder -> impBuilder.bidfloor(BigDecimal.ZERO.subtract(BigDecimal.ONE)),
+                extImpAppnexusBuilder -> extImpAppnexusBuilder
+                        .placementId(20)
+                        .reserve(BigDecimal.valueOf(123)));
+
+        // when
+        final Result<List<HttpRequest<BidRequest>>> result = appnexusBidder.makeHttpRequests(bidRequest);
+
+        // then
+        assertThat(result.getValue()).hasSize(1)
+                .extracting(HttpRequest::getPayload)
+                .flatExtracting(BidRequest::getImp)
+                .extracting(Imp::getBidfloor)
+                .containsExactly(BigDecimal.valueOf(123));
+    }
+
     @Test
     public void makeHttpRequestsShouldSetNativeIfRequestImpIsNative() {
         // given