AppNexus: reform bid floor handling #1261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SerhiiNahornyi
suggested changes
May 12, 2021
| @@ -312,7 +312,7 @@ private ImpWithMemberId makeImpWithMemberId(Imp imp, String defaultDisplayManage | |||
| } | |||
|
|
|||
| final BigDecimal reserve = appnexusExt.getReserve(); | |||
| if (reserve != null && reserve.compareTo(BigDecimal.ZERO) > 0) { | |||
| if (bidFloorIsInvalid(imp.getBidfloor()) && reserve != null && reserve.compareTo(BigDecimal.ZERO) > 0) { | |||
There was a problem hiding this comment.
Can we create something like isValidBidfloor and then use it both for imp.getBidfloor() and reserve?
Comment on lines
328
to
331
| if (bidfloor == null) { | ||
| return true; | ||
| } | ||
| return bidfloor.compareTo(BigDecimal.ZERO) < 0 || bidfloor.compareTo(BigDecimal.ZERO) == 0; |
RodionOrets
force-pushed
the
reform-appnexus-bidfloor-handling
branch
from
93f304f to
843eccb
Compare
SerhiiNahornyi
approved these changes
May 12, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 9, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prebid/prebid-server#1814