-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Events support in bid responses #1597
Commits on Dec 1, 2020
-
Initial implementation - cache wurl, cache vast rewrite, bid.ext.preb…
…id.events Missing timestamp (waiting for prebid#1584)
Configuration menu - View commit details
-
Copy full SHA for 57bb6f1 - Browse repository at this point
Copy the full SHA 57bb6f1View commit details -
Cache unit tests, some test refactoring.
- wurl insertion in cached bids - vast modifying in video bids
Configuration menu - View commit details
-
Copy full SHA for 5e3b8cc - Browse repository at this point
Copy the full SHA 5e3b8ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4fac314 - Browse repository at this point
Copy the full SHA 4fac314View commit details -
Extracted vtrack.ModifyVastXmlString to avoid conversions
This avoids unnecessary conversions between json and string ok github.com/prebid/prebid-server/endpoints/events 0.034s coverage: 96.1% of statements
Configuration menu - View commit details
-
Copy full SHA for 3298144 - Browse repository at this point
Copy the full SHA 3298144View commit details
Commits on Dec 8, 2020
-
Addressed feedback and removed unused function
- Fixed comments - Removed redundant types in func proto - Add bool parameter to `ModifyVastXmlString()` to indicate string was changed - Decode RawMessage instead of casting to string (to handle encoded escapes) > ok github.com/prebid/prebid-server/endpoints/events 0.039s coverage: 97.4% of statements
Configuration menu - View commit details
-
Copy full SHA for 420bcfb - Browse repository at this point
Copy the full SHA 420bcfbView commit details
Commits on Dec 10, 2020
-
(spec update) Return modified VAST in bid response
When the VAST is modified to insert the event tracking tag, the modified creative is also returned in the bid response, in addition to being cached. Behavior currently implemented requires targeting enabled. Also renamed eventsData->eventTracking
Configuration menu - View commit details
-
Copy full SHA for 6577890 - Browse repository at this point
Copy the full SHA 6577890View commit details
Commits on Dec 15, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 1613af9 - Browse repository at this point
Copy the full SHA 1613af9View commit details
Commits on Dec 16, 2020
-
Modify unit tests to updated spec:
- all bids have vast modified if account and bidder enabled, not just winning - all NON-VIDEO bids have events if account or request enabled - all cached NON-VIDEO bids have wurl patched in if account or request enabled. prebid#1015 (comment)
Configuration menu - View commit details
-
Copy full SHA for 6797b3a - Browse repository at this point
Copy the full SHA 6797b3aView commit details -
Implemented spec changes to satisfy unit tests
prebid#1015 (comment) - all VIDEO bids, cached and returned, have modified VAST if account and bidder enabled - not just winning cached bids. - all NON-VIDEO returned bids have `ext.prebid.events` if account or request enabled - all cached NON-VIDEO bids have `wurl` patched in if account or request enabled.
Configuration menu - View commit details
-
Copy full SHA for 5f3018a - Browse repository at this point
Copy the full SHA 5f3018aView commit details
Commits on Jan 6, 2021
-
ext.prebid.events now overrides server config
VAST is modified if *either* account or request setting demanded it. prebid#1015 (comment)
Configuration menu - View commit details
-
Copy full SHA for 6377bd0 - Browse repository at this point
Copy the full SHA 6377bd0View commit details -
Merge branch 'master-prebid' into events
# Conflicts: # exchange/exchange.go # exchange/exchange_test.go
Configuration menu - View commit details
-
Copy full SHA for 1c893c0 - Browse repository at this point
Copy the full SHA 1c893c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for e029984 - Browse repository at this point
Copy the full SHA e029984View commit details
Commits on Jan 13, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 166a640 - Browse repository at this point
Copy the full SHA 166a640View commit details -
Configuration menu - View commit details
-
Copy full SHA for 95f308c - Browse repository at this point
Copy the full SHA 95f308cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 889cdc3 - Browse repository at this point
Copy the full SHA 889cdc3View commit details
Commits on Jan 14, 2021
-
Configuration menu - View commit details
-
Copy full SHA for f8c95b4 - Browse repository at this point
Copy the full SHA f8c95b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for e3acfcb - Browse repository at this point
Copy the full SHA e3acfcbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 023aa65 - Browse repository at this point
Copy the full SHA 023aa65View commit details
Commits on Jan 15, 2021
-
Configuration menu - View commit details
-
Copy full SHA for b07a87d - Browse repository at this point
Copy the full SHA b07a87dView commit details -
Merge branch 'master-prebid' into events
# Conflicts: # openrtb_ext/request.go
Configuration menu - View commit details
-
Copy full SHA for 0d0c20d - Browse repository at this point
Copy the full SHA 0d0c20dView commit details