Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Events support in bid responses #1597

Merged
merged 20 commits into from
Jan 20, 2021
Merged

Adding Events support in bid responses #1597

merged 20 commits into from
Jan 20, 2021

Commits on Dec 1, 2020

  1. Initial implementation - cache wurl, cache vast rewrite, bid.ext.preb…

    …id.events
    
    Missing timestamp (waiting for prebid#1584)
    laurb9 committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    57bb6f1 View commit details
    Browse the repository at this point in the history
  2. Cache unit tests, some test refactoring.

    - wurl insertion in cached bids
    - vast modifying in video bids
    laurb9 committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    5e3b8cc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4fac314 View commit details
    Browse the repository at this point in the history
  4. Extracted vtrack.ModifyVastXmlString to avoid conversions

    This avoids unnecessary conversions between json and string
    
    ok  	github.com/prebid/prebid-server/endpoints/events	0.034s	coverage: 96.1% of statements
    laurb9 committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    3298144 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2020

  1. Addressed feedback and removed unused function

    - Fixed comments
    - Removed redundant types in func proto
    - Add bool parameter to `ModifyVastXmlString()` to indicate string was changed
    - Decode RawMessage instead of casting to string (to handle encoded escapes)
    
    > ok github.com/prebid/prebid-server/endpoints/events	0.039s	coverage: 97.4% of statements
    laurb9 committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    420bcfb View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2020

  1. (spec update) Return modified VAST in bid response

    When the VAST is modified to insert the event tracking tag,
    the modified creative is also returned in the bid response, in addition to being cached.
    
    Behavior currently implemented requires targeting enabled.
    
    Also renamed eventsData->eventTracking
    laurb9 committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    6577890 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2020

  1. Configuration menu
    Copy the full SHA
    1613af9 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2020

  1. Modify unit tests to updated spec:

    - all bids have vast modified if account and bidder enabled, not just winning
    - all NON-VIDEO bids have events if account or request enabled
    - all cached NON-VIDEO bids have wurl patched in if account or request enabled.
    
    prebid#1015 (comment)
    laurb9 committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    6797b3a View commit details
    Browse the repository at this point in the history
  2. Implemented spec changes to satisfy unit tests

    prebid#1015 (comment)
    
    - all VIDEO bids, cached and returned, have modified VAST if account and bidder enabled - not just winning cached bids.
    - all NON-VIDEO returned bids have `ext.prebid.events` if account or request enabled
    - all cached NON-VIDEO bids have `wurl` patched in if account or request enabled.
    laurb9 committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    5f3018a View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2021

  1. ext.prebid.events now overrides server config

    VAST is modified if *either* account or request setting demanded it.
    
    prebid#1015 (comment)
    laurb9 committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    6377bd0 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'master-prebid' into events

    # Conflicts:
    #	exchange/exchange.go
    #	exchange/exchange_test.go
    laurb9 committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    1c893c0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e029984 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2021

  1. Configuration menu
    Copy the full SHA
    166a640 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    95f308c View commit details
    Browse the repository at this point in the history
  3. Consistent &

    laurb9 committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    889cdc3 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2021

  1. ACCOUNT_ID->TEST_ACC_ID

    laurb9 committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    f8c95b4 View commit details
    Browse the repository at this point in the history
  2. nitpick

    laurb9 committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    e3acfcb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    023aa65 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2021

  1. Configuration menu
    Copy the full SHA
    b07a87d View commit details
    Browse the repository at this point in the history
  2. Merge branch 'master-prebid' into events

    # Conflicts:
    #	openrtb_ext/request.go
    laurb9 committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    0d0c20d View commit details
    Browse the repository at this point in the history