-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Events support in bid responses #1597
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
57bb6f1
Initial implementation - cache wurl, cache vast rewrite, bid.ext.preb…
laurb9 5e3b8cc
Cache unit tests, some test refactoring.
laurb9 4fac314
Add timestamp to event after #1584 was merged
laurb9 3298144
Extracted vtrack.ModifyVastXmlString to avoid conversions
laurb9 420bcfb
Addressed feedback and removed unused function
laurb9 6577890
(spec update) Return modified VAST in bid response
laurb9 1613af9
Merge branch 'master' into events
laurb9 6797b3a
Modify unit tests to updated spec:
laurb9 5f3018a
Implemented spec changes to satisfy unit tests
laurb9 6377bd0
ext.prebid.events now overrides server config
laurb9 1c893c0
Merge branch 'master-prebid' into events
laurb9 e029984
pbsmetrics -> metrics in new code also
laurb9 166a640
turn off request.events to match test
laurb9 95f308c
Remove unused response timestamp section
laurb9 889cdc3
Consistent `&`
laurb9 f8c95b4
ACCOUNT_ID->TEST_ACC_ID
laurb9 e3acfcb
nitpick
laurb9 023aa65
modifyBidJSON() reports error to client on failure
laurb9 b07a87d
Reworded boolean expression
laurb9 0d0c20d
Merge branch 'master-prebid' into events
laurb9 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we fall back to
string(data)
or justdata
here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thought we can just return the original
data
unmodified as it's already json.RawMessage.