release.yml run build before creating new tag

[guscarreon]

Github actions release.yml is tagging before verifying whether or not the code compiles sucessfully. This led to tags 0.268.0 and 0.269.0 to both point to the same commit when the former's release failed. This pull request makes release.yml pull from current master branch and perform a build before moving on to create a new tag.

[onkarvhanumante]

few points here,

• The two steps mentioned above checkouts master branch twice. Instead, we can checkout the branch once and then proceeding to the build step.
• Build command will run successful even if certain unit tests fail. Should also execute the validate.sh script
• Also should add if condition to check if hasWritePermission is true

 build-master:
    name: Build master
    needs: check-permission
    if: contains(needs.check-permission.outputs.hasWritePermission, 'true')
    runs-on: ubuntu-latest
    steps:
      - name: Checkout
        uses: actions/checkout@master
        with:
          fetch-depth: 0
          repository: ${{ github.repository }}
          ref: master
      - name: Validate and build
        run: |
          ./validate.sh
          make build

[guscarreon]

Thanks for the reivew. Addressed your comments in 9477772

The two steps mentioned above checkouts master branch twice. Instead, we can checkout the branch once and then proceeding to the build step.

Copy/paste error. Corrected

Build command will run successful even if certain unit tests fail. Should also execute the validate.sh script

Good point. Added. I ran the make command before validate though

Also should add if condition to check if hasWritePermission is true

Added

[onkarvhanumante]

👍🏼

[hhhjort]

I am not sure we need the go build . I don't think it is possible for it not to compile, but still manage to pass all the unit tests,

[onkarvhanumante]

Agree go build . command will execute successfully only if all tests pass. Can update script to only run validate.sh

       - name:  Validate 
         run: ./validate.sh
         

[guscarreon]

Good catch. Removed

[hhhjort]

Looks good other than the one quibble.

[hhhjort]

LGTM