Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release.yml run build before creating new tag #3032

Merged
merged 5 commits into from
Sep 12, 2023
Merged

release.yml run build before creating new tag #3032

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c72134b
release.yml should run sucessful build before creating new tag
guscarreon Aug 15, 2023
9477772
Onkar's review
guscarreon Aug 16, 2023
6f9a560
Don't use make
guscarreon Aug 17, 2023
77f7ef2
swaped validate and build commands
guscarreon Aug 31, 2023
bdd780f
Remove unnecessary build command
guscarreon Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ jobs:
ref: master
- name: Build and validate
run: |
go build .
./validate.sh
go build .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure we need the go build . I don't think it is possible for it not to compile, but still manage to pass all the unit tests,

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree go build . command will execute successfully only if all tests pass. Can update script to only run validate.sh

       - name:  Validate 
         run: ./validate.sh

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Removed


publish-tag:
name: Publish tag
Expand Down