Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImproveDigital: updates #3077

Merged
merged 7 commits into from
Sep 29, 2023
Merged

ImproveDigital: updates #3077

merged 7 commits into from
Sep 29, 2023

Conversation

ishihanvcs
Copy link
Contributor

  • support for mtype
  • support for .GPP
  • support for audio

ishihanvcs and others added 2 commits August 25, 2023 05:53
@ishihanvcs
implemented changes to enable latest feature upgrades
52cdcf3
@ishihanvcs
Merge pull request #14 from ImproveDigital/hbt-311-pbs-adapter-improv…
5019205 
…ements

implemented changes to enable latest feature upgrades:

- support for mtype
- support for .GPP
- support for audio
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 5019205

improvedigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:48:	MakeRequests				87.5%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:65:	makeRequest				84.2%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:105:	MakeBids				97.0%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:175:	Builder					100.0%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:182:	getBidType				85.7%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:232:	findImpByID				100.0%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:243:	isMultiFormatImp			90.0%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:261:	getAdditionalConsentProvidersUserExt	80.0%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:319:	getImpExtWithRewardedInventory		81.2%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:348:	buildEndpointURL			100.0%
total:										(statements)				87.9%

@gargcreation1992 gargcreation1992 changed the title ImproveDigital adapter updates ImproveDigital adapter: updates Sep 6, 2023
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 088bd79

improvedigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:48:	MakeRequests				87.5%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:65:	makeRequest				84.2%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:105:	MakeBids				97.0%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:175:	Builder					100.0%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:182:	getBidType				85.7%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:232:	findImpByID				100.0%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:243:	isMultiFormatImp			90.0%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:261:	getAdditionalConsentProvidersUserExt	80.0%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:319:	getImpExtWithRewardedInventory		81.2%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:348:	buildEndpointURL			100.0%
total:										(statements)				87.9%

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, d10eea5

improvedigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:48:	MakeRequests				87.5%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:65:	makeRequest				84.2%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:105:	MakeBids				97.0%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:175:	Builder					100.0%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:182:	getBidType				85.7%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:232:	findImpByID				100.0%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:243:	isMultiFormatImp			90.0%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:261:	getAdditionalConsentProvidersUserExt	80.0%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:319:	getImpExtWithRewardedInventory		81.2%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:348:	buildEndpointURL			100.0%
total:										(statements)				87.9%

@onkarvhanumante
Copy link
Contributor

@ishihanvcs requesting to address PR comments to move forward with this PR

@bsardo bsardo changed the title ImproveDigital adapter: updates ImproveDigital: updates Sep 20, 2023
@github-actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 5cfbb34

improvedigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:48:	MakeRequests				87.5%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:65:	makeRequest				84.2%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:105:	MakeBids				97.0%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:175:	Builder					100.0%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:182:	getBidType				85.7%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:232:	findImpByID				100.0%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:243:	isMultiFormatImp			90.0%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:261:	getAdditionalConsentProvidersUserExt	80.0%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:319:	getImpExtWithRewardedInventory		81.2%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:348:	buildEndpointURL			100.0%
total:										(statements)				87.9%

@github-actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 6f3d1f4

improvedigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:48:	MakeRequests				87.5%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:65:	makeRequest				84.2%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:105:	MakeBids				97.2%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:180:	Builder					100.0%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:187:	getBidType				95.2%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:239:	isMultiFormatImp			100.0%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:257:	getAdditionalConsentProvidersUserExt	80.0%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:315:	getImpExtWithRewardedInventory		81.2%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:344:	buildEndpointURL			100.0%
total:										(statements)				89.9%

@ishihanvcs
Copy link
Contributor Author

@ishihanvcs requesting to address PR comments to move forward with this PR

Sorry for the delay. I was away from work due to sudden illness & family issues. Both PR comments has been addressed in latest commit.

@onkarvhanumante
Copy link
Contributor

onkarvhanumante commented Sep 26, 2023 •
edited
Loading

@ishihanvcs requesting to address PR comments to move forward with this PR

Sorry for the delay. I was away from work due to sudden illness & family issues. Both PR comments has been addressed in latest commit.

thank you @ishihanvcs

@github-actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, ef9509f

improvedigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:48:	MakeRequests				87.5%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:65:	makeRequest				84.2%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:105:	MakeBids				97.2%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:180:	Builder					100.0%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:187:	getBidType				100.0%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:239:	isMultiFormatImp			100.0%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:257:	getAdditionalConsentProvidersUserExt	80.0%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:315:	getImpExtWithRewardedInventory		81.2%
github.com/prebid/prebid-server/adapters/improvedigital/improvedigital.go:344:	buildEndpointURL			100.0%
total:										(statements)				90.5%

@Sonali-More-Xandr Sonali-More-Xandr merged commit 0d488ee into prebid:master Sep 29, 2023
5 checks passed
@cross-repo-issue-creation cross-repo-issue-creation bot mentioned this pull request Sep 29, 2023
Closed
ishihanvcs pushed a commit to ImproveDigital/prebid-server-java that referenced this pull request Oct 2, 2023
Fix issue prebid#2666 - Port PR from PBS-Go: ImproveDigital: updates
22e0011 
Ported changes merged in prebid/prebid-server#3077
- support for mtypeo
- support for .GPP
- support for audio
@ishihanvcs ishihanvcs mentioned this pull request Oct 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SyntaxNode SyntaxNode SyntaxNode left review comments

@Sonali-More-Xandr Sonali-More-Xandr Sonali-More-Xandr approved these changes

@onkarvhanumante onkarvhanumante onkarvhanumante approved these changes

Assignees

@onkarvhanumante onkarvhanumante

@Sonali-More-Xandr Sonali-More-Xandr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ishihanvcs @onkarvhanumante @SyntaxNode @Sonali-More-Xandr