Adnuntius: Add Price Type #3084

mikael-lundin · 2023-09-07T17:37:07Z

This PR will allow Prebid server to request a price type. The ad will be returned with either net, or gross bid depending on what you specify.

…cify in your bidderExt

github-actions · 2023-09-07T17:38:22Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, d0f130d

adnuntius

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:90:	Builder			100.0%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:100:	MakeRequests		100.0%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:104:	setHeaders		100.0%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:120:	makeEndpointUrl		89.3%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:170:	getImpSizes		90.0%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:193:	generateRequests	90.0%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:287:	MakeBids		81.8%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:314:	getGDPR			85.7%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:339:	generateAdResponse	90.0%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:393:	generateBidResponse	88.0%
total:									(statements)		89.4%

onkarvhanumante · 2023-09-11T12:29:34Z

adapters/adnuntius/adnuntius.go

 	adDomain := []string{}
 	for _, url := range ad.DestinationUrls {
 		domainArray := strings.Split(url, "/")
 		domain := strings.Replace(domainArray[2], "www.", "", -1)
 		adDomain = append(adDomain, domain)
 	}

+	// strings.ToLower(str)


nitpick: should remove comment

onkarvhanumante · 2023-09-11T12:32:07Z

openrtb_ext/imp_adnuntius.go

@@ -5,4 +5,5 @@ type ImpExtAdnunitus struct {
 	Network   string `json:"network"`
 	NoCookies bool   `json:"noCookies"`
 	MaxDeals  int    `json:"maxDeals"`
+	PriceType string `json:"priceType,omitempty"`


should also update
https://github.com/prebid/prebid-server/blob/71f76eb39e23d778e7ff3356711004775851e56e/static/bidder-params/adnuntius.json bidder params to include priceType as optional param

@mikael-lundin bidder params is also missing entry for maxDeals. Requesting to update bidder param json to include description for priceType and maxDeals

onkarvhanumante · 2023-09-11T12:38:41Z

openrtb_ext/imp_adnuntius.go

@@ -5,4 +5,5 @@ type ImpExtAdnunitus struct {
 	Network   string `json:"network"`
 	NoCookies bool   `json:"noCookies"`
 	MaxDeals  int    `json:"maxDeals"`
+	PriceType string `json:"priceType,omitempty"`


update params tests to add valid and invalid tests for PriceType and maxDeals

mikael-lundin · 2023-09-11T12:40:01Z

Thanks for the feedback, I've changed it and pushed to this PR.

github-actions · 2023-09-11T12:40:48Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 88ee484

adnuntius

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:90:	Builder			100.0%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:100:	MakeRequests		100.0%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:104:	setHeaders		100.0%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:120:	makeEndpointUrl		89.3%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:170:	getImpSizes		90.0%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:193:	generateRequests	90.0%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:287:	MakeBids		81.8%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:314:	getGDPR			85.7%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:339:	generateAdResponse	90.0%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:391:	generateBidResponse	88.0%
total:									(statements)		89.4%

onkarvhanumante · 2023-09-11T12:40:53Z

@mikael-lundin should create docs PR to include details for PriceType and maxDeals

onkarvhanumante · 2023-09-11T12:47:01Z

adapters/adnuntius/adnuntius.go

+		Currency string
+	}
+	GrossBid struct {
+		Amount   float64
+		Currency string


@mikael-lundin could you help to understand how values are set to NetBid.Currency and GrossBid.Currency. If these vars are not in use then can should remove them

They are always returned from the ad-server so they will always be included in the response.

But yeah you are right they can be removed. :)

github-actions · 2023-09-11T13:19:46Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, a7ce04f

adnuntius

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:88:	Builder			100.0%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:98:	MakeRequests		100.0%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:102:	setHeaders		100.0%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:118:	makeEndpointUrl		89.3%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:168:	getImpSizes		90.0%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:191:	generateRequests	90.0%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:285:	MakeBids		81.8%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:312:	getGDPR			85.7%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:337:	generateAdResponse	90.0%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:389:	generateBidResponse	88.0%
total:									(statements)		89.4%

SyntaxNode · 2023-09-12T04:03:15Z

adapters/adnuntius/adnuntius.go

@@ -344,6 +350,18 @@ func generateAdResponse(ad Ad, impId string, html string, request *openrtb2.BidR
 		}}
 	}

+	price := ad.Bid.Amount
+	priceType, _, _, _ := jsonparser.Get(imp.Ext, "bidder", "priceType")


Please do not ignore errors.

I changed the way I fetched the value. because the way I did it above, it wouldn't allow for the key to be omitted it seemed. Hope my new way of doing it is good.

SyntaxNode · 2023-09-12T04:03:39Z

adapters/adnuntius/adnuntius.go

+	priceType, _, _, _ := jsonparser.Get(imp.Ext, "bidder", "priceType")
+
+	if string(priceType) != "" {
+		if strings.ToLower(string(priceType)) == "net" {


Please prefer to use strings.EqualFold for a case insensitive comparison.

Thanks, this is changed.

mikael-lundin · 2023-09-12T09:29:22Z

I'm waiting for this PR to go through before adding the prebid server things:
https://github.com/prebid/prebid.github.io/pull/4849/files

Is it ok to have one name for prebid client and another for prebid server? it seems when I looked into the documentation that server prefered the name "priceType"

github-actions · 2023-09-12T12:04:01Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, e847ee1

adnuntius

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:88:	Builder			100.0%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:98:	MakeRequests		100.0%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:102:	setHeaders		100.0%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:118:	makeEndpointUrl		89.3%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:168:	getImpSizes		90.0%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:191:	generateRequests	92.5%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:286:	MakeBids		81.8%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:313:	getGDPR			85.7%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:338:	generateAdResponse	84.0%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:403:	generateBidResponse	88.0%
total:									(statements)		89.1%

onkarvhanumante · 2023-09-14T07:24:14Z

I'm waiting for this PR to go through before adding the prebid server things: https://github.com/prebid/prebid.github.io/pull/4849/files

Is it ok to have one name for prebid client and another for prebid server? it seems when I looked into the documentation that server prefered the name "priceType"

assuming prebid.js is being referred as prebid client. It would be better if both prebid js and prebid server use same name for new bidder info param.

mikael-lundin · 2023-09-19T08:46:37Z

Good to know, I will make change the name in prebid server as well.

onkarvhanumante · 2023-09-28T05:49:34Z

Good to know, I will make change the name in prebid server as well.

@mikael-lundin any updates to move this PR forward

mikael-lundin · 2023-09-28T09:52:17Z

Yes, will be done today! sorry for the wait.

github-actions · 2023-09-28T10:16:39Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 429a99c

adnuntius

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:88:	Builder			100.0%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:98:	MakeRequests		100.0%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:102:	setHeaders		100.0%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:118:	makeEndpointUrl		89.3%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:168:	getImpSizes		90.0%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:191:	generateRequests	92.5%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:286:	MakeBids		81.8%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:313:	getGDPR			85.7%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:338:	generateAdResponse	84.0%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:403:	generateBidResponse	88.0%
total:									(statements)		89.1%

onkarvhanumante · 2023-09-28T10:57:24Z

static/bidder-params/adnuntius.json

+        "priceType": {
+            "type": "string",
+            "description": "Allows you to specify Net or Gross bids."


should update priceType to bidType

github-actions · 2023-09-28T12:46:18Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 9096e25

adnuntius

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:88:	Builder			100.0%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:98:	MakeRequests		100.0%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:102:	setHeaders		100.0%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:118:	makeEndpointUrl		89.3%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:168:	getImpSizes		90.0%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:191:	generateRequests	92.5%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:286:	MakeBids		81.8%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:313:	getGDPR			85.7%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:338:	generateAdResponse	84.0%
github.com/prebid/prebid-server/adapters/adnuntius/adnuntius.go:403:	generateBidResponse	88.0%
total:									(statements)		89.1%

Select Netbid or GrossBid from the adserver depending on what you spe…

d0f130d

…cify in your bidderExt

gargcreation1992 assigned gargcreation1992 and onkarvhanumante Sep 8, 2023

onkarvhanumante reviewed Sep 11, 2023

View reviewed changes

Changes according to feedback.

88ee484

onkarvhanumante reviewed Sep 11, 2023

View reviewed changes

Removed Currency from Adnuntius.

a7ce04f

SyntaxNode reviewed Sep 12, 2023

View reviewed changes

SyntaxNode changed the title ~~Adnuntius Bid Adapter~~ Adnuntius: Add Price Type Sep 12, 2023

Adding error check and making sure that priceType can be optional.

e847ee1

Changed name to bidType.

429a99c

onkarvhanumante reviewed Sep 28, 2023

View reviewed changes

Changed static bidder-params to say the same name as the other places.

9096e25

onkarvhanumante approved these changes Sep 28, 2023

View reviewed changes

gargcreation1992 approved these changes Sep 29, 2023

View reviewed changes

gargcreation1992 merged commit 4ad946b into prebid:master Sep 29, 2023
5 checks passed

cross-repo-issue-creation bot mentioned this pull request Sep 29, 2023

Port PR from PBS-Go: Adnuntius: Add Price Type prebid/prebid-server-java#2668

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adnuntius: Add Price Type #3084

Adnuntius: Add Price Type #3084

mikael-lundin commented Sep 7, 2023

github-actions bot commented Sep 7, 2023

onkarvhanumante Sep 11, 2023

onkarvhanumante Sep 11, 2023 •

edited

Loading

onkarvhanumante Sep 11, 2023 •

edited

Loading

mikael-lundin commented Sep 11, 2023

github-actions bot commented Sep 11, 2023

onkarvhanumante commented Sep 11, 2023

onkarvhanumante Sep 11, 2023

mikael-lundin Sep 11, 2023

mikael-lundin Sep 11, 2023

github-actions bot commented Sep 11, 2023

SyntaxNode Sep 12, 2023

mikael-lundin Sep 12, 2023

SyntaxNode Sep 12, 2023

mikael-lundin Sep 12, 2023

mikael-lundin commented Sep 12, 2023

github-actions bot commented Sep 12, 2023

onkarvhanumante commented Sep 14, 2023

mikael-lundin commented Sep 19, 2023

onkarvhanumante commented Sep 28, 2023

mikael-lundin commented Sep 28, 2023

github-actions bot commented Sep 28, 2023

onkarvhanumante Sep 28, 2023

mikael-lundin Sep 28, 2023

github-actions bot commented Sep 28, 2023

Adnuntius: Add Price Type #3084

Adnuntius: Add Price Type #3084

Conversation

mikael-lundin commented Sep 7, 2023

github-actions bot commented Sep 7, 2023

Code coverage summary

adnuntius

Choose a reason for hiding this comment

onkarvhanumante Sep 11, 2023 • edited Loading

Choose a reason for hiding this comment

onkarvhanumante Sep 11, 2023 • edited Loading

Choose a reason for hiding this comment

mikael-lundin commented Sep 11, 2023

github-actions bot commented Sep 11, 2023

Code coverage summary

adnuntius

onkarvhanumante commented Sep 11, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Sep 11, 2023

Code coverage summary

adnuntius

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mikael-lundin commented Sep 12, 2023

github-actions bot commented Sep 12, 2023

Code coverage summary

adnuntius

onkarvhanumante commented Sep 14, 2023

mikael-lundin commented Sep 19, 2023

onkarvhanumante commented Sep 28, 2023

mikael-lundin commented Sep 28, 2023

github-actions bot commented Sep 28, 2023

Code coverage summary

adnuntius

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Sep 28, 2023

Code coverage summary

adnuntius

onkarvhanumante Sep 11, 2023 •

edited

Loading

onkarvhanumante Sep 11, 2023 •

edited

Loading